[GitHub] [calcite] snuyanzin commented on a diff in pull request #3113: [CALCITE-5567] Enable jdk19 in ci

snuyanzin commented on code in PR #3113: URL: https://github.com/apache/calcite/pull/3113#discussion_r1214460250 ## core/src/main/java/org/apache/calcite/util/Util.java: ## @@ -1717,16 +1719,14 @@ private static void appendPosixTime(StringBuilder buf, int millis) { *

[GitHub] [calcite] snuyanzin commented on a diff in pull request #3113: [CALCITE-5567] Enable jdk19 in ci

snuyanzin commented on code in PR #3113: URL: https://github.com/apache/calcite/pull/3113#discussion_r1213976159 ## site/_docs/history.md: ## @@ -43,6 +43,10 @@ z. Breaking Changes {: #breaking-1-35-0} +The way of Locale parsing changed within

[GitHub] [calcite] snuyanzin commented on a diff in pull request #3113: [CALCITE-5567] Enable jdk19 in ci

snuyanzin commented on code in PR #3113: URL: https://github.com/apache/calcite/pull/3113#discussion_r1213265269 ## core/src/main/java/org/apache/calcite/util/Util.java: ## @@ -1717,16 +1719,14 @@ private static void appendPosixTime(StringBuilder buf, int millis) { *

[GitHub] [calcite] snuyanzin commented on a diff in pull request #3113: [CALCITE-5567] Enable jdk19 in ci

snuyanzin commented on code in PR #3113: URL: https://github.com/apache/calcite/pull/3113#discussion_r1213265269 ## core/src/main/java/org/apache/calcite/util/Util.java: ## @@ -1717,16 +1719,14 @@ private static void appendPosixTime(StringBuilder buf, int millis) { *

[GitHub] [calcite] snuyanzin commented on a diff in pull request #3113: [CALCITE-5567] Enable jdk19 in ci

snuyanzin commented on code in PR #3113: URL: https://github.com/apache/calcite/pull/3113#discussion_r1213124528 ## core/src/main/java/org/apache/calcite/sql/parser/SqlParserUtil.java: ## @@ -738,17 +741,7 @@ public static ParsedCollation parseCollation(String in) { }

[GitHub] [calcite] snuyanzin commented on a diff in pull request #3113: [CALCITE-5567] Enable jdk19 in ci

snuyanzin commented on code in PR #3113: URL: https://github.com/apache/calcite/pull/3113#discussion_r1195047623 ## core/src/test/java/org/apache/calcite/util/UtilTest.java: ## @@ -914,7 +914,7 @@ private List makeConsList(int start, int end) { } // Example locale

[GitHub] [calcite] snuyanzin commented on a diff in pull request #3113: [CALCITE-5567] Enable jdk19 in ci

snuyanzin commented on code in PR #3113: URL: https://github.com/apache/calcite/pull/3113#discussion_r1195046819 ## core/src/test/java/org/apache/calcite/util/UtilTest.java: ## @@ -914,7 +914,7 @@ private List makeConsList(int start, int end) { } // Example locale

[GitHub] [calcite] snuyanzin commented on a diff in pull request #3113: [CALCITE-5567] Enable jdk19 in ci

snuyanzin commented on code in PR #3113: URL: https://github.com/apache/calcite/pull/3113#discussion_r1195045461 ## core/src/main/java/org/apache/calcite/sql/parser/SqlParserUtil.java: ## @@ -738,17 +741,7 @@ public static ParsedCollation parseCollation(String in) { }

[GitHub] [calcite] snuyanzin commented on a diff in pull request #3113: [CALCITE-5567] Enable jdk19 in ci

snuyanzin commented on code in PR #3113: URL: https://github.com/apache/calcite/pull/3113#discussion_r1195045461 ## core/src/main/java/org/apache/calcite/sql/parser/SqlParserUtil.java: ## @@ -738,17 +741,7 @@ public static ParsedCollation parseCollation(String in) { }