[GitHub] [calcite] tanclary commented on a diff in pull request #3389: [CALCITE-5935] Add CODE_POINTS_TO_BYTES function (enabled in BigQuery…

2023-08-30 Thread via GitHub
tanclary commented on code in PR #3389: URL: https://github.com/apache/calcite/pull/3389#discussion_r1310490016 ## core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java: ## @@ -510,6 +510,38 @@ public static SqlOperandTypeChecker variadic( } }; +

[GitHub] [calcite] tanclary commented on a diff in pull request #3389: [CALCITE-5935] Add CODE_POINTS_TO_BYTES function (enabled in BigQuery…

2023-08-28 Thread via GitHub
tanclary commented on code in PR #3389: URL: https://github.com/apache/calcite/pull/3389#discussion_r1307576002 ## core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java: ## @@ -510,6 +510,38 @@ public static SqlOperandTypeChecker variadic( } }; +

[GitHub] [calcite] tanclary commented on a diff in pull request #3389: [CALCITE-5935] Add CODE_POINTS_TO_BYTES function (enabled in BigQuery…

2023-08-22 Thread via GitHub
tanclary commented on code in PR #3389: URL: https://github.com/apache/calcite/pull/3389#discussion_r1301811407 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -929,6 +929,29 @@ public static String charFromUtf8(int n) { return

[GitHub] [calcite] tanclary commented on a diff in pull request #3389: [CALCITE-5935] Add CODE_POINTS_TO_BYTES function (enabled in BigQuery…

2023-08-22 Thread via GitHub
tanclary commented on code in PR #3389: URL: https://github.com/apache/calcite/pull/3389#discussion_r1301810987 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -929,6 +929,29 @@ public static String charFromUtf8(int n) { return