tanclary commented on code in PR #3395:
URL: https://github.com/apache/calcite/pull/3395#discussion_r1311824276
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java:
##########
@@ -1309,6 +1311,64 @@ public static boolean isMeasure(SqlNode selectItem) {
return null;
}
+ /**
+ * When the array element does not equal with the array component type,
making explicit casting.
+ *
+ * @param componentType derived array component type
+ * @param opBinding description of call
+ */
+ public static void adjustTypeForArrayConstructor(
+ RelDataType componentType, SqlOperatorBinding opBinding) {
+ if (opBinding instanceof SqlCallBinding) {
+ requireNonNull(componentType, "array component type");
+ adjustTypeForMultisetConstructor(
+ componentType, componentType, (SqlCallBinding) opBinding);
+ }
+ }
+
+ /**
+ * When the map key or value does not equal with the map component key type
or value type,
+ * making explicit casting.
+ *
+ * @param componentType derived map pair component type
+ * @param opBinding description of call
+ */
+ public static void adjustTypeForMapConstructor(
+ Pair<RelDataType, RelDataType> componentType, SqlOperatorBinding
opBinding) {
+ if (opBinding instanceof SqlCallBinding) {
+ requireNonNull(componentType.getKey(), "map key type");
+ requireNonNull(componentType.getValue(), "map value type");
+ adjustTypeForMultisetConstructor(
+ componentType.getKey(), componentType.getValue(), (SqlCallBinding)
opBinding);
+ }
+ }
+
+ private static void adjustTypeForMultisetConstructor(
+ RelDataType evenType, RelDataType oddType, SqlCallBinding
sqlCallBinding) {
+ SqlCall call = sqlCallBinding.getCall();
+ List<RelDataType> operandTypes = sqlCallBinding.collectOperandTypes();
+ List<SqlNode> operands = call.getOperandList();
+ RelDataType elementType;
+ for (int i = 0; i < operands.size(); i++) {
+ if (i % 2 == 0) {
+ elementType = evenType;
+ } else {
+ elementType = oddType;
+ }
+ if (operandTypes.get(i).equalsSansFieldNames(elementType)) {
Review Comment:
can this be rewritten as `if(!operandTypes.get(i)....) { call.setOperand() }`
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java:
##########
@@ -1309,6 +1311,64 @@ public static boolean isMeasure(SqlNode selectItem) {
return null;
}
+ /**
+ * When the array element does not equal with the array component type,
making explicit casting.
Review Comment:
i think you can remove `with` and change making->make
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
