[GitHub] [calcite] tanclary commented on a diff in pull request #3408: [CALCITE-5978] Add REGEXP_INSTR function (enabled in BigQuery library)

tanclary commented on code in PR #3408: URL: https://github.com/apache/calcite/pull/3408#discussion_r1318980163 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -404,16 +404,39 @@ private Pattern validateRegexPattern(String regex, String methodName) {

[GitHub] [calcite] tanclary commented on a diff in pull request #3408: [CALCITE-5978] Add REGEXP_INSTR function (enabled in BigQuery library)

tanclary commented on code in PR #3408: URL: https://github.com/apache/calcite/pull/3408#discussion_r1317629669 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -488,13 +502,74 @@ public List regexpExtractAll(String value, String regex) {