[GitHub] [calcite] tanclary commented on pull request #3303: [CALCITE-5827] Add IS_INF and IS_NAN functions (enabled in BigQuery l…

2023-08-07 Thread via GitHub
tanclary commented on PR #3303: URL: https://github.com/apache/calcite/pull/3303#issuecomment-1668224893 @herunkang2018 Could you elaborate on your comment about the decimal testing? is that blocking this PR? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] tanclary commented on pull request #3303: [CALCITE-5827] Add IS_INF and IS_NAN functions (enabled in BigQuery l…

2023-08-03 Thread via GitHub
tanclary commented on PR #3303: URL: https://github.com/apache/calcite/pull/3303#issuecomment-1664828263 @herunkang2018 @julianhyde I responded to your comments, let me know if you have any other suggestions. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] tanclary commented on pull request #3303: [CALCITE-5827] Add IS_INF and IS_NAN functions (enabled in BigQuery l…

2023-07-11 Thread via GitHub
tanclary commented on PR #3303: URL: https://github.com/apache/calcite/pull/3303#issuecomment-1631520602 @julianhyde Responded to your comments, thanks for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use