[GitHub] [calcite] tanclary commented on pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

2023-09-11 Thread via GitHub
tanclary commented on PR #3367: URL: https://github.com/apache/calcite/pull/3367#issuecomment-1714168149 @LakeShen Yes, happy to help. Would you mind squashing your commits? Feel free to re-ping me after and I will try to merge  -- This is an automated message from the Apache Git

[GitHub] [calcite] tanclary commented on pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

2023-08-31 Thread via GitHub
tanclary commented on PR #3367: URL: https://github.com/apache/calcite/pull/3367#issuecomment-1701291551 > Hi @tanclary @NobiGo ,I have already added the e2e test for my rule,if you have time, please help me to review again, thank you very much:) I think this looks good but I am less