[GitHub] [calcite] vlsi commented on a change in pull request #2236: [CALCITE-3913] Test correctness using formal verification (Qi Zhou)

2020-11-03 Thread GitBox
vlsi commented on a change in pull request #2236: URL: https://github.com/apache/calcite/pull/2236#discussion_r516285366 ## File path: core/src/test/java/org/apache/calcite/test/SmtLibTest.java ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [calcite] vlsi commented on a change in pull request #2236: [CALCITE-3913] Test correctness using formal verification (Qi Zhou)

2020-10-30 Thread GitBox
vlsi commented on a change in pull request #2236: URL: https://github.com/apache/calcite/pull/2236#discussion_r514989716 ## File path: core/src/test/java/org/apache/calcite/test/verifier/SmtLibTest.java ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [calcite] vlsi commented on a change in pull request #2236: [CALCITE-3913] Test correctness using formal verification (Qi Zhou)

2020-10-30 Thread GitBox
vlsi commented on a change in pull request #2236: URL: https://github.com/apache/calcite/pull/2236#discussion_r514979126 ## File path: core/src/test/java/org/apache/calcite/test/verifier/SymbolicColumn.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software

[GitHub] [calcite] vlsi commented on a change in pull request #2236: [CALCITE-3913] Test correctness using formal verification (Qi Zhou)

2020-10-30 Thread GitBox
vlsi commented on a change in pull request #2236: URL: https://github.com/apache/calcite/pull/2236#discussion_r514917503 ## File path: core/build.gradle.kts ## @@ -60,6 +60,7 @@ dependencies { implementation("org.codehaus.janino:commons-compiler")