[GitHub] [calcite] vlsi commented on a change in pull request #2237: [CALCITE-4368] TopDownOptTest fails if applying non-substitution rule first

[GitBox]

vlsi commented on a change in pull request #2237:
URL: https://github.com/apache/calcite/pull/2237#discussion_r515870606



##########
File path: 
core/src/main/java/org/apache/calcite/plan/volcano/TopDownRuleDriver.java
##########
@@ -335,6 +336,14 @@ default boolean onProduce(RelNode node) {
           physicals.add(rel);
         }
       }
+
+      // No need to apply O_INPUTS if the group has not been implemented yet.

Review comment:
       What is `O_INPUTS`?

##########
File path: 
core/src/main/java/org/apache/calcite/plan/volcano/TopDownRuleDriver.java
##########
@@ -335,6 +336,14 @@ default boolean onProduce(RelNode node) {
           physicals.add(rel);
         }
       }
+
+      // No need to apply O_INPUTS if the group has not been implemented yet.

Review comment:
       I see no reasons to invent obscure words when the thing can be explained 
in plain English.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org