[GitHub] [calcite] vlsi commented on a change in pull request #2238: [CALCITE-4364] `a IN (1, 2) AND a = 1` should be simplified to `a = 1`

2020-11-05 Thread GitBox
vlsi commented on a change in pull request #2238: URL: https://github.com/apache/calcite/pull/2238#discussion_r517864129 ## File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml ## @@ -6217,7 +6217,7 @@ LogicalProject(EXPR$0=[1])

[GitHub] [calcite] vlsi commented on a change in pull request #2238: [CALCITE-4364] `a IN (1, 2) AND a = 1` should be simplified to `a = 1`

2020-11-04 Thread GitBox
vlsi commented on a change in pull request #2238: URL: https://github.com/apache/calcite/pull/2238#discussion_r517845769 ## File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml ## @@ -6217,7 +6217,7 @@ LogicalProject(EXPR$0=[1])

[GitHub] [calcite] vlsi commented on a change in pull request #2238: [CALCITE-4364] `a IN (1, 2) AND a = 1` should be simplified to `a = 1`

2020-11-03 Thread GitBox
vlsi commented on a change in pull request #2238: URL: https://github.com/apache/calcite/pull/2238#discussion_r516743019 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1330,7 +1330,7 @@ RexNode simplifyAnd(RexCall e, RexUnknownAs unknownAs) {

[GitHub] [calcite] vlsi commented on a change in pull request #2238: [CALCITE-4364] `a in (1, 2) and a = 1` should be simplified to `a=1`

2020-11-03 Thread GitBox
vlsi commented on a change in pull request #2238: URL: https://github.com/apache/calcite/pull/2238#discussion_r516246682 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1330,7 +1330,7 @@ RexNode simplifyAnd(RexCall e, RexUnknownAs unknownAs) {