[GitHub] [calcite] xndai commented on issue #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes

2019-12-04 Thread GitBox
xndai commented on issue #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes URL: https://github.com/apache/calcite/pull/1543#issuecomment-561899807 Thanks @zabetak for the pointer. After reviewing the whole thread, I now understand why @vlsi believes this is

[GitHub] [calcite] xndai commented on issue #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes

2019-12-03 Thread GitBox
xndai commented on issue #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes URL: https://github.com/apache/calcite/pull/1543#issuecomment-561483689 > I have a question related to CALCITE-3455 but not necessarily related to this PR: > How about providing an

[GitHub] [calcite] xndai commented on issue #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes

2019-12-03 Thread GitBox
xndai commented on issue #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes URL: https://github.com/apache/calcite/pull/1543#issuecomment-561374301 @vlsi @zabetak @rubenada @hsyuan I've updated this patch based on your feedback. Now I create separate

[GitHub] [calcite] xndai commented on issue #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes

2019-11-14 Thread GitBox
xndai commented on issue #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes URL: https://github.com/apache/calcite/pull/1543#issuecomment-554097058 > Have you seen https://issues.apache.org/jira/browse/CALCITE-2223 ? > I think 3455 duplicates 2223, and,

[GitHub] [calcite] xndai commented on issue #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes

2019-11-12 Thread GitBox
xndai commented on issue #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes URL: https://github.com/apache/calcite/pull/1543#issuecomment-552992313 @danny0405 had a good feedback - since ProjectMergeRule can also be used by HepPlanner, and in some cases user

[GitHub] [calcite] xndai commented on issue #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes

2019-10-29 Thread GitBox
xndai commented on issue #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes URL: https://github.com/apache/calcite/pull/1543#issuecomment-547744860 > Quotes Julian's comment in the mailing list: > > > Is there a change we could make to the rule API that