[GitHub] [calcite] zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

2019-04-27 Thread GitBox
zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#discussion_r279153574 ## File path: core/src/test/java/org/apache/calcite/rex/RexBuilderTest.java ## @@

[GitHub] [calcite] zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

2019-04-27 Thread GitBox
zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#discussion_r279147199 ## File path: core/src/test/java/org/apache/calcite/rex/RexBuilderTest.java ## @@

[GitHub] [calcite] zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

2019-04-27 Thread GitBox
zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#discussion_r279147130 ## File path: core/src/main/java/org/apache/calcite/rex/RexCopier.java ## @@ -52,

[GitHub] [calcite] zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

2019-04-23 Thread GitBox
zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#discussion_r277596536 ## File path: core/src/test/java/org/apache/calcite/rex/RexBuilderTest.java ## @@

[GitHub] [calcite] zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

2019-04-23 Thread GitBox
zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#discussion_r277595197 ## File path: core/src/main/java/org/apache/calcite/rex/RexCopier.java ## @@ -52,

[GitHub] [calcite] zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

2019-04-22 Thread GitBox
zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#discussion_r277534862 ## File path: core/src/main/java/org/apache/calcite/rex/RexCopier.java ## @@ -52,

[GitHub] [calcite] zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

2019-04-22 Thread GitBox
zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#discussion_r277286713 ## File path: core/src/main/java/org/apache/calcite/rex/RexCopier.java ## @@ -52,

[GitHub] [calcite] zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

2019-04-22 Thread GitBox
zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#discussion_r277288371 ## File path: core/src/test/java/org/apache/calcite/rex/RexBuilderTest.java ## @@