[GitHub] [calcite] zstan commented on pull request #3203: [CALCITE-5703] Reduce amount of generated runtime code

2023-05-25 Thread via GitHub
zstan commented on PR #3203: URL: https://github.com/apache/calcite/pull/3203#issuecomment-1562446539 > Sorry for the late reply. I make some tests in my local environment. The optimization for `BinaryExpression` seems to be incorrect. The code after optimization throws compilation error.

[GitHub] [calcite] zstan commented on pull request #3203: [CALCITE-5703] Reduce amount of generated runtime code

2023-05-24 Thread via GitHub
zstan commented on PR #3203: URL: https://github.com/apache/calcite/pull/3203#issuecomment-1561573151 > Sorry for the late reply. I make some tests in my local environment. The optimization for `BinaryExpression` seems to be incorrect. The code after optimization throws compilation error.