This is an automated email from the ASF dual-hosted git repository.

zabetak pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/calcite-site.git

commit 9dd60c59bb8eed5b6b80e99f173046c6c8e51ff6
Author: Stamatis Zampetakis <zabe...@gmail.com>
AuthorDate: Fri Sep 24 16:29:04 2021 +0200

    Site: Remove contributors name from commit summary
    
    See discussion in dev@ list[1].
    
    [1] 
https://lists.apache.org/thread.html/r0e198225f7912fa3d6eb910b9c271b2856cf156e87caadca5bf4cd8e%40%3Cdev.calcite.apache.org%3E
---
 develop/index.html | 5 ++---
 docs/howto.html    | 3 ---
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/develop/index.html b/develop/index.html
index 9169e2b..506d564 100644
--- a/develop/index.html
+++ b/develop/index.html
@@ -186,7 +186,7 @@ the contributor(s) involved in the discussion should:</p>
 <p>Commit your change to your branch, and use a comment that starts with
 the JIRA case number, like this:</p>
 
-<figure class="highlight"><pre><code class="language-text" 
data-lang="text">[CALCITE-345] AssertionError in RexToLixTranslator comparing 
to date literal (FirstName LastName)</code></pre></figure>
+<figure class="highlight"><pre><code class="language-text" 
data-lang="text">[CALCITE-345] AssertionError in RexToLixTranslator comparing 
to date literal</code></pre></figure>
 
 <p>If your change had multiple commits, use <code 
class="highlighter-rouge">git rebase -i master</code> to
 squash them into a single commit, and to bring your code up to date
@@ -201,6 +201,7 @@ description of the change.</li>
   <li>The message is often, but not always, the same as the JIRA subject.
 If the JIRA subject is not clear, change it (perhaps move the original
 subject to the description of the JIRA case, if it clarifies).</li>
+  <li>Leave a single space character after the JIRA id.</li>
   <li>Start with a capital letter.</li>
   <li>Do not finish with a period.</li>
   <li>Use imperative mood (“Add a handler …”) rather than past tense
@@ -211,8 +212,6 @@ the implementation (“Add handler for FileNotFound”).</li>
   <li>If you are fixing a bug, it is sufficient to describe the bug
  (“NullPointerException if user is unknown”) and people will correctly
  surmise that the purpose of your change is to fix the bug.</li>
-  <li>If you are not a committer, add your name in parentheses at the end
- of the message.</li>
 </ul>
 
 <p>Then push your commit(s) to GitHub, and create a pull request from
diff --git a/docs/howto.html b/docs/howto.html
index 3ac5e22..b044c0a 100644
--- a/docs/howto.html
+++ b/docs/howto.html
@@ -693,9 +693,6 @@ If there are conflicts it is better to ask the contributor 
to take this step,
 otherwise it is preferred to do this manually since it saves time and also
 avoids unnecessary notification messages to many people on GitHub.</p>
 
-<p>If the contributor is not a committer, add their name in parentheses at the 
end
-of the first line of the commit message.</p>
-
 <p>If the merge is performed via command line (not through the GitHub web
 interface), make sure the message contains a line “Close apache/calcite#YYY”,
 where YYY is the GitHub pull request identifier.</p>

Reply via email to