Re: [PR] [MINOR] fix typo message [calcite]

2023-12-10 Thread via GitHub
JiajunBernoulli commented on PR #3578: URL: https://github.com/apache/calcite/pull/3578#issuecomment-1849209323 > > 1. The first letter should be capitalized. > > 2. Message is not accurate enough: We should use `Better message when `. > > So do I need to modify the commit

Re: [PR] [MINOR] fix typo message [calcite]

2023-12-10 Thread via GitHub
caicancai commented on PR #3578: URL: https://github.com/apache/calcite/pull/3578#issuecomment-1849206288 > 1. The first letter should be capitalized. > 2. Message is not accurate enough: We should use `Better message when `. So do I need to modify the commit message? --

Re: [PR] [MINOR] fix typo message [calcite]

2023-12-10 Thread via GitHub
JiajunBernoulli commented on PR #3578: URL: https://github.com/apache/calcite/pull/3578#issuecomment-1849203005 1. The first letter should be capitalized. 2. Message is not accurate enough: We should use `Better message when `. -- This is an automated message from the Apache Git

Re: [PR] [MINOR] fix typo message [calcite]

2023-12-10 Thread via GitHub
sonarcloud[bot] commented on PR #3578: URL: https://github.com/apache/calcite/pull/3578#issuecomment-1848986107 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png