[GitHub] [calcite] rubenada edited a comment on issue #1314: [CALCITE-3118] IndexOutOfBoundsException in ProjectFilterTransposeRul…

rubenada edited a comment on issue #1314: [CALCITE-3118] IndexOutOfBoundsException in ProjectFilterTransposeRul… URL: https://github.com/apache/calcite/pull/1314#issuecomment-510062287 @danny0405 , jira number in the PR title seems wrong. I guess you mean CALCITE-3188?

[GitHub] [calcite] rubenada commented on issue #1314: [CALCITE-3118] IndexOutOfBoundsException in ProjectFilterTransposeRul…

rubenada commented on issue #1314: [CALCITE-3118] IndexOutOfBoundsException in ProjectFilterTransposeRul… URL: https://github.com/apache/calcite/pull/1314#issuecomment-510062287 @danny0405 , jira number seems wrong. I guess you mean CALCITE-3188?

[GitHub] [calcite] zabetak commented on issue #1308: [CALCITE-3184] Add the new logo to the website

zabetak commented on issue #1308: [CALCITE-3184] Add the new logo to the website URL: https://github.com/apache/calcite/pull/1308#issuecomment-510035518 Thanks for your kind words and the comments @F21, @danny0405, @vlsi. @vlsi I did some compression but not with the tool you

[GitHub] [calcite] danny0405 commented on issue #1311: [CALCITE-3187] Make decimal type inference overridable.

danny0405 commented on issue #1311: [CALCITE-3187] Make decimal type inference overridable. URL: https://github.com/apache/calcite/pull/1311#issuecomment-510044270 Why you add a dot in the title end, please don't do that

[GitHub] [calcite] danny0405 opened a new pull request #1314: [CALCITE-3118] IndexOutOfBoundsException in ProjectFilterTransposeRul…

danny0405 opened a new pull request #1314: [CALCITE-3118] IndexOutOfBoundsException in ProjectFilterTransposeRul… URL: https://github.com/apache/calcite/pull/1314 …e when executing SELECT COUNT(*)(in progress) This is an

[GitHub] [calcite] danny0405 commented on issue #1314: [CALCITE-3188] IndexOutOfBoundsException in ProjectFilterTransposeRul…

danny0405 commented on issue #1314: [CALCITE-3188] IndexOutOfBoundsException in ProjectFilterTransposeRul… URL: https://github.com/apache/calcite/pull/1314#issuecomment-510067162 > @danny0405 , jira number in the PR title seems wrong. I guess you mean CALCITE-3188? Thanks @rubenada

[GitHub] [calcite] jh3507 commented on a change in pull request #1309: [CALCITE-3183] Trimming method for Filter rel uses wrong traitSet

jh3507 commented on a change in pull request #1309: [CALCITE-3183] Trimming method for Filter rel uses wrong traitSet URL: https://github.com/apache/calcite/pull/1309#discussion_r302236474 ## File path: site/_docs/algebra.md ## @@ -309,7 +309,7 @@ return the `RelBuilder`.

[GitHub] [calcite] jh3507 commented on a change in pull request #1309: [CALCITE-3183] Trimming method for Filter rel uses wrong traitSet

jh3507 commented on a change in pull request #1309: [CALCITE-3183] Trimming method for Filter rel uses wrong traitSet URL: https://github.com/apache/calcite/pull/1309#discussion_r302236503 ## File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java ## @@

[GitHub] [calcite] yanlin-Lynn commented on issue #1301: [CALCITE-3175]Json seralize and deseralize of RexLiteral with Enum type operand.

yanlin-Lynn commented on issue #1301: [CALCITE-3175]Json seralize and deseralize of RexLiteral with Enum type operand. URL: https://github.com/apache/calcite/pull/1301#issuecomment-510309112 > According Calcite's PR convention, the title should describe the problem being solved briefly.

[GitHub] [calcite] asereda-gs opened a new pull request #1315: Fix complitation warnings after mongo java driver upgrade

asereda-gs opened a new pull request #1315: Fix complitation warnings after mongo java driver upgrade URL: https://github.com/apache/calcite/pull/1315 Some methods were deprecated after client upgrade to 3.10.2 (see [CALCITE-3157])

[calcite] branch master updated: Fix complitation warnings after mongo java driver upgrade

This is an automated email from the ASF dual-hosted git repository. sereda pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new fe2b59b Fix complitation warnings after mongo

[GitHub] [calcite] asereda-gs merged pull request #1315: Fix complitation warnings after mongo java driver upgrade

asereda-gs merged pull request #1315: Fix complitation warnings after mongo java driver upgrade URL: https://github.com/apache/calcite/pull/1315 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] asereda-gs commented on a change in pull request #1313: [CALCITE-3190] ElasticsearchJson throws Exception when visitMappingProperties

asereda-gs commented on a change in pull request #1313: [CALCITE-3190] ElasticsearchJson throws Exception when visitMappingProperties URL: https://github.com/apache/calcite/pull/1313#discussion_r302357829 ## File path:

[GitHub] [calcite] danny0405 merged pull request #1314: [CALCITE-3188] IndexOutOfBoundsException in ProjectFilterTransposeRul…

danny0405 merged pull request #1314: [CALCITE-3188] IndexOutOfBoundsException in ProjectFilterTransposeRul… URL: https://github.com/apache/calcite/pull/1314 This is an automated message from the Apache Git Service. To

[calcite] branch master updated: [CALCITE-3188] IndexOutOfBoundsException in ProjectFilterTransposeRule when executing SELECT COUNT(*)

This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 954f27c [CALCITE-3188]

[GitHub] [calcite] danny0405 commented on issue #1314: [CALCITE-3188] IndexOutOfBoundsException in ProjectFilterTransposeRul…

danny0405 commented on issue #1314: [CALCITE-3188] IndexOutOfBoundsException in ProjectFilterTransposeRul… URL: https://github.com/apache/calcite/pull/1314#issuecomment-510320817 @zabetak Thanks for testing this PR, i have added the `isStruct` check before invoking `#getFieldList`.

[GitHub] [calcite] asereda-gs commented on a change in pull request #1313: [CALCITE-3190] ElasticsearchJson throws Exception when visitMappingProperties

asereda-gs commented on a change in pull request #1313: [CALCITE-3190] ElasticsearchJson throws Exception when visitMappingProperties URL: https://github.com/apache/calcite/pull/1313#discussion_r302357829 ## File path:

[GitHub] [calcite] praveenbingo commented on issue #1311: [CALCITE-3187] Make decimal type inference overridable

praveenbingo commented on issue #1311: [CALCITE-3187] Make decimal type inference overridable URL: https://github.com/apache/calcite/pull/1311#issuecomment-510322369 > Why you add a dot in the title end, please don't do that Sure, removed.

[GitHub] [calcite] asereda-gs commented on a change in pull request #1313: [CALCITE-3190] ElasticsearchJson throws Exception when visitMappingProperties

asereda-gs commented on a change in pull request #1313: [CALCITE-3190] ElasticsearchJson throws Exception when visitMappingProperties URL: https://github.com/apache/calcite/pull/1313#discussion_r302357829 ## File path:

[GitHub] [calcite] praveenbingo commented on a change in pull request #1311: [CALCITE-3187] Make decimal type inference overridable.

praveenbingo commented on a change in pull request #1311: [CALCITE-3187] Make decimal type inference overridable. URL: https://github.com/apache/calcite/pull/1311#discussion_r301968686 ## File path: core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java ## @@

[GitHub] [calcite] praveenbingo commented on a change in pull request #1311: [CALCITE-3187] Make decimal type inference overridable.

praveenbingo commented on a change in pull request #1311: [CALCITE-3187] Make decimal type inference overridable. URL: https://github.com/apache/calcite/pull/1311#discussion_r301968745 ## File path: core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java ## @@

[GitHub] [calcite] praveenbingo commented on a change in pull request #1311: [CALCITE-3187] Make decimal type inference overridable.

praveenbingo commented on a change in pull request #1311: [CALCITE-3187] Make decimal type inference overridable. URL: https://github.com/apache/calcite/pull/1311#discussion_r301969664 ## File path: core/src/main/java/org/apache/calcite/rel/type/RelDataTypeFactory.java ##

[GitHub] [calcite] praveenbingo commented on a change in pull request #1311: [CALCITE-3187] Make decimal type inference overridable.

praveenbingo commented on a change in pull request #1311: [CALCITE-3187] Make decimal type inference overridable. URL: https://github.com/apache/calcite/pull/1311#discussion_r301969818 ## File path: core/src/main/java/org/apache/calcite/rel/type/RelDataTypeFactory.java ##

[GitHub] [calcite] rubenada commented on a change in pull request #1310: [CALCITE-3113] Equivalent MutableAggregates with different row types should match with each other.

rubenada commented on a change in pull request #1310: [CALCITE-3113] Equivalent MutableAggregates with different row types should match with each other. URL: https://github.com/apache/calcite/pull/1310#discussion_r301997275 ## File path:

[GitHub] [calcite] danny0405 commented on issue #1310: [CALCITE-3113] Equivalent MutableAggregates with different row types should match with each other.

danny0405 commented on issue #1310: [CALCITE-3113] Equivalent MutableAggregates with different row types should match with each other. URL: https://github.com/apache/calcite/pull/1310#issuecomment-509921250 > What do we do elsewhere (e.g. in RelOptRules)? Do we check whether row-types are

[GitHub] [calcite] danny0405 edited a comment on issue #1310: [CALCITE-3113] Equivalent MutableAggregates with different row types should match with each other.

danny0405 edited a comment on issue #1310: [CALCITE-3113] Equivalent MutableAggregates with different row types should match with each other. URL: https://github.com/apache/calcite/pull/1310#issuecomment-509921250 > What do we do elsewhere (e.g. in RelOptRules)? Do we check whether

[GitHub] [calcite] danny0405 edited a comment on issue #1310: [CALCITE-3113] Equivalent MutableAggregates with different row types should match with each other.

danny0405 edited a comment on issue #1310: [CALCITE-3113] Equivalent MutableAggregates with different row types should match with each other. URL: https://github.com/apache/calcite/pull/1310#issuecomment-509921250 > What do we do elsewhere (e.g. in RelOptRules)? Do we check whether

[GitHub] [calcite] durpersi opened a new pull request #1313: [CALCITE-3190] ElasticsearchJson throws Exception when visitMappingProperties

durpersi opened a new pull request #1313: [CALCITE-3190] ElasticsearchJson throws Exception when visitMappingProperties URL: https://github.com/apache/calcite/pull/1313 related jira https://issues.apache.org/jira/browse/CALCITE-3190

[GitHub] [calcite] hsyuan commented on a change in pull request #1313: [CALCITE-3190] ElasticsearchJson throws Exception when visitMappingProperties

hsyuan commented on a change in pull request #1313: [CALCITE-3190] ElasticsearchJson throws Exception when visitMappingProperties URL: https://github.com/apache/calcite/pull/1313#discussion_r301913347 ## File path:

[GitHub] [calcite] rubenada commented on a change in pull request #1309: [CALCITE-3183] Trimming method for Filter rel uses wrong traitSet

rubenada commented on a change in pull request #1309: [CALCITE-3183] Trimming method for Filter rel uses wrong traitSet URL: https://github.com/apache/calcite/pull/1309#discussion_r301924195 ## File path: site/_docs/algebra.md ## @@ -309,7 +309,7 @@ return the

[GitHub] [calcite] durpersi commented on a change in pull request #1313: [CALCITE-3190] ElasticsearchJson throws Exception when visitMappingProperties

durpersi commented on a change in pull request #1313: [CALCITE-3190] ElasticsearchJson throws Exception when visitMappingProperties URL: https://github.com/apache/calcite/pull/1313#discussion_r301950841 ## File path:

[GitHub] [calcite] jinxing64 commented on issue #1310: [CALCITE-3113] Equivalent MutableAggregates with different row types should match with each other.

jinxing64 commented on issue #1310: [CALCITE-3113] Equivalent MutableAggregates with different row types should match with each other. URL: https://github.com/apache/calcite/pull/1310#issuecomment-509975425 @julianhyde @danny0405 THX a lot for review ! In this change, when

[GitHub] [calcite] jinxing64 commented on a change in pull request #1310: [CALCITE-3113] Equivalent MutableAggregates with different row types should match with each other.

jinxing64 commented on a change in pull request #1310: [CALCITE-3113] Equivalent MutableAggregates with different row types should match with each other. URL: https://github.com/apache/calcite/pull/1310#discussion_r301951557 ## File path: