[GitHub] [calcite] vlsi commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR

2019-12-04 Thread GitBox
vlsi commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR URL: https://github.com/apache/calcite/pull/1610#discussion_r353607385 ## File path: core/src/main/java/org/apache/calcite/rel/rules/FilterProjectTransposeRule.java

[GitHub] [calcite] yanlin-Lynn opened a new pull request #1626: [CALCITE-3561] Support using unnest in Interpreter

2019-12-04 Thread GitBox
yanlin-Lynn opened a new pull request #1626: [CALCITE-3561] Support using unnest in Interpreter URL: https://github.com/apache/calcite/pull/1626 Jira: [CALCITE-3561](https://issues.apache.org/jira/browse/CALCITE-3561) This PR tries to add support for using unnest in `Interpreter`.

[GitHub] [calcite] chunweilei commented on issue #1627: [CALCITE-3566] Support EnumerableIntersect and EnumerableMinus convert to Logical

2019-12-04 Thread GitBox
chunweilei commented on issue #1627: [CALCITE-3566] Support EnumerableIntersect and EnumerableMinus convert to Logical URL: https://github.com/apache/calcite/pull/1627#issuecomment-561582983 LGTM. This is an automated

[GitHub] [calcite] xy2953396112 opened a new pull request #1627: [CALCITE-3566] Support EnumerableIntersect and EnumerableMinus convert to Logical

2019-12-04 Thread GitBox
xy2953396112 opened a new pull request #1627: [CALCITE-3566] Support EnumerableIntersect and EnumerableMinus convert to Logical URL: https://github.com/apache/calcite/pull/1627 this pr try to support EnumerableIntersect and EnumerableMinus convert to Logical.

[GitHub] [calcite] rubenada commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR

2019-12-04 Thread GitBox
rubenada commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR URL: https://github.com/apache/calcite/pull/1610#discussion_r353601564 ## File path:

[GitHub] [calcite] ihuzenko commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR

2019-12-04 Thread GitBox
ihuzenko commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR URL: https://github.com/apache/calcite/pull/1610#discussion_r353623923 ## File path: core/src/test/java/org/apache/calcite/test/RexProgramTest.java ## @@

[calcite] branch master updated (abe7729 -> 0e16fe3)

2019-12-04 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from abe7729 [CALCITE-3355] Deduce whether CASE and COALESCE may produce NULL values add 0e16fe3 [CALCITE-3536]

[GitHub] [calcite] zabetak closed pull request #1605: [CALCITE-3536] Wrong semantics in CoalesceImplementor

2019-12-04 Thread GitBox
zabetak closed pull request #1605: [CALCITE-3536] Wrong semantics in CoalesceImplementor URL: https://github.com/apache/calcite/pull/1605 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [calcite] ihuzenko commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR

2019-12-04 Thread GitBox
ihuzenko commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR URL: https://github.com/apache/calcite/pull/1610#discussion_r353639227 ## File path:

[calcite] branch master updated (0e16fe3 -> ecc68ac)

2019-12-04 Thread vladimirsitnikov
This is an automated email from the ASF dual-hosted git repository. vladimirsitnikov pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 0e16fe3 [CALCITE-3536] NPE when executing plan with Coalesce due to wrong NullAs strategy (Jin Xing)

[GitHub] [calcite] rubenada commented on issue #1614: [CALCITE-3546] Improve EnumerableDefaults nested loop join

2019-12-04 Thread GitBox
rubenada commented on issue #1614: [CALCITE-3546] Improve EnumerableDefaults nested loop join URL: https://github.com/apache/calcite/pull/1614#issuecomment-561610527 Thanks @jinxing64 Regarding the tests, I just re-triggered them (2 hours ago). However the "old" Github CI executions

[GitHub] [calcite] vlsi closed pull request #1617: [CALCITE-3548] rename ubenchmark/src/main/jmh to ubenchmark/src/jmh/java

2019-12-04 Thread GitBox
vlsi closed pull request #1617: [CALCITE-3548] rename ubenchmark/src/main/jmh to ubenchmark/src/jmh/java URL: https://github.com/apache/calcite/pull/1617 This is an automated message from the Apache Git Service. To respond

[GitHub] [calcite] rubenada commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR

2019-12-04 Thread GitBox
rubenada commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR URL: https://github.com/apache/calcite/pull/1610#discussion_r353668409 ## File path: mongodb/src/test/java/org/apache/calcite/adapter/mongodb/MongoAdapterTest.java

[GitHub] [calcite] zabetak commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR

2019-12-04 Thread GitBox
zabetak commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR URL: https://github.com/apache/calcite/pull/1610#discussion_r353678039 ## File path: core/src/main/java/org/apache/calcite/rel/rules/FilterProjectTransposeRule.java

[GitHub] [calcite] rubenada commented on issue #1614: [CALCITE-3546] Improve EnumerableDefaults nested loop join

2019-12-04 Thread GitBox
rubenada commented on issue #1614: [CALCITE-3546] Improve EnumerableDefaults nested loop join URL: https://github.com/apache/calcite/pull/1614#issuecomment-561603491 @jinxing64 @danny0405 @julianhyde @yanlin-Lynn any other comments on this topic? If nobody objects, I would like to

[GitHub] [calcite] danny0405 opened a new pull request #1629: [CALCITE-3550] Make SqlTypeAssignmentRules conversion mapping pluggable

2019-12-04 Thread GitBox
danny0405 opened a new pull request #1629: [CALCITE-3550] Make SqlTypeAssignmentRules conversion mapping pluggable URL: https://github.com/apache/calcite/pull/1629 * Add a base class named SqlTypeMappingRules that defines some utilities to build type mappings; * Add

[GitHub] [calcite] ihuzenko commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR

2019-12-04 Thread GitBox
ihuzenko commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR URL: https://github.com/apache/calcite/pull/1610#discussion_r353620082 ## File path: core/src/test/java/org/apache/calcite/test/RexProgramBuilderBase.java

[GitHub] [calcite] ihuzenko commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR

2019-12-04 Thread GitBox
ihuzenko commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR URL: https://github.com/apache/calcite/pull/1610#discussion_r353628674 ## File path:

[GitHub] [calcite] rubenada opened a new pull request #1614: [CALCITE-3546] Improve EnumerableDefaults nested loop join

2019-12-04 Thread GitBox
rubenada opened a new pull request #1614: [CALCITE-3546] Improve EnumerableDefaults nested loop join URL: https://github.com/apache/calcite/pull/1614 Jira ticket: [CALCITE-3546](https://issues.apache.org/jira/browse/CALCITE-3546) The current implementation of

[GitHub] [calcite] rubenada closed pull request #1614: [CALCITE-3546] Improve EnumerableDefaults nested loop join

2019-12-04 Thread GitBox
rubenada closed pull request #1614: [CALCITE-3546] Improve EnumerableDefaults nested loop join URL: https://github.com/apache/calcite/pull/1614 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] ihuzenko commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR

2019-12-04 Thread GitBox
ihuzenko commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR URL: https://github.com/apache/calcite/pull/1610#discussion_r353655131 ## File path:

[GitHub] [calcite] vlsi commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR

2019-12-04 Thread GitBox
vlsi commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR URL: https://github.com/apache/calcite/pull/1610#discussion_r353667049 ## File path: core/src/main/java/org/apache/calcite/rel/rules/FilterProjectTransposeRule.java

[GitHub] [calcite] vlsi commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR

2019-12-04 Thread GitBox
vlsi commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR URL: https://github.com/apache/calcite/pull/1610#discussion_r35361 ## File path: core/src/main/java/org/apache/calcite/rel/rules/FilterProjectTransposeRule.java

[GitHub] [calcite] jinxing64 commented on issue #1605: [CALCITE-3536] Wrong semantics in CoalesceImplementor

2019-12-04 Thread GitBox
jinxing64 commented on issue #1605: [CALCITE-3536] Wrong semantics in CoalesceImplementor URL: https://github.com/apache/calcite/pull/1605#issuecomment-561601361 Thanks for merging ~ This is an automated message from the

[GitHub] [calcite] vlsi commented on issue #1625: [CALCITE-3559] Drop HydromaticFileSetCheck, upgrade Checkstyle

2019-12-04 Thread GitBox
vlsi commented on issue #1625: [CALCITE-3559] Drop HydromaticFileSetCheck, upgrade Checkstyle URL: https://github.com/apache/calcite/pull/1625#issuecomment-561563891 Showcase. Input file with formatting violations: ```java public class Babel { // This class is currently a

[GitHub] [calcite] zabetak commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR

2019-12-04 Thread GitBox
zabetak commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR URL: https://github.com/apache/calcite/pull/1610#discussion_r353631567 ## File path: core/src/main/java/org/apache/calcite/rel/rules/FilterProjectTransposeRule.java

[GitHub] [calcite] jinxing64 commented on issue #1614: [CALCITE-3546] Improve EnumerableDefaults nested loop join

2019-12-04 Thread GitBox
jinxing64 commented on issue #1614: [CALCITE-3546] Improve EnumerableDefaults nested loop join URL: https://github.com/apache/calcite/pull/1614#issuecomment-561604735 +1 This is an automated message from the Apache Git

[GitHub] [calcite] jinxing64 commented on issue #1614: [CALCITE-3546] Improve EnumerableDefaults nested loop join

2019-12-04 Thread GitBox
jinxing64 commented on issue #1614: [CALCITE-3546] Improve EnumerableDefaults nested loop join URL: https://github.com/apache/calcite/pull/1614#issuecomment-561604937 @rubenada You might trigger the test to run again.

[GitHub] [calcite] vlsi commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR

2019-12-04 Thread GitBox
vlsi commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR URL: https://github.com/apache/calcite/pull/1610#discussion_r35361 ## File path: core/src/main/java/org/apache/calcite/rel/rules/FilterProjectTransposeRule.java

[GitHub] [calcite] DonnyZone opened a new pull request #1628: [CALCITE-3565] Explicitly cast assignable operand types to decimal fo udf

2019-12-04 Thread GitBox
DonnyZone opened a new pull request #1628: [CALCITE-3565] Explicitly cast assignable operand types to decimal fo udf URL: https://github.com/apache/calcite/pull/1628 As illustrated in [CALCITE-3565](https://issues.apache.org/jira/browse/CALCITE-3565), one type can be assigned from

[GitHub] [calcite] ihuzenko commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR

2019-12-04 Thread GitBox
ihuzenko commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR URL: https://github.com/apache/calcite/pull/1610#discussion_r353726088 ## File path: mongodb/src/test/java/org/apache/calcite/adapter/mongodb/MongoAdapterTest.java

[GitHub] [calcite] vlsi commented on a change in pull request #1547: [CALCITE-3460] Poor performance in RexReplacer for large queries

2019-12-04 Thread GitBox
vlsi commented on a change in pull request #1547: [CALCITE-3460] Poor performance in RexReplacer for large queries URL: https://github.com/apache/calcite/pull/1547#discussion_r353749942 ## File path: core/src/main/java/org/apache/calcite/rel/rules/ReduceExpressionsRule.java

[GitHub] [calcite] yanlin-Lynn opened a new pull request #1630: [CALCITE-3567] Unnest support Map wrapped with RecordType

2019-12-04 Thread GitBox
yanlin-Lynn opened a new pull request #1630: [CALCITE-3567] Unnest support Map wrapped with RecordType URL: https://github.com/apache/calcite/pull/1630 JIRA: [CALCITE-3567](https://issues.apache.org/jira/browse/CALCITE-3567) Currently, UNNEST(RECORDTYPE(ARRAY)) and

[GitHub] [calcite] danny0405 commented on a change in pull request #1613: [CALCITE-3542] Implement RepeatUnion All=false

2019-12-04 Thread GitBox
danny0405 commented on a change in pull request #1613: [CALCITE-3542] Implement RepeatUnion All=false URL: https://github.com/apache/calcite/pull/1613#discussion_r353757711 ## File path: core/src/test/java/org/apache/calcite/test/enumerable/EnumerableRepeatUnionHierarchyTest.java

[GitHub] [calcite] vlsi commented on issue #1547: [CALCITE-3460] Poor performance in RexReplacer for large queries

2019-12-04 Thread GitBox
vlsi commented on issue #1547: [CALCITE-3460] Poor performance in RexReplacer for large queries URL: https://github.com/apache/calcite/pull/1547#issuecomment-561651656 LGTM This is an automated message from the Apache Git

[GitHub] [calcite] rubenada commented on a change in pull request #1613: [CALCITE-3542] Implement RepeatUnion All=false

2019-12-04 Thread GitBox
rubenada commented on a change in pull request #1613: [CALCITE-3542] Implement RepeatUnion All=false URL: https://github.com/apache/calcite/pull/1613#discussion_r353771215 ## File path: core/src/test/java/org/apache/calcite/test/enumerable/EnumerableRepeatUnionHierarchyTest.java

[GitHub] [calcite] rubenada commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR

2019-12-04 Thread GitBox
rubenada commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR URL: https://github.com/apache/calcite/pull/1610#discussion_r353731595 ## File path: mongodb/src/test/java/org/apache/calcite/adapter/mongodb/MongoAdapterTest.java

[GitHub] [calcite] chunweilei opened a new pull request #1631: [CALCITE-3569] IndexOutOfBoundsException when pushing simplified filter to view

2019-12-04 Thread GitBox
chunweilei opened a new pull request #1631: [CALCITE-3569] IndexOutOfBoundsException when pushing simplified filter to view URL: https://github.com/apache/calcite/pull/1631 JIRA: https://issues.apache.org/jira/browse/CALCITE-3569.

[GitHub] [calcite] julianhyde commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR

2019-12-04 Thread GitBox
julianhyde commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR URL: https://github.com/apache/calcite/pull/1610#discussion_r353919304 ## File path:

[GitHub] [calcite] vlsi commented on a change in pull request #1632: [CALCITE-3560] Additional calcite.util.Source implementation for generic text source (eg. CharSource)

2019-12-04 Thread GitBox
vlsi commented on a change in pull request #1632: [CALCITE-3560] Additional calcite.util.Source implementation for generic text source (eg. CharSource) URL: https://github.com/apache/calcite/pull/1632#discussion_r353944747 ## File path:

[GitHub] [calcite] asereda-gs commented on a change in pull request #1632: [CALCITE-3560] Additional calcite.util.Source implementation for generic text source (eg. CharSource)

2019-12-04 Thread GitBox
asereda-gs commented on a change in pull request #1632: [CALCITE-3560] Additional calcite.util.Source implementation for generic text source (eg. CharSource) URL: https://github.com/apache/calcite/pull/1632#discussion_r353946698 ## File path:

[GitHub] [calcite] asereda-gs commented on a change in pull request #1632: [CALCITE-3560] Additional calcite.util.Source implementation for generic text source (eg. CharSource)

2019-12-04 Thread GitBox
asereda-gs commented on a change in pull request #1632: [CALCITE-3560] Additional calcite.util.Source implementation for generic text source (eg. CharSource) URL: https://github.com/apache/calcite/pull/1632#discussion_r353946114 ## File path:

[GitHub] [calcite] julianhyde commented on issue #1547: [CALCITE-3460] Poor performance in RexReplacer for large queries

2019-12-04 Thread GitBox
julianhyde commented on issue #1547: [CALCITE-3460] Poor performance in RexReplacer for large queries URL: https://github.com/apache/calcite/pull/1547#issuecomment-561779708 In case you missed my comment in the JIRA case, we must have a unit test for this change.

[GitHub] [calcite] vlsi commented on a change in pull request #1632: [CALCITE-3560] Additional calcite.util.Source implementation for generic text source (eg. CharSource)

2019-12-04 Thread GitBox
vlsi commented on a change in pull request #1632: [CALCITE-3560] Additional calcite.util.Source implementation for generic text source (eg. CharSource) URL: https://github.com/apache/calcite/pull/1632#discussion_r353943555 ## File path:

[GitHub] [calcite] julianhyde commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR

2019-12-04 Thread GitBox
julianhyde commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR URL: https://github.com/apache/calcite/pull/1610#discussion_r353921915 ## File path:

[GitHub] [calcite] asereda-gs opened a new pull request #1632: [CALCITE-3560] Additional calcite.util.Source implementation for generic text source (eg. CharSource)

2019-12-04 Thread GitBox
asereda-gs opened a new pull request #1632: [CALCITE-3560] Additional calcite.util.Source implementation for generic text source (eg. CharSource) URL: https://github.com/apache/calcite/pull/1632 Currently calcite calcite.util.Source interface can be built only from File or URL. This

[GitHub] [calcite] hsyuan commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter

2019-12-04 Thread GitBox
hsyuan commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter URL: https://github.com/apache/calcite/pull/1591#discussion_r353970688 ## File path: redis/src/main/java/org/apache/calcite/adapter/redis/RedisDataType.java ## @@ -0,0 +1,91 @@

[GitHub] [calcite] hsyuan commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter

2019-12-04 Thread GitBox
hsyuan commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter URL: https://github.com/apache/calcite/pull/1591#discussion_r353977593 ## File path: redis/src/test/java/org/apache/calcite/adapter/redis/RedisITCaseBase.java ## @@ -0,0 +1,77 @@

[GitHub] [calcite] hsyuan commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter

2019-12-04 Thread GitBox
hsyuan commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter URL: https://github.com/apache/calcite/pull/1591#discussion_r353976962 ## File path: redis/src/test/java/org/apache/calcite/adapter/redis/RedisServerMini.java ## @@ -0,0 +1,120 @@

[GitHub] [calcite] julianhyde commented on a change in pull request #1624: [Calcite 3558] Fixing indexing variable for the column reordering loop

2019-12-04 Thread GitBox
julianhyde commented on a change in pull request #1624: [Calcite 3558] Fixing indexing variable for the column reordering loop URL: https://github.com/apache/calcite/pull/1624#discussion_r353999204 ## File path:

[GitHub] [calcite] vlsi commented on a change in pull request #1632: [CALCITE-3560] Additional calcite.util.Source implementation for generic text source (eg. CharSource)

2019-12-04 Thread GitBox
vlsi commented on a change in pull request #1632: [CALCITE-3560] Additional calcite.util.Source implementation for generic text source (eg. CharSource) URL: https://github.com/apache/calcite/pull/1632#discussion_r353958184 ## File path:

[GitHub] [calcite] vlsi opened a new pull request #1633: Fix copyright headers, move copyright owner from Resources.java to NOTICE

2019-12-04 Thread GitBox
vlsi opened a new pull request #1633: Fix copyright headers, move copyright owner from Resources.java to NOTICE URL: https://github.com/apache/calcite/pull/1633 Copyright owner should be moved from header to NOTICE as per https://www.apache.org/legal/src-headers.html#headers

[GitHub] [calcite] zabetak commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter

2019-12-04 Thread GitBox
zabetak commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter URL: https://github.com/apache/calcite/pull/1591#discussion_r354037014 ## File path: core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java ## @@ -203,6 +203,12

[GitHub] [calcite] hsyuan commented on a change in pull request #1629: [CALCITE-3550] Make SqlTypeAssignmentRules conversion mapping pluggable

2019-12-04 Thread GitBox
hsyuan commented on a change in pull request #1629: [CALCITE-3550] Make SqlTypeAssignmentRules conversion mapping pluggable URL: https://github.com/apache/calcite/pull/1629#discussion_r353958281 ## File path:

[GitHub] [calcite] asereda-gs commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter

2019-12-04 Thread GitBox
asereda-gs commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter URL: https://github.com/apache/calcite/pull/1591#discussion_r353989295 ## File path: redis/src/main/java/org/apache/calcite/adapter/redis/RedisEnumerator.java ## @@ -0,0 +1,89

[GitHub] [calcite] asereda-gs commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter

2019-12-04 Thread GitBox
asereda-gs commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter URL: https://github.com/apache/calcite/pull/1591#discussion_r353990471 ## File path: redis/src/main/java/org/apache/calcite/adapter/redis/RedisJedisManager.java ## @@ -0,0

[GitHub] [calcite] asereda-gs commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter

2019-12-04 Thread GitBox
asereda-gs commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter URL: https://github.com/apache/calcite/pull/1591#discussion_r353987894 ## File path: redis/src/main/java/org/apache/calcite/adapter/redis/RedisDataBase.java ## @@ -0,0 +1,145

[GitHub] [calcite] asereda-gs commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter

2019-12-04 Thread GitBox
asereda-gs commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter URL: https://github.com/apache/calcite/pull/1591#discussion_r353995002 ## File path: redis/src/test/java/org/apache/calcite/adapter/redis/RedisAdapterITCaseBase.java ## @@

[GitHub] [calcite] asereda-gs commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter

2019-12-04 Thread GitBox
asereda-gs commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter URL: https://github.com/apache/calcite/pull/1591#discussion_r353984537 ## File path: redis/src/test/java/org/apache/calcite/adapter/redis/RedisITCaseBase.java ## @@ -0,0 +1,77

[GitHub] [calcite] asereda-gs commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter

2019-12-04 Thread GitBox
asereda-gs commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter URL: https://github.com/apache/calcite/pull/1591#discussion_r353988841 ## File path: redis/src/main/java/org/apache/calcite/adapter/redis/RedisDataBase.java ## @@ -0,0 +1,145

[GitHub] [calcite] asereda-gs commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter

2019-12-04 Thread GitBox
asereda-gs commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter URL: https://github.com/apache/calcite/pull/1591#discussion_r353986557 ## File path: redis/src/main/java/org/apache/calcite/adapter/redis/RedisDataBase.java ## @@ -0,0 +1,145

[GitHub] [calcite] asereda-gs commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter

2019-12-04 Thread GitBox
asereda-gs commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter URL: https://github.com/apache/calcite/pull/1591#discussion_r353992696 ## File path: redis/src/main/resources/log4j.properties ## @@ -0,0 +1,28 @@ +# Licensed to the Apache

[GitHub] [calcite] asereda-gs commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter

2019-12-04 Thread GitBox
asereda-gs commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter URL: https://github.com/apache/calcite/pull/1591#discussion_r353990724 ## File path: redis/src/main/java/org/apache/calcite/adapter/redis/RedisJedisManager.java ## @@ -0,0

[GitHub] [calcite] asereda-gs commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter

2019-12-04 Thread GitBox
asereda-gs commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter URL: https://github.com/apache/calcite/pull/1591#discussion_r353997327 ## File path: redis/src/main/java/org/apache/calcite/adapter/redis/RedisDataProcess.java ## @@ -0,0

[GitHub] [calcite] asereda-gs commented on a change in pull request #1632: [CALCITE-3560] Additional calcite.util.Source implementation for generic text source (eg. CharSource)

2019-12-04 Thread GitBox
asereda-gs commented on a change in pull request #1632: [CALCITE-3560] Additional calcite.util.Source implementation for generic text source (eg. CharSource) URL: https://github.com/apache/calcite/pull/1632#discussion_r354025708 ## File path:

[GitHub] [calcite] vlsi commented on a change in pull request #1632: [CALCITE-3560] Additional calcite.util.Source implementation for generic text source (eg. CharSource)

2019-12-04 Thread GitBox
vlsi commented on a change in pull request #1632: [CALCITE-3560] Additional calcite.util.Source implementation for generic text source (eg. CharSource) URL: https://github.com/apache/calcite/pull/1632#discussion_r353963017 ## File path:

[GitHub] [calcite] hsyuan commented on issue #1625: [CALCITE-3559] Drop HydromaticFileSetCheck, upgrade Checkstyle

2019-12-04 Thread GitBox
hsyuan commented on issue #1625: [CALCITE-3559] Drop HydromaticFileSetCheck, upgrade Checkstyle URL: https://github.com/apache/calcite/pull/1625#issuecomment-561823031 LGTM This is an automated message from the Apache Git

[GitHub] [calcite] asereda-gs commented on a change in pull request #1632: [CALCITE-3560] Additional calcite.util.Source implementation for generic text source (eg. CharSource)

2019-12-04 Thread GitBox
asereda-gs commented on a change in pull request #1632: [CALCITE-3560] Additional calcite.util.Source implementation for generic text source (eg. CharSource) URL: https://github.com/apache/calcite/pull/1632#discussion_r353971306 ## File path:

[GitHub] [calcite] amaliujia commented on a change in pull request #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR

2019-12-04 Thread GitBox
amaliujia commented on a change in pull request #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR URL: https://github.com/apache/calcite/pull/1587#discussion_r353987008 ## File path:

[GitHub] [calcite] amaliujia commented on a change in pull request #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR

2019-12-04 Thread GitBox
amaliujia commented on a change in pull request #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR URL: https://github.com/apache/calcite/pull/1587#discussion_r353987008 ## File path:

[GitHub] [calcite] vlsi commented on a change in pull request #1633: Fix copyright headers, move copyright owner from Resources.java to NOTICE

2019-12-04 Thread GitBox
vlsi commented on a change in pull request #1633: Fix copyright headers, move copyright owner from Resources.java to NOTICE URL: https://github.com/apache/calcite/pull/1633#discussion_r354015817 ## File path: core/src/main/java/org/apache/calcite/runtime/Resources.java ##

[GitHub] [calcite] vlsi commented on a change in pull request #1633: Fix copyright headers, move copyright owner from Resources.java to NOTICE

2019-12-04 Thread GitBox
vlsi commented on a change in pull request #1633: Fix copyright headers, move copyright owner from Resources.java to NOTICE URL: https://github.com/apache/calcite/pull/1633#discussion_r354015817 ## File path: core/src/main/java/org/apache/calcite/runtime/Resources.java ##

[GitHub] [calcite] zabetak commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter

2019-12-04 Thread GitBox
zabetak commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter URL: https://github.com/apache/calcite/pull/1591#discussion_r354037791 ## File path: redis/src/main/java/org/apache/calcite/adapter/redis/package-info.java ## @@ -0,0 +1,27 @@

[calcite] branch master updated (ecc68ac -> a0931b7)

2019-12-04 Thread hyuan
This is an automated email from the ASF dual-hosted git repository. hyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from ecc68ac [CALCITE-3548] unlock ./gradlew :ubenchmark:jmh to run benchmarks add a0931b7 [CALCITE-3285]

[GitHub] [calcite] hsyuan closed pull request #1576: [CALCITE-3285] EnumerableMergeJoin should support non-equi join condi…

2019-12-04 Thread GitBox
hsyuan closed pull request #1576: [CALCITE-3285] EnumerableMergeJoin should support non-equi join condi… URL: https://github.com/apache/calcite/pull/1576 This is an automated message from the Apache Git Service. To respond

[GitHub] [calcite] julianhyde commented on issue #1633: Fix copyright headers, move copyright owner from Resources.java to NOTICE

2019-12-04 Thread GitBox
julianhyde commented on issue #1633: Fix copyright headers, move copyright owner from Resources.java to NOTICE URL: https://github.com/apache/calcite/pull/1633#issuecomment-561872817 The link you cite is "SOURCE FILE HEADERS FOR CODE DEVELOPED AT THE ASF", does not apply here.

[GitHub] [calcite] asereda-gs commented on issue #1313: [CALCITE-3190] ElasticsearchJson throws Exception when visitMappingProperties

2019-12-04 Thread GitBox
asereda-gs commented on issue #1313: [CALCITE-3190] ElasticsearchJson throws Exception when visitMappingProperties URL: https://github.com/apache/calcite/pull/1313#issuecomment-561899978 @durpersi we're approaching 1.22 release. Do you think you can address review comments before then

[GitHub] [calcite] xndai commented on issue #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes

2019-12-04 Thread GitBox
xndai commented on issue #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes URL: https://github.com/apache/calcite/pull/1543#issuecomment-561899807 Thanks @zabetak for the pointer. After reviewing the whole thread, I now understand why @vlsi believes this is

[GitHub] [calcite] zabetak commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter

2019-12-04 Thread GitBox
zabetak commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter URL: https://github.com/apache/calcite/pull/1591#discussion_r354039300 ## File path: redis/src/test/java/org/apache/calcite/adapter/redis/RedisAdapterITCaseBase.java ## @@ -0,0

[GitHub] [calcite] asereda-gs merged pull request #1631: [CALCITE-3569] IndexOutOfBoundsException when pushing simplified filter to view

2019-12-04 Thread GitBox
asereda-gs merged pull request #1631: [CALCITE-3569] IndexOutOfBoundsException when pushing simplified filter to view URL: https://github.com/apache/calcite/pull/1631 This is an automated message from the Apache Git

[GitHub] [calcite] asereda-gs commented on issue #1631: [CALCITE-3569] IndexOutOfBoundsException when pushing simplified filter to view

2019-12-04 Thread GitBox
asereda-gs commented on issue #1631: [CALCITE-3569] IndexOutOfBoundsException when pushing simplified filter to view URL: https://github.com/apache/calcite/pull/1631#issuecomment-561903860 Thanks for PR @chunweilei We'll be releasing 1.22 soon

[calcite] branch master updated (a0931b7 -> 11d7916)

2019-12-04 Thread sereda
This is an automated email from the ASF dual-hosted git repository. sereda pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from a0931b7 [CALCITE-3285] EnumerableMergeJoin should support non-equi join condions (Jin Xing) add 11d7916

[GitHub] [calcite] asereda-gs commented on issue #1596: Add guidance of how to run gradle command(e.g. check) in a

2019-12-04 Thread GitBox
asereda-gs commented on issue #1596: Add guidance of how to run gradle command(e.g. check) in a URL: https://github.com/apache/calcite/pull/1596#issuecomment-561911747 Pls squash commits and add your full name in parentheses `(FirstName LastName)`

[GitHub] [calcite] yanlin-Lynn commented on issue #1630: [CALCITE-3567] Unnest support Map wrapped with RecordType

2019-12-04 Thread GitBox
yanlin-Lynn commented on issue #1630: [CALCITE-3567] Unnest support Map wrapped with RecordType URL: https://github.com/apache/calcite/pull/1630#issuecomment-561929989 Thanks for review and merge. This is an automated

[GitHub] [calcite] yanlin-Lynn commented on issue #1478: [CALCITE-3378] AssertionError for checking RexNode implify

2019-12-04 Thread GitBox
yanlin-Lynn commented on issue #1478: [CALCITE-3378] AssertionError for checking RexNode implify URL: https://github.com/apache/calcite/pull/1478#issuecomment-561940557 Resolve conflicts and force push. This is an automated

[GitHub] [calcite] chunweilei commented on issue #1634: [CALCITE-3246] NullPointerException while deserializing udf operator

2019-12-04 Thread GitBox
chunweilei commented on issue #1634: [CALCITE-3246] NullPointerException while deserializing udf operator URL: https://github.com/apache/calcite/pull/1634#issuecomment-561960567 LGTM This is an automated message from the

[GitHub] [calcite] asereda-gs commented on issue #1626: [CALCITE-3561] Support using unnest in Interpreter

2019-12-04 Thread GitBox
asereda-gs commented on issue #1626: [CALCITE-3561] Support using unnest in Interpreter URL: https://github.com/apache/calcite/pull/1626#issuecomment-561963699 Thank you for PR, @yanlin-Lynn ! This is an automated message

[GitHub] [calcite] asereda-gs merged pull request #1626: [CALCITE-3561] Support using unnest in Interpreter

2019-12-04 Thread GitBox
asereda-gs merged pull request #1626: [CALCITE-3561] Support using unnest in Interpreter URL: https://github.com/apache/calcite/pull/1626 This is an automated message from the Apache Git Service. To respond to the message,

[calcite] branch master updated (0aaf4f6 -> f1e51e6)

2019-12-04 Thread sereda
This is an automated email from the ASF dual-hosted git repository. sereda pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 0aaf4f6 [CALCITE-3566] EnumerableIntersect and EnumerableMinus convert to Logical (xzh_dz) add f1e51e6

[GitHub] [calcite] asereda-gs merged pull request #1630: [CALCITE-3567] Unnest support Map wrapped with RecordType

2019-12-04 Thread GitBox
asereda-gs merged pull request #1630: [CALCITE-3567] Unnest support Map wrapped with RecordType URL: https://github.com/apache/calcite/pull/1630 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] danny0405 commented on issue #1521: [CALCITE-3429] AssertionError for user-defined table function with map argument

2019-12-04 Thread GitBox
danny0405 commented on issue #1521: [CALCITE-3429] AssertionError for user-defined table function with map argument URL: https://github.com/apache/calcite/pull/1521#issuecomment-561944567 Sorry for the delay, reviewing now ~

[GitHub] [calcite] hsyuan commented on issue #1573: [CALCITE-3496] Hive dialect and MS SQL dialect support with cube and with rollup

2019-12-04 Thread GitBox
hsyuan commented on issue #1573: [CALCITE-3496] Hive dialect and MS SQL dialect support with cube and with rollup URL: https://github.com/apache/calcite/pull/1573#issuecomment-561966309 Yeah, I commented in the JIRA: https://issues.apache.org/jira/browse/CALCITE-3496

[GitHub] [calcite] xy2953396112 commented on issue #1573: [CALCITE-3496] Hive dialect and MS SQL dialect support with cube and with rollup

2019-12-04 Thread GitBox
xy2953396112 commented on issue #1573: [CALCITE-3496] Hive dialect and MS SQL dialect support with cube and with rollup URL: https://github.com/apache/calcite/pull/1573#issuecomment-561966045 @hsyuan is there some problems in this pr?

[GitHub] [calcite] asereda-gs commented on issue #1627: [CALCITE-3566] Support EnumerableIntersect and EnumerableMinus convert to Logical

2019-12-04 Thread GitBox
asereda-gs commented on issue #1627: [CALCITE-3566] Support EnumerableIntersect and EnumerableMinus convert to Logical URL: https://github.com/apache/calcite/pull/1627#issuecomment-561910793 Thanks, @xy2953396112, for this PR!

[GitHub] [calcite] yanlin-Lynn commented on a change in pull request #1626: [CALCITE-3561] Support using unnest in Interpreter

2019-12-04 Thread GitBox
yanlin-Lynn commented on a change in pull request #1626: [CALCITE-3561] Support using unnest in Interpreter URL: https://github.com/apache/calcite/pull/1626#discussion_r354078727 ## File path: core/src/main/java/org/apache/calcite/interpreter/UncollectNode.java ## @@ -0,0

[GitHub] [calcite] asereda-gs commented on a change in pull request #1626: [CALCITE-3561] Support using unnest in Interpreter

2019-12-04 Thread GitBox
asereda-gs commented on a change in pull request #1626: [CALCITE-3561] Support using unnest in Interpreter URL: https://github.com/apache/calcite/pull/1626#discussion_r354093122 ## File path: core/src/main/java/org/apache/calcite/interpreter/UncollectNode.java ## @@ -0,0

[GitHub] [calcite] jinxing64 commented on issue #1635: [CALCITE-3570] Support MutableSnapshot in MutableRel

2019-12-04 Thread GitBox
jinxing64 commented on issue #1635: [CALCITE-3570] Support MutableSnapshot in MutableRel URL: https://github.com/apache/calcite/pull/1635#issuecomment-561975389 Can you explain in what scenario `MutableSnapshot` is needed ?

[GitHub] [calcite] asereda-gs commented on a change in pull request #1626: [CALCITE-3561] Support using unnest in Interpreter

2019-12-04 Thread GitBox
asereda-gs commented on a change in pull request #1626: [CALCITE-3561] Support using unnest in Interpreter URL: https://github.com/apache/calcite/pull/1626#discussion_r354053829 ## File path: core/src/main/java/org/apache/calcite/interpreter/UncollectNode.java ## @@ -0,0

[calcite] branch master updated (11d7916 -> 560d895)

2019-12-04 Thread sereda
This is an automated email from the ASF dual-hosted git repository. sereda pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 11d7916 [CALCITE-3569] IndexOutOfBoundsException when pushing simplified filter to view add 560d895

[GitHub] [calcite] asereda-gs commented on issue #1630: [CALCITE-3567] Unnest support Map wrapped with RecordType

2019-12-04 Thread GitBox
asereda-gs commented on issue #1630: [CALCITE-3567] Unnest support Map wrapped with RecordType URL: https://github.com/apache/calcite/pull/1630#issuecomment-561909276 Thanks for PR @yanlin-Lynn ! This is an automated message

  1   2   >