rubenada opened a new pull request #2037:
URL: https://github.com/apache/calcite/pull/2037
[[CALCITE-3834](https://issues.apache.org/jira/browse/CALCITE-3834)] Support
AntiJoin in EnumerableMergeJoin
This is an automated
hsyuan commented on pull request #2037:
URL: https://github.com/apache/calcite/pull/2037#issuecomment-646665024
@rubenada Thanks for the clarification. That make much sense now.
This is an automated message from the Apache
michaelmior commented on pull request #2009:
URL: https://github.com/apache/calcite/pull/2009#issuecomment-646689693
Forgive me for being rather pedantic. This looks great. Just a few small
suggested changes.
This is an
michaelmior commented on a change in pull request #2009:
URL: https://github.com/apache/calcite/pull/2009#discussion_r442896178
##
File path: site/_docs/howto.md
##
@@ -474,6 +474,32 @@ $ ./src/main/scripts/generate-protobuf.sh
The following sections are of interest to
michaelmior commented on a change in pull request #2009:
URL: https://github.com/apache/calcite/pull/2009#discussion_r442895916
##
File path: site/_docs/howto.md
##
@@ -474,6 +474,32 @@ $ ./src/main/scripts/generate-protobuf.sh
The following sections are of interest to
rubenada commented on pull request #2035:
URL: https://github.com/apache/calcite/pull/2035#issuecomment-646697215
Sure, @hsyuan , I'll take a look
This is an automated message from the Apache Git Service.
To respond to the
michaelmior commented on a change in pull request #2021:
URL: https://github.com/apache/calcite/pull/2021#discussion_r442893261
##
File path: core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java
##
@@ -271,7 +271,9 @@ public RelDataType toType(RelDataTypeFactory
vlsi commented on pull request #1929:
URL: https://github.com/apache/calcite/pull/1929#issuecomment-646750826
You are right, there's not enough annotations.
The idea was that once all the annotations are there, we could enforce the
check for all the commits.
Feel free to pick it
michaelmior commented on a change in pull request #2031:
URL: https://github.com/apache/calcite/pull/2031#discussion_r442889550
##
File path:
core/src/test/java/org/apache/calcite/test/enumerable/EnumerableUncollectTest.java
##
@@ -0,0 +1,189 @@
+/*
+ * Licensed to the Apache
michaelmior commented on pull request #1929:
URL: https://github.com/apache/calcite/pull/1929#issuecomment-646701923
Looks like this is currently failing but I assume that's expected?
(Presumably because of missing annotations.)
rubenada edited a comment on pull request #2031:
URL: https://github.com/apache/calcite/pull/2031#issuecomment-646728681
Another advantage for `EnumerableUncollectTest` is that I could add a test,
that is currently disabled due to another bug `@Disabled("CALCITE-4064")`. I'm
not sure we
rubenada commented on pull request #2037:
URL: https://github.com/apache/calcite/pull/2037#issuecomment-646651556
@hsyuan the behavior of our JoinType ANTI is not like a NOT IN, but a NOT
EXISTS.
Some time ago, I added a test case for this precise scenario in
michaelmior commented on pull request #2031:
URL: https://github.com/apache/calcite/pull/2031#issuecomment-646684247
What is the difference between `EnumerableUncollectTest` and the new tests
in `struct.iq`? They seem to cover the same cases.
michaelmior edited a comment on pull request #1905:
URL: https://github.com/apache/calcite/pull/1905#issuecomment-646711673
This is definitely a bug and I'm not sure how I let this slip in. I think
this change is simple enough that I'll take it without a test although if we
run into any
michaelmior commented on pull request #2031:
URL: https://github.com/apache/calcite/pull/2031#issuecomment-646726162
I would say `struct.iq` is much simpler so I would normally vote for keeping
that although it doesn't capture the order invariance property you mentioned.
rubenada commented on pull request #2031:
URL: https://github.com/apache/calcite/pull/2031#issuecomment-646728681
Another advantage for `EnumerableUncollectTest` is that I could add a test,
that is currently disabled due to another bug `@Disabled("CALCITE-3660")`. I'm
not sure we can do
michaelmior commented on pull request #2018:
URL: https://github.com/apache/calcite/pull/2018#issuecomment-646687533
@hsyuan Can you have a look at the test failures? They seem to be related.
This is an automated message
rubenada commented on a change in pull request #2031:
URL: https://github.com/apache/calcite/pull/2031#discussion_r442893520
##
File path:
core/src/test/java/org/apache/calcite/test/enumerable/EnumerableUncollectTest.java
##
@@ -0,0 +1,189 @@
+/*
+ * Licensed to the Apache
hsyuan commented on pull request #2018:
URL: https://github.com/apache/calcite/pull/2018#issuecomment-646688140
Yes, thanks for reminding. Will take a look.
This is an automated message from the Apache Git Service.
To
michaelmior commented on a change in pull request #2009:
URL: https://github.com/apache/calcite/pull/2009#discussion_r442894745
##
File path: site/_docs/howto.md
##
@@ -474,6 +474,32 @@ $ ./src/main/scripts/generate-protobuf.sh
The following sections are of interest to
michaelmior commented on a change in pull request #2009:
URL: https://github.com/apache/calcite/pull/2009#discussion_r442895164
##
File path: site/_docs/howto.md
##
@@ -474,6 +474,32 @@ $ ./src/main/scripts/generate-protobuf.sh
The following sections are of interest to
michaelmior commented on a change in pull request #2009:
URL: https://github.com/apache/calcite/pull/2009#discussion_r442894462
##
File path: site/_docs/howto.md
##
@@ -474,6 +474,32 @@ $ ./src/main/scripts/generate-protobuf.sh
The following sections are of interest to
michaelmior commented on a change in pull request #2009:
URL: https://github.com/apache/calcite/pull/2009#discussion_r442895483
##
File path: site/_docs/howto.md
##
@@ -474,6 +474,32 @@ $ ./src/main/scripts/generate-protobuf.sh
The following sections are of interest to
hsyuan commented on pull request #2035:
URL: https://github.com/apache/calcite/pull/2035#issuecomment-646695520
@rubenada Can you help review this pull request?
This is an automated message from the Apache Git Service.
To
This is an automated email from the ASF dual-hosted git repository.
mmior pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/master by this push:
new 3e98d75 [CALCITE-3907] Use username and
michaelmior commented on pull request #1905:
URL: https://github.com/apache/calcite/pull/1905#issuecomment-646711673
This is definitely a bug and I'm not sure how I let this slip in. I think
this change is simple enough that I'll take it without a test although if we
run into any
michaelmior merged pull request #1905:
URL: https://github.com/apache/calcite/pull/1905
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
michaelmior commented on a change in pull request #2009:
URL: https://github.com/apache/calcite/pull/2009#discussion_r442894462
##
File path: site/_docs/howto.md
##
@@ -474,6 +474,32 @@ $ ./src/main/scripts/generate-protobuf.sh
The following sections are of interest to
rubenada commented on pull request #2031:
URL: https://github.com/apache/calcite/pull/2031#issuecomment-646687829
@michaelmior you are right, they are the same tests in two different places.
We could remove one of them (I guess struct.iq?).
zabetak opened a new pull request #2038:
URL: https://github.com/apache/calcite/pull/2038
The name of the table implies that all columns are nullable so to avoid
confusion 'ENAME' is also made nullable.
This is an automated
danny0405 commented on pull request #2030:
URL: https://github.com/apache/calcite/pull/2030#issuecomment-646919605
I don't think there is any confusion.
This is an automated message from the Apache Git Service.
To respond to
danny0405 commented on a change in pull request #2029:
URL: https://github.com/apache/calcite/pull/2029#discussion_r443090826
##
File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java
##
@@ -1038,19 +1043,40 @@ public static SqlDataTypeSpec
amaliujia commented on pull request #2035:
URL: https://github.com/apache/calcite/pull/2035#issuecomment-646846325
Thank you!
This is an automated message from the Apache Git Service.
To respond to the message, please log on
michaelmior commented on pull request #1929:
URL: https://github.com/apache/calcite/pull/1929#issuecomment-646812477
@vlsi Unfortunately I'm in the same situation bandwidth-wise but I'll keep
that in mind.
This is an
michaelmior commented on pull request #2031:
URL: https://github.com/apache/calcite/pull/2031#issuecomment-646813897
Given that you've already gone to the effort to write
`EnumerableUncollectTest`, I'd say keep that one and remove `struct.iq`. Thanks!
Aaron commented on pull request #2030:
URL: https://github.com/apache/calcite/pull/2030#issuecomment-646487303
> > The code looks really redundant, cuz RelDistribution#getKeys is
annotated as nonnull, and must return "List".
> > Or do I miss something?
>
> It is nonnull, but
Aaron edited a comment on pull request #2030:
URL: https://github.com/apache/calcite/pull/2030#issuecomment-646487303
> > The code looks really redundant, cuz RelDistribution#getKeys is
annotated as nonnull, and must return "List".
> > Or do I miss something?
>
> It is
Aaron commented on a change in pull request #2029:
URL: https://github.com/apache/calcite/pull/2029#discussion_r442679115
##
File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java
##
@@ -117,6 +131,57 @@
Aaron edited a comment on pull request #2030:
URL: https://github.com/apache/calcite/pull/2030#issuecomment-646487303
> > The code looks really redundant, cuz RelDistribution#getKeys is
annotated as nonnull, and must return "List".
> > Or do I miss something?
>
> It is
Aaron commented on a change in pull request #2029:
URL: https://github.com/apache/calcite/pull/2029#discussion_r442679115
##
File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java
##
@@ -117,6 +131,57 @@
40 matches
Mail list logo