[GitHub] [calcite] danny0405 commented on a change in pull request #2123: Support for Elasticsearch basic authentication

danny0405 commented on a change in pull request #2123: URL: https://github.com/apache/calcite/pull/2123#discussion_r478834432 ## File path: elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchSchemaFactory.java ## @@ -100,14 +106,27 @@ public

[GitHub] [calcite] danny0405 commented on a change in pull request #2123: Support for Elasticsearch basic authentication

danny0405 commented on a change in pull request #2123: URL: https://github.com/apache/calcite/pull/2123#discussion_r478834587 ## File path: elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchSchemaFactory.java ## @@ -100,14 +106,27 @@ public

[GitHub] [calcite] fageiguanbing opened a new pull request #2123: Support for Elasticsearch basic authentication

fageiguanbing opened a new pull request #2123: URL: https://github.com/apache/calcite/pull/2123 [JIRA](https://issues.apache.org/jira/browse/CALCITE-4180#) I found that there isn't any implementation of Elascticsearch authentication. So I fix it. Please review my code. I get

[GitHub] [calcite] danny0405 commented on a change in pull request #2121: [CALCITE-4192]Relmdcolumnorigins should obtain the true column index of the group by column of the aggregation operator inste

danny0405 commented on a change in pull request #2121: URL: https://github.com/apache/calcite/pull/2121#discussion_r478238613 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ## @@ -6764,4 +6767,24 @@ protected MyProjectRule(Config config) {

[GitHub] [calcite] cuglifangzheng commented on a change in pull request #2121: [CALCITE-4192]fix aggregate column origins searching by RelMdColumnOrigins

cuglifangzheng commented on a change in pull request #2121: URL: https://github.com/apache/calcite/pull/2121#discussion_r478162865 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdColumnOrigins.java ## @@ -65,8 +65,8 @@ private RelMdColumnOrigins() {}

[calcite-avatica] branch master updated: [CALCITE-4196] Consume all data from client before replying with HTTP/401

This is an automated email from the ASF dual-hosted git repository. elserj pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git The following commit(s) were added to refs/heads/master by this push: new f983742 [CALCITE-4196] Consume all

[GitHub] [calcite-avatica] joshelser closed pull request #127: CALCITE-4196 Consume all data from client before replying with HTTP…

joshelser closed pull request #127: URL: https://github.com/apache/calcite-avatica/pull/127 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite-avatica] joshelser commented on a change in pull request #127: CALCITE-4196 Consume all data from client before replying with HTTP…

joshelser commented on a change in pull request #127: URL: https://github.com/apache/calcite-avatica/pull/127#discussion_r478593632 ## File path: .gitignore ## @@ -22,3 +22,4 @@ settings.xml /target/ /*/target/ /shaded/*/target/ +bin Review comment: Hrm, I did not.