liuyongvs opened a new pull request, #3194:
URL: https://github.com/apache/calcite/pull/3194
MAP_KEYS - Returns an unordered array containing the keys of the map. If the
map itself is null, the function will return null.
MAP_VALUES - Returns an unordered array containing the values
liuyongvs commented on PR #3194:
URL: https://github.com/apache/calcite/pull/3194#issuecomment-1541451693
hi @JiajunBernoulli could you also help review it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
sonarcloud[bot] commented on PR #3194:
URL: https://github.com/apache/calcite/pull/3194#issuecomment-1541473544
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #3189:
URL: https://github.com/apache/calcite/pull/3189#issuecomment-1542307080
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #3194:
URL: https://github.com/apache/calcite/pull/3194#issuecomment-1541798449
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
liuyongvs commented on code in PR #3194:
URL: https://github.com/apache/calcite/pull/3194#discussion_r1189754135
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -3797,6 +3798,16 @@ public static List distinct(List list) {
return new
zoudan commented on code in PR #3194:
URL: https://github.com/apache/calcite/pull/3194#discussion_r1189565277
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -3797,6 +3798,16 @@ public static List distinct(List list) {
return new
stoty commented on PR #217:
URL: https://github.com/apache/calcite-avatica/pull/217#issuecomment-1542101644
One more thing, @vaijosh .
Please change the commit message to match the Avatica convention.
i.e. use square brackets instead of colon.
--
This is an automated message from
sonarcloud[bot] commented on PR #3194:
URL: https://github.com/apache/calcite/pull/3194#issuecomment-1541883937
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
libenchao commented on code in PR #3191:
URL: https://github.com/apache/calcite/pull/3191#discussion_r1189742157
##
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##
@@ -4021,19 +4021,30 @@ private void validateModality(SqlNode query) {
liuyongvs commented on code in PR #3194:
URL: https://github.com/apache/calcite/pull/3194#discussion_r1189758110
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -3797,6 +3798,16 @@ public static List distinct(List list) {
return new
liuyongvs commented on code in PR #3194:
URL: https://github.com/apache/calcite/pull/3194#discussion_r1189605267
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -3797,6 +3798,16 @@ public static List distinct(List list) {
return new
zoudan commented on code in PR #3194:
URL: https://github.com/apache/calcite/pull/3194#discussion_r1189631187
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -3797,6 +3798,16 @@ public static List distinct(List list) {
return new
liuyongvs commented on code in PR #3194:
URL: https://github.com/apache/calcite/pull/3194#discussion_r1189754135
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -3797,6 +3798,16 @@ public static List distinct(List list) {
return new
sonarcloud[bot] commented on PR #3189:
URL: https://github.com/apache/calcite/pull/3189#issuecomment-1542059036
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
libenchao commented on code in PR #3191:
URL: https://github.com/apache/calcite/pull/3191#discussion_r1189744018
##
core/src/test/java/org/apache/calcite/test/JdbcAdapterTest.java:
##
@@ -135,6 +135,14 @@ class JdbcAdapterTest {
+ "WHERE \"product_id\" = 1");
}
libenchao commented on code in PR #3193:
URL: https://github.com/apache/calcite/pull/3193#discussion_r1189755471
##
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##
@@ -6823,6 +6824,65 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule
rule) {
tanclary commented on code in PR #3194:
URL: https://github.com/apache/calcite/pull/3194#discussion_r1190144100
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -5361,6 +5361,28 @@ private static void checkIf(SqlOperatorFixture f) {
HanumathRao commented on code in PR #3193:
URL: https://github.com/apache/calcite/pull/3193#discussion_r1190174369
##
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##
@@ -6823,6 +6824,65 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule
rule) {
sonarcloud[bot] commented on PR #3189:
URL: https://github.com/apache/calcite/pull/3189#issuecomment-1542959192
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
liuyongvs commented on code in PR #3194:
URL: https://github.com/apache/calcite/pull/3194#discussion_r1190558694
##
site/_docs/reference.md:
##
@@ -2723,6 +2723,8 @@ BigQuery's type system uses confusingly different names
for types and functions:
| m | TO_BASE64(string)
sonarcloud[bot] commented on PR #3194:
URL: https://github.com/apache/calcite/pull/3194#issuecomment-1543204521
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #3196:
URL: https://github.com/apache/calcite/pull/3196#issuecomment-1543273226
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
herunkang2018 opened a new pull request, #3196:
URL: https://github.com/apache/calcite/pull/3196
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
liuyongvs commented on code in PR #3194:
URL: https://github.com/apache/calcite/pull/3194#discussion_r1190558850
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -5361,6 +5361,28 @@ private static void checkIf(SqlOperatorFixture f) {
allai5 closed pull request #3195: Alice/support join using compound identifiers
URL: https://github.com/apache/calcite/pull/3195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
allai5 opened a new pull request, #3195:
URL: https://github.com/apache/calcite/pull/3195
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
julianhyde commented on code in PR #3179:
URL: https://github.com/apache/calcite/pull/3179#discussion_r1190355718
##
core/src/main/java/org/apache/calcite/prepare/CalcitePrepareImpl.java:
##
@@ -837,8 +837,16 @@ private static ColumnMetaData.AvaticaType
julianhyde commented on code in PR #3179:
URL: https://github.com/apache/calcite/pull/3179#discussion_r1190355718
##
core/src/main/java/org/apache/calcite/prepare/CalcitePrepareImpl.java:
##
@@ -837,8 +837,16 @@ private static ColumnMetaData.AvaticaType
This is an automated email from the ASF dual-hosted git repository.
jhyde pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git
The following commit(s) were added to refs/heads/main by this push:
new 05e07c151 [CALCITE-5678] Validate date,
julianhyde commented on code in PR #3194:
URL: https://github.com/apache/calcite/pull/3194#discussion_r1190352269
##
site/_docs/reference.md:
##
@@ -2723,6 +2723,8 @@ BigQuery's type system uses confusingly different names
for types and functions:
| m | TO_BASE64(string)
julianhyde commented on code in PR #3179:
URL: https://github.com/apache/calcite/pull/3179#discussion_r1190359548
##
core/src/test/java/org/apache/calcite/test/JdbcFrontLinqBackTest.java:
##
@@ -343,12 +356,13 @@ private CalciteAssert.AssertThat mutable(
julianhyde commented on code in PR #3179:
URL: https://github.com/apache/calcite/pull/3179#discussion_r1190362519
##
core/src/test/java/org/apache/calcite/test/JdbcFrontLinqBackTest.java:
##
@@ -343,12 +356,13 @@ private CalciteAssert.AssertThat mutable(
julianhyde closed pull request #218: CALCITE-5678 Validate incorrect datetime
string representation
URL: https://github.com/apache/calcite-avatica/pull/218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
34 matches
Mail list logo