[GitHub] [calcite] JiajunBernoulli commented on pull request #3194: [CALCITE-5695] Add MAP_KEYS, MAP_VALUES function (enabled in Spark li…

2023-05-12 Thread via GitHub
JiajunBernoulli commented on PR #3194: URL: https://github.com/apache/calcite/pull/3194#issuecomment-1546509814 I left some comments for the PR. And we should discuss 'unordered array' in JIRA. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3194: [CALCITE-5695] Add MAP_KEYS, MAP_VALUES function (enabled in Spark li…

2023-05-12 Thread via GitHub
JiajunBernoulli commented on code in PR #3194: URL: https://github.com/apache/calcite/pull/3194#discussion_r1192907286 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -3797,6 +3798,16 @@ public static List distinct(List list) { return new

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3194: [CALCITE-5695] Add MAP_KEYS, MAP_VALUES function (enabled in Spark li…

2023-05-12 Thread via GitHub
JiajunBernoulli commented on code in PR #3194: URL: https://github.com/apache/calcite/pull/3194#discussion_r1192904987 ## site/_docs/reference.md: ## @@ -2723,6 +2723,8 @@ BigQuery's type system uses confusingly different names for types and functions: | m | TO_BASE64(string)

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3194: [CALCITE-5695] Add MAP_KEYS, MAP_VALUES function (enabled in Spark li…

2023-05-12 Thread via GitHub
JiajunBernoulli commented on code in PR #3194: URL: https://github.com/apache/calcite/pull/3194#discussion_r1192906717 ## core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java: ## @@ -536,6 +536,26 @@ public static SqlCall stripSeparator(SqlCall call) { public

[GitHub] [calcite] JiajunBernoulli commented on pull request #3197: CALCITE-5699 Posix regex expressions are partially incorrectly processed

2023-05-12 Thread via GitHub
JiajunBernoulli commented on PR #3197: URL: https://github.com/apache/calcite/pull/3197#issuecomment-1546517957 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [calcite] JiajunBernoulli commented on pull request #3198: [CALCITE-5700] Add ARRAY_SIZE, ARRAY_REPEAT function (enabled in Spar…

2023-05-12 Thread via GitHub
JiajunBernoulli commented on PR #3198: URL: https://github.com/apache/calcite/pull/3198#issuecomment-1546510148 CI failed, please fix them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3197: CALCITE-5699 Posix regex expressions are partially incorrectly processed

2023-05-12 Thread via GitHub
sonarcloud[bot] commented on PR #3197: URL: https://github.com/apache/calcite/pull/3197#issuecomment-1545299596 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3197: CALCITE-5699 Posix regex expressions are partially incorrectly processed

2023-05-12 Thread via GitHub
sonarcloud[bot] commented on PR #3197: URL: https://github.com/apache/calcite/pull/3197#issuecomment-1545319852 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] liuyongvs commented on pull request #3198: [CALCITE-5700] Add ARRAY_SIZE, ARRAY_REPEAT function (enabled in Spar…

2023-05-12 Thread via GitHub
liuyongvs commented on PR #3198: URL: https://github.com/apache/calcite/pull/3198#issuecomment-1545280773 hi @JiajunBernoulli could you also help review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite] liuyongvs commented on pull request #3198: [CALCITE-5700] Add ARRAY_SIZE, ARRAY_REPEAT function (enabled in Spar…

2023-05-12 Thread via GitHub
liuyongvs commented on PR #3198: URL: https://github.com/apache/calcite/pull/3198#issuecomment-1545279946 comment: the NullPolicy should None, because the second arg is null, the result return null ``` defineMethod(ARRAY_REPEAT, BuiltInMethod.ARRAY_REPEAT.method,

[GitHub] [calcite] liuyongvs commented on a diff in pull request #3194: [CALCITE-5695] Add MAP_KEYS, MAP_VALUES function (enabled in Spark li…

2023-05-12 Thread via GitHub
liuyongvs commented on code in PR #3194: URL: https://github.com/apache/calcite/pull/3194#discussion_r1189754135 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -3797,6 +3798,16 @@ public static List distinct(List list) { return new

[GitHub] [calcite-avatica] stoty commented on pull request #217: [CALCITE-5581] Implemented a basic client side load balancing

2023-05-12 Thread via GitHub
stoty commented on PR #217: URL: https://github.com/apache/calcite-avatica/pull/217#issuecomment-1545309881 The commit message doesn't match the JIRA description please use the JIRA description verbatim. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite-avatica] vaijosh commented on pull request #217: [CALCITE-5581] Implement Basic client side load balancing in Avatica Driver

2023-05-12 Thread via GitHub
vaijosh commented on PR #217: URL: https://github.com/apache/calcite-avatica/pull/217#issuecomment-1545407706 > Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [calcite] liuyongvs opened a new pull request, #3198: [CALCITE-5700] Add ARRAY_SIZE, ARRAY_REPEAT function (enabled in Spar…

2023-05-12 Thread via GitHub
liuyongvs opened a new pull request, #3198: URL: https://github.com/apache/calcite/pull/3198 ARRAY_SIZE - Returns the size of an array. ARRAY_REPEAT - Returns the array containing element count times. For more details

[GitHub] [calcite] zstan opened a new pull request, #3197: CALCITE-5699 Posix regex expressions are partially incorrectly processed

2023-05-12 Thread via GitHub
zstan opened a new pull request, #3197: URL: https://github.com/apache/calcite/pull/3197 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [calcite] zstan opened a new pull request, #3199: CALCITE-5698 EXTRACT from INTERVAL partially does not follow the SQL standard

2023-05-12 Thread via GitHub
zstan opened a new pull request, #3199: URL: https://github.com/apache/calcite/pull/3199 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [calcite] herunkang2018 commented on pull request #3196: [CALCITE-5691] IN sub-query inside FILTER clause throws IndexOutOfBoundsException

2023-05-12 Thread via GitHub
herunkang2018 commented on PR #3196: URL: https://github.com/apache/calcite/pull/3196#issuecomment-1545582736 @julianhyde @libenchao Would you like to review this PR if you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] HanumathRao commented on a diff in pull request #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti…

2023-05-12 Thread via GitHub
HanumathRao commented on code in PR #3193: URL: https://github.com/apache/calcite/pull/3193#discussion_r1192598969 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -6823,6 +6824,65 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule rule) {

[GitHub] [calcite] julianhyde commented on pull request #3194: [CALCITE-5695] Add MAP_KEYS, MAP_VALUES function (enabled in Spark li…

2023-05-12 Thread via GitHub
julianhyde commented on PR #3194: URL: https://github.com/apache/calcite/pull/3194#issuecomment-1546087007 @liuyongvs Can you respond to my comment in Jira? What is an 'unordered array'? -- This is an automated message from the Apache Git Service. To respond to the message, please log on