[GitHub] [calcite] rubenada opened a new pull request, #3403: [CALCITE-5967] UnsupportedOperationException while implementing a call that requires a special collator

2023-08-29 Thread via GitHub
rubenada opened a new pull request, #3403: URL: https://github.com/apache/calcite/pull/3403 Jira: CALCITE-5967 Rollback minor change introduced in CALCITE-5914 which caused a regression -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3403: [CALCITE-5967] UnsupportedOperationException while implementing a call that requires a special collator

2023-08-29 Thread via GitHub
sonarcloud[bot] commented on PR #3403: URL: https://github.com/apache/calcite/pull/3403#issuecomment-1697827154 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] LakeShen commented on pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

2023-08-29 Thread via GitHub
LakeShen commented on PR #3367: URL: https://github.com/apache/calcite/pull/3367#issuecomment-1697757736 Hi @tanclary @NobiGo ,I already according to the review recommends modifying code, if you have time, please help me to review again, thank you very much:) -- This is an automated

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

2023-08-29 Thread via GitHub
sonarcloud[bot] commented on PR #3367: URL: https://github.com/apache/calcite/pull/3367#issuecomment-1697761477 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] julianhyde commented on a diff in pull request #3375: [CALCITE-5583] JDBC adapter does not generate 'SELECT *' when duplicate field names

2023-08-29 Thread via GitHub
julianhyde commented on code in PR #3375: URL: https://github.com/apache/calcite/pull/3375#discussion_r1309108471 ## core/src/main/java/org/apache/calcite/util/Util.java: ## @@ -2166,6 +2167,24 @@ public static boolean isDistinct(List list) { return firstDuplicate(list) <

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3375: [CALCITE-5583] JDBC adapter does not generate 'SELECT *' when duplicate field names

2023-08-29 Thread via GitHub
sonarcloud[bot] commented on PR #3375: URL: https://github.com/apache/calcite/pull/3375#issuecomment-1698397233 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[calcite] branch main updated (2a96512c35 -> 2bf1e7b2e8)

2023-08-29 Thread libenchao
This is an automated email from the ASF dual-hosted git repository. libenchao pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git from 2a96512c35 [CALCITE-5914] Cache compiled regular expressions in SQL function runtime add 2bf1e7b2e8

[GitHub] [calcite] libenchao merged pull request #3402: [CALCITE-5966] Upgrade commons-dbcp2 to 2.9.0

2023-08-29 Thread via GitHub
libenchao merged PR #3402: URL: https://github.com/apache/calcite/pull/3402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] guestli commented on a diff in pull request #3375: [CALCITE-5583] JDBC adapter does not generate 'SELECT *' when duplicate field names

2023-08-29 Thread via GitHub
guestli commented on code in PR #3375: URL: https://github.com/apache/calcite/pull/3375#discussion_r1309553303 ## core/src/main/java/org/apache/calcite/util/Util.java: ## @@ -2166,6 +2167,24 @@ public static boolean isDistinct(List list) { return firstDuplicate(list) < 0;

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3375: [CALCITE-5583] JDBC adapter does not generate 'SELECT *' when duplicate field names

2023-08-29 Thread via GitHub
sonarcloud[bot] commented on PR #3375: URL: https://github.com/apache/calcite/pull/3375#issuecomment-1698453019 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3399: [CALCITE-5962] Allow Spark-style syntax LEFT ANTI JOIN in Babel parser

2023-08-29 Thread via GitHub
sonarcloud[bot] commented on PR #3399: URL: https://github.com/apache/calcite/pull/3399#issuecomment-1696996721 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3389: [CALCITE-5935] Add CODE_POINTS_TO_BYTES function (enabled in BigQuery…

2023-08-29 Thread via GitHub
sonarcloud[bot] commented on PR #3389: URL: https://github.com/apache/calcite/pull/3389#issuecomment-1697364024 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] macroguo-ghy commented on a diff in pull request #3389: [CALCITE-5935] Add CODE_POINTS_TO_BYTES function (enabled in BigQuery…

2023-08-29 Thread via GitHub
macroguo-ghy commented on code in PR #3389: URL: https://github.com/apache/calcite/pull/3389#discussion_r1308734521 ## core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java: ## @@ -510,6 +510,38 @@ public static SqlOperandTypeChecker variadic( } };

[GitHub] [calcite] thomasrebele opened a new pull request, #3401: [CALCITE-5965] Avoid unnecessary String concatenations in the RexFieldAccess constructor to improve the performance

2023-08-29 Thread via GitHub
thomasrebele opened a new pull request, #3401: URL: https://github.com/apache/calcite/pull/3401 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3401: [CALCITE-5965] Avoid unnecessary String concatenations in the RexFieldAccess constructor to improve the performance

2023-08-29 Thread via GitHub
sonarcloud[bot] commented on PR #3401: URL: https://github.com/apache/calcite/pull/3401#issuecomment-1697489098 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3395: [CALCITE-5948] Explicit casting should be made if the type of an element in ARRAY/MAP not equals with the derived component type

2023-08-29 Thread via GitHub
sonarcloud[bot] commented on PR #3395: URL: https://github.com/apache/calcite/pull/3395#issuecomment-1697063907 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] herunkang2018 commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

2023-08-29 Thread via GitHub
herunkang2018 commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1308961936 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -2699,6 +2699,35 @@ private void

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3402: [CALCITE-5966] Upgrade commons-dbcp2 to 2.9.0

2023-08-29 Thread via GitHub
sonarcloud[bot] commented on PR #3402: URL: https://github.com/apache/calcite/pull/3402#issuecomment-1697655950 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png