[GitHub] [calcite] sonarcloud[bot] commented on pull request #3396: [CALCITE-5940] Add the Rules to optimize Limit

2023-09-05 Thread via GitHub
sonarcloud[bot] commented on PR #3396: URL: https://github.com/apache/calcite/pull/3396#issuecomment-1706875705 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] LakeShen commented on pull request #3396: [CALCITE-5940] Add the Rules to optimize Limit

2023-09-05 Thread via GitHub
LakeShen commented on PR #3396: URL: https://github.com/apache/calcite/pull/3396#issuecomment-1706876930 Hi @NobiGo ,thank you for your review suggestions. I have modified according to the suggestions. If you have time, please help me review it again -- This is an automated message from

[GitHub] [calcite] tanclary commented on a diff in pull request #3391: [CALCITE-5933] Add SAFE_DIVIDE function (enabled in BigQuery library)

2023-09-05 Thread via GitHub
tanclary commented on code in PR #3391: URL: https://github.com/apache/calcite/pull/3391#discussion_r1316058041 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -7385,8 +7385,8 @@ private static void checkIf(SqlOperatorFixture f) { @Test void

[GitHub] [calcite] asolimando commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

2023-09-05 Thread via GitHub
asolimando commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1316122429 ## core/src/main/java/org/apache/calcite/rel/rules/MinusToDistinctRule.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [calcite] tanclary merged pull request #3302: [CALCITE-5821] Add FORMAT_NUMBER function (enabled in Hive and Spark library)

2023-09-05 Thread via GitHub
tanclary merged PR #3302: URL: https://github.com/apache/calcite/pull/3302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[calcite] branch main updated: [CALCITE-5821] Add FORMAT_NUMBER function (enabled in Hive and Spark library)

2023-09-05 Thread tanner
This is an automated email from the ASF dual-hosted git repository. tanner pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new aa5397bed4 [CALCITE-5821] Add FORMAT_NUMBER

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3391: [CALCITE-5933] Add SAFE_DIVIDE function (enabled in BigQuery library)

2023-09-05 Thread via GitHub
sonarcloud[bot] commented on PR #3391: URL: https://github.com/apache/calcite/pull/3391#issuecomment-1706882873 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] thomasrebele commented on pull request #3403: [CALCITE-5967] UnsupportedOperationException while implementing a call that requires a special collator

2023-09-05 Thread via GitHub
thomasrebele commented on PR #3403: URL: https://github.com/apache/calcite/pull/3403#issuecomment-1706639183 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [calcite] olivrlee commented on pull request #3391: [CALCITE-5933] Add SAFE_DIVIDE function (enabled in BigQuery library)

2023-09-05 Thread via GitHub
olivrlee commented on PR #3391: URL: https://github.com/apache/calcite/pull/3391#issuecomment-1707479064 Commit ready! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [calcite] chucheng92 commented on pull request #3405: [CALCITE-5961] Type inference of ARRAY_COMPACT is incorrect

2023-09-05 Thread via GitHub
chucheng92 commented on PR #3405: URL: https://github.com/apache/calcite/pull/3405#issuecomment-1707549985 @NobiGo hi. xiong. thanks for reviewing. It seems that the commit history has increased a lot due to a force-push by Tanner. Do I need to rebase the main and then wait to see if

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3408: [CALCITE-5978] Add REGEXP_INSTR function (enabled in BigQuery library)

2023-09-05 Thread via GitHub
sonarcloud[bot] commented on PR #3408: URL: https://github.com/apache/calcite/pull/3408#issuecomment-1707463216 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[calcite] branch main updated (aa5397bed4 -> 4804912cdc)

2023-09-05 Thread tanner
This is an automated email from the ASF dual-hosted git repository. tanner pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git from aa5397bed4 [CALCITE-5821] Add FORMAT_NUMBER function (enabled in Hive and Spark library) new 526d63a237

[calcite] 01/02: [CALCITE-5933] Add SAFE_DIVIDE function (enabled in BigQuery library)

2023-09-05 Thread tanner
This is an automated email from the ASF dual-hosted git repository. tanner pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git commit 526d63a237f376bdba44f9f8ea50cafd14fc5d12 Author: Tanner Clary AuthorDate: Wed Aug 16 14:02:54 2023 -0700

[calcite] 02/02: Address Oliver's comments

2023-09-05 Thread tanner
This is an automated email from the ASF dual-hosted git repository. tanner pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git commit 4804912cdca3dd61a7fe03cb1ad5a5bd3f1e1c7e Author: Tanner Clary AuthorDate: Thu Aug 24 13:36:11 2023 -0700 Address

[GitHub] [calcite] tanclary merged pull request #3391: [CALCITE-5933] Add SAFE_DIVIDE function (enabled in BigQuery library)

2023-09-05 Thread via GitHub
tanclary merged PR #3391: URL: https://github.com/apache/calcite/pull/3391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] libenchao commented on a diff in pull request #3311: [CALCITE-5732] EnumerableHashJoin and EnumerableMergeJoin on composite key return rows matching condition 'null = null'

2023-09-05 Thread via GitHub
libenchao commented on code in PR #3311: URL: https://github.com/apache/calcite/pull/3311#discussion_r1316730290 ## linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java: ## @@ -4495,6 +4492,27 @@ private boolean advanceRight(TInner right, TKey rightKey) {

[GitHub] [calcite] olivrlee commented on a diff in pull request #3391: [CALCITE-5933] Add SAFE_DIVIDE function (enabled in BigQuery library)

2023-09-05 Thread via GitHub
olivrlee commented on code in PR #3391: URL: https://github.com/apache/calcite/pull/3391#discussion_r1316517662 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -7538,8 +7610,8 @@ private static void checkIf(SqlOperatorFixture f) { @Test void

[calcite] branch main updated (00db00161c -> b19f373b41)

2023-09-05 Thread tanner
This is an automated email from the ASF dual-hosted git repository. tanner pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git from 00db00161c [CALCITE-5709] Add TO_BASE32 and FROM_BASE32 functions (enabled in BigQuery library) add 7dd3ecd5a6

[calcite] 01/01: [CALCITE-5933] Add SAFE_DIVIDE function (enabled in BigQuery library)

2023-09-05 Thread tanner
This is an automated email from the ASF dual-hosted git repository. tanner pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git commit b19f373b41089077aaccd688db57a32901e19c3d Author: Tanner Clary AuthorDate: Wed Aug 16 14:02:54 2023 -0700

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3408: [CALCITE-5978] Add REGEXP_INSTR function (enabled in BigQuery library)

2023-09-05 Thread via GitHub
sonarcloud[bot] commented on PR #3408: URL: https://github.com/apache/calcite/pull/3408#issuecomment-1707454303 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] Anthrino opened a new pull request, #3408: [CALCITE-5978] Add REGEXP_INSTR function (enabled in BigQuery library)

2023-09-05 Thread via GitHub
Anthrino opened a new pull request, #3408: URL: https://github.com/apache/calcite/pull/3408 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [calcite] tanclary commented on a diff in pull request #3391: [CALCITE-5933] Add SAFE_DIVIDE function (enabled in BigQuery library)

2023-09-05 Thread via GitHub
tanclary commented on code in PR #3391: URL: https://github.com/apache/calcite/pull/3391#discussion_r1316550752 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -7538,8 +7610,8 @@ private static void checkIf(SqlOperatorFixture f) { @Test void

[GitHub] [calcite] olivrlee commented on a diff in pull request #3391: [CALCITE-5933] Add SAFE_DIVIDE function (enabled in BigQuery library)

2023-09-05 Thread via GitHub
olivrlee commented on code in PR #3391: URL: https://github.com/apache/calcite/pull/3391#discussion_r1316551091 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -7538,8 +7610,8 @@ private static void checkIf(SqlOperatorFixture f) { @Test void

[calcite] branch main updated (4804912cdc -> 00db00161c)

2023-09-05 Thread tanner
This is an automated email from the ASF dual-hosted git repository. tanner pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git discard 4804912cdc Address Oliver's comments discard 526d63a237 [CALCITE-5933] Add SAFE_DIVIDE function (enabled in BigQuery

[GitHub] [calcite] LakeShen commented on pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

2023-09-05 Thread via GitHub
LakeShen commented on PR #3367: URL: https://github.com/apache/calcite/pull/3367#issuecomment-1707512690 Hi @tanclary ,could you help me to review this pr again,if you have any suggestions, please tell me,If not, please help me to approve,thank you so much:) -- This is an automated

[calcite] branch site updated: [CALCITE-5933] Add SAFE_DIVIDE function (enabled in BigQuery library)

2023-09-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch site in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/site by this push: new b377a54598 [CALCITE-5933] Add SAFE_DIVIDE

[calcite-site] branch main updated: Website deployed from calcite@b19f373b41089077aaccd688db57a32901e19c3d

2023-09-05 Thread asf-ci-deploy
This is an automated email from the ASF dual-hosted git repository. asf-ci-deploy pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite-site.git The following commit(s) were added to refs/heads/main by this push: new e984d11f9 Website deployed from

[GitHub] [calcite] macroguo-ghy commented on pull request #3389: [CALCITE-5935] Add CODE_POINTS_TO_BYTES function (enabled in BigQuery…

2023-09-05 Thread via GitHub
macroguo-ghy commented on PR #3389: URL: https://github.com/apache/calcite/pull/3389#issuecomment-1707559374 > Hi, @tanclary would you like to merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3359: [CALCITE-5905] Documentation for CREATE TYPE is incorrect

2023-09-05 Thread via GitHub
sonarcloud[bot] commented on PR #3359: URL: https://github.com/apache/calcite/pull/3359#issuecomment-1707678079 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] kgyrtkirk merged pull request #3400: [CALCITE-5953] AggregateCaseToFilterRule may make inaccurate SUM transformations

2023-09-05 Thread via GitHub
kgyrtkirk merged PR #3400: URL: https://github.com/apache/calcite/pull/3400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[calcite] branch main updated: [CALCITE-5953] AggregateCaseToFilterRule may make inaccurate SUM transformations

2023-09-05 Thread kgyrtkirk
This is an automated email from the ASF dual-hosted git repository. kgyrtkirk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 05787a6793 [CALCITE-5953]

[GitHub] [calcite] rubenada commented on a diff in pull request #3311: [CALCITE-5732] EnumerableHashJoin and EnumerableMergeJoin on composite key return rows matching condition 'null = null'

2023-09-05 Thread via GitHub
rubenada commented on code in PR #3311: URL: https://github.com/apache/calcite/pull/3311#discussion_r1315141021 ## linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java: ## @@ -4495,6 +4492,27 @@ private boolean advanceRight(TInner right, TKey rightKey) {

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3311: [CALCITE-5732] EnumerableHashJoin and EnumerableMergeJoin on composite key return rows matching condition 'null = null'

2023-09-05 Thread via GitHub
sonarcloud[bot] commented on PR #3311: URL: https://github.com/apache/calcite/pull/3311#issuecomment-1706161843 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png