jcamachor commented on issue #1125: [CALCITE-2943] Materialized view rewriting
logic calls getApplicableM…
URL: https://github.com/apache/calcite/pull/1125#issuecomment-475425680
PR also changes the visibility of ```registerMaterializations``` so it can
be overridden.
jcamachor opened a new pull request #1125: [CALCITE-2943] Materialized view
rewriting logic calls getApplicableM…
URL: https://github.com/apache/calcite/pull/1125
…aterializations each time the rule is triggered
This is an
julianhyde commented on a change in pull request #1101: [CALCITE-2909] Optimize
Enumerable SemiJoin with lazy computation of innerLookup (WIP, blocked by
CALCITE-2937) (Ruben Quesada Lopez)
URL: https://github.com/apache/calcite/pull/1101#discussion_r267954959
##
File path:
julianhyde commented on issue #1124: [CALCITE-2942] Materialized view rewriting
logic instantiates RelMeta…
URL: https://github.com/apache/calcite/pull/1124#issuecomment-475393135
+1
This is an automated message from the
julianhyde commented on issue #1110: [CALCITE-2920] RelBuilder: new method to
create an antijoin (Ruben Quesada Lopez)
URL: https://github.com/apache/calcite/pull/1110#issuecomment-475392339
If the RelBuilder change is done, let's commit it and close the case.
I like the idea of an
rubenada edited a comment on issue #1110: [CALCITE-2920] RelBuilder: new method
to create an antijoin (Ruben Quesada Lopez)
URL: https://github.com/apache/calcite/pull/1110#issuecomment-475321766
Following the comment by @julianhyde in the Jira ticket, I think we could be
a bit more
rubenada commented on issue #1110: [CALCITE-2920] RelBuilder: new method to
create an antijoin (Ruben Quesada Lopez)
URL: https://github.com/apache/calcite/pull/1110#issuecomment-475321766
Following the comment by @julianhyde in the Jira ticket, I think we could be
a bit more ambitious
rubenada edited a comment on issue #1110: [CALCITE-2920] RelBuilder: new method
to create an antijoin (Ruben Quesada Lopez)
URL: https://github.com/apache/calcite/pull/1110#issuecomment-475321766
Following the comment by @julianhyde in the Jira ticket, I think we could be
a bit more
jcamachor opened a new pull request #1124: [CALCITE-2942] Materialized view
rewriting logic instantiates RelMeta…
URL: https://github.com/apache/calcite/pull/1124
…dataQuery each time the rule is triggered
This is an
asereda-gs edited a comment on issue #1119: [CALCITE-2937] Linq4j: implement
LazyEnumerable
URL: https://github.com/apache/calcite/pull/1119#issuecomment-475276640
Agree with Julian that we need a unit test.
Also awaiting his opinion on `LazyEnumerator`+`AbstractEnumerable2` vs
asereda-gs edited a comment on issue #1119: [CALCITE-2937] Linq4j: implement
LazyEnumerable
URL: https://github.com/apache/calcite/pull/1119#issuecomment-475276640
Agree with Julian that we need a unit test.
Also awaiting his opinion on `LazyEnumerator`+`AbstractEnumerable2` vs
asereda-gs commented on issue #1119: [CALCITE-2937] Linq4j: implement
LazyEnumerable
URL: https://github.com/apache/calcite/pull/1119#issuecomment-475276640
Agree with Julian that we need unit test.
Also awaiting his opinion on `LazyEnumerator`+`AbstractEnumerable2` vs
danny0405 commented on a change in pull request #1121: [CALCITE-2936] Simplify
EXISTS or NOT EXISTS sub-query that has "GROUP BY ()"
URL: https://github.com/apache/calcite/pull/1121#discussion_r267804795
##
File path:
danny0405 commented on a change in pull request #1120: [CALCITE-2933] Add
timestamp extract for casts from timestamp type to…
URL: https://github.com/apache/calcite/pull/1120#discussion_r267800990
##
File path: druid/src/test/java/org/apache/calcite/test/DruidAdapterIT2.java
danny0405 commented on a change in pull request #1120: [CALCITE-2933] Add
timestamp extract for casts from timestamp type to…
URL: https://github.com/apache/calcite/pull/1120#discussion_r267800204
##
File path: druid/src/main/java/org/apache/calcite/adapter/druid/DruidQuery.java
rubenada commented on a change in pull request #1119: [CALCITE-2937] Linq4j:
implement LazyEnumerable
URL: https://github.com/apache/calcite/pull/1119#discussion_r267796067
##
File path:
linq4j/src/main/java/org/apache/calcite/linq4j/WrapperEnumerable.java
##
@@ -0,0
rubenada commented on a change in pull request #1119: [CALCITE-2937] Linq4j:
implement LazyEnumerable
URL: https://github.com/apache/calcite/pull/1119#discussion_r267796301
##
File path:
linq4j/src/main/java/org/apache/calcite/linq4j/WrapperEnumerable.java
##
@@ -0,0
rubenada commented on a change in pull request #1119: [CALCITE-2937] Linq4j:
implement LazyEnumerable
URL: https://github.com/apache/calcite/pull/1119#discussion_r267796022
##
File path:
linq4j/src/main/java/org/apache/calcite/linq4j/WrapperEnumerable.java
##
@@ -0,0
rubenada commented on a change in pull request #1119: [CALCITE-2937] Linq4j:
implement LazyEnumerable
URL: https://github.com/apache/calcite/pull/1119#discussion_r267795651
##
File path: linq4j/src/main/java/org/apache/calcite/linq4j/Linq4j.java
##
@@ -524,6 +525,39 @@
XuQianJin-Stars removed a comment on issue #1070: [CALCITE-2808] Add the
JSON_LENGTH function
URL: https://github.com/apache/calcite/pull/1070#issuecomment-475213921
hi @zhztheplayer I have just made some modifications. I also think this PR
can be merged after Calcite 1.19.0 release, but
XuQianJin-Stars commented on issue #1070: [CALCITE-2808] Add the JSON_LENGTH
function
URL: https://github.com/apache/calcite/pull/1070#issuecomment-475213921
hi @zhztheplayer I have just made some modifications. I also think this PR
can be merged after Calcite 1.19.0 release, but it can
XuQianJin-Stars commented on issue #1070: [CALCITE-2808] Add the JSON_LENGTH
function
URL: https://github.com/apache/calcite/pull/1070#issuecomment-475212727
hi @zhztheplayer I have just made some modifications. I also think this PR
can be merged after Calcite 1.19.0 release, but it can
LaiZhou closed pull request #1123: [CALCITE-2208]Schemas now uses the config of
current connection to make context,
URL: https://github.com/apache/calcite/pull/1123
This is an automated message from the Apache Git Service.
jessyZu opened a new pull request #1123: Schemas now uses the config of current
connection to make context,
URL: https://github.com/apache/calcite/pull/1123
Schemas now uses the config of current connection to make context,
and CalcitePrepareImpl now uses the context's config rather
rubenada opened a new pull request #1122: [CALCITE-2941] EnumerableLimitRule on
Sort with no collation creates EnumerableLimit with wrong traitSet and cluster
URL: https://github.com/apache/calcite/pull/1122
EnumerableLimitRule "converst a Sort that has offset or fetch set to an
julianhyde commented on a change in pull request #1121: [CALCITE-2936] Simplify
EXISTS or NOT EXISTS sub-query that has "GROUP BY ()"
URL: https://github.com/apache/calcite/pull/1121#discussion_r267653025
##
File path:
julianhyde commented on a change in pull request #1120: [CALCITE-2933] Add
timestamp extract for casts from timestamp type to…
URL: https://github.com/apache/calcite/pull/1120#discussion_r267651445
##
File path: druid/src/main/java/org/apache/calcite/adapter/druid/DruidQuery.java
zhztheplayer commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH
function
URL: https://github.com/apache/calcite/pull/1070#issuecomment-475138942
> Is there anything else that needs to be modified about this PR? Can you
continue to review this PR?
@XuQianJin-Stars - I think
zhztheplayer commented on a change in pull request #1120: [CALCITE-2933] Add
timestamp extract for casts from timestamp type to…
URL: https://github.com/apache/calcite/pull/1120#discussion_r267646121
##
File path: druid/src/test/java/org/apache/calcite/test/DruidAdapterIT2.java
XuQianJin-Stars commented on a change in pull request #1070: [CALCITE-2808]Add
the JSON_LENGTH function
URL: https://github.com/apache/calcite/pull/1070#discussion_r267640584
##
File path:
core/src/main/java/org/apache/calcite/sql/fun/SqlJsonApiCommonSyntaxWithoutPathOperator.java
zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the
JSON_LENGTH function
URL: https://github.com/apache/calcite/pull/1070#discussion_r267639290
##
File path:
core/src/main/java/org/apache/calcite/sql/fun/SqlJsonApiCommonSyntaxWithoutPathOperator.java
XuQianJin-Stars commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH
function
URL: https://github.com/apache/calcite/pull/1070#issuecomment-475128824
hi @zhztheplayer Is there anything else that needs to be modified about this
PR? Can you continue to review this PR?
32 matches
Mail list logo
