[GitHub] [calcite] chunweilei opened a new pull request #1142: [CALCITE-2754] Implement LISTAGG function (Sergey Nuyanzin, Chunwei Lei)

chunweilei opened a new pull request #1142: [CALCITE-2754] Implement LISTAGG function (Sergey Nuyanzin, Chunwei Lei) URL: https://github.com/apache/calcite/pull/1142 JIRA: https://issues.apache.org/jira/browse/CALCITE-2754.

[GitHub] [calcite] chunweilei commented on a change in pull request #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI…

chunweilei commented on a change in pull request #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI… URL: https://github.com/apache/calcite/pull/1140#discussion_r271117712 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java

[GitHub] [calcite] chunweilei commented on a change in pull request #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI…

chunweilei commented on a change in pull request #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI… URL: https://github.com/apache/calcite/pull/1140#discussion_r271117690 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java

[GitHub] [calcite-avatica] F21 commented on issue #86: [CALCITE-2882] Set dirty true when open connection

F21 commented on issue #86: [CALCITE-2882] Set dirty true when open connection URL: https://github.com/apache/calcite-avatica/pull/86#issuecomment-478822344 @bakea Do you think it would be possible to add a test for this?

[GitHub] [calcite] zhztheplayer removed a comment on issue #897: [CALCITE-2648] Output collation of EnumerableWindow is not consistent…

zhztheplayer removed a comment on issue #897: [CALCITE-2648] Output collation of EnumerableWindow is not consistent… URL: https://github.com/apache/calcite/pull/897#issuecomment-468301076 I have no cue to solve the problem perfectly for now, closing temporarily.

[GitHub] [calcite] julianhyde commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys

julianhyde commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys URL: https://github.com/apache/calcite/pull/1141#discussion_r271114592 ## File path: core/src/main/java/org/apache/calcite/materialize/SqlStatisticProvider.java

[GitHub] [calcite] julianhyde commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys

julianhyde commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys URL: https://github.com/apache/calcite/pull/1141#discussion_r271113940 ## File path:

[GitHub] [calcite] zabetak edited a comment on issue #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

zabetak edited a comment on issue #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#issuecomment-478778917 > I need something like config.getRelBuilderFactory().getFilterFactory() The factories are inside the created

[GitHub] [calcite] zabetak commented on issue #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

zabetak commented on issue #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#issuecomment-478778917 > I need something like config.getRelBuilderFactory().getFilterFactory() The factories are inside the created

[GitHub] [calcite] zabetak commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

zabetak commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#discussion_r271079033 ## File path: core/src/main/java/org/apache/calcite/rel/rules/FilterMultiJoinMergeRule.java

[GitHub] [calcite] zabetak commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

zabetak commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#discussion_r271078238 ## File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java ## @@ -2611,12

[GitHub] [calcite] zabetak commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

zabetak commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#discussion_r271078470 ## File path: core/src/main/java/org/apache/calcite/rel/rules/FilterMultiJoinMergeRule.java

[GitHub] [calcite] siddharthteotia commented on issue #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

siddharthteotia commented on issue #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#issuecomment-478775561 > SqlToRelConverter should use the RelBuilderFactory provided in the configuration. As you observed there are

[GitHub] [calcite] zabetak commented on issue #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

zabetak commented on issue #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#issuecomment-478773814 SqlToRelConverter should use the RelBuilderFactory provided in the configuration. As you observed there are places where

[GitHub] [calcite] asereda-gs commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary

asereda-gs commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary URL: https://github.com/apache/calcite/pull/1033#issuecomment-478765546 Thank you! This is an automated

[GitHub] [calcite] asereda-gs merged pull request #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary

asereda-gs merged pull request #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary URL: https://github.com/apache/calcite/pull/1033 This is an automated message from the Apache Git

[GitHub] [calcite] siddharthteotia commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary

siddharthteotia commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary URL: https://github.com/apache/calcite/pull/1033#issuecomment-478759476 > @siddharthteotia there are build failures. Can you pls fix them ? @asereda-gs ,

[GitHub] [calcite] siddharthteotia commented on issue #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

siddharthteotia commented on issue #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#issuecomment-478755526 @vlsi , I have rebased and added a test case to test Filter and Project MultiJoin merge rules work with any

[GitHub] [calcite] asereda-gs commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary

asereda-gs commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary URL: https://github.com/apache/calcite/pull/1033#issuecomment-478741941 @siddharthteotia there are build failures. Can you pls fix them ?

[GitHub] [calcite] siddharthteotia commented on issue #1031: [CALCITE-2742] Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

siddharthteotia commented on issue #1031: [CALCITE-2742] Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#issuecomment-478707508 @asereda-gs , yes I have addressed the review comments. W.r.t change from user = 'sa', I

[GitHub] [calcite] siddharthteotia commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary

siddharthteotia commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary URL: https://github.com/apache/calcite/pull/1033#issuecomment-478707030 Rebased. This is an

[GitHub] [calcite-avatica] risdenk commented on issue #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215

risdenk commented on issue #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215 URL: https://github.com/apache/calcite-avatica/pull/92#issuecomment-478706324 Not ready for review yet but putting in place to push changes as I make them.

[GitHub] [calcite-avatica] risdenk opened a new pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215

risdenk opened a new pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215 URL: https://github.com/apache/calcite-avatica/pull/92 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] rubenada commented on a change in pull request #1112: [CALCITE-2930] FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws IllegalStateException (Ruben Quesada

rubenada commented on a change in pull request #1112: [CALCITE-2930] FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws IllegalStateException (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1112#discussion_r270787259 ## File path:

[GitHub] [calcite] chunweilei commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys

chunweilei commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys URL: https://github.com/apache/calcite/pull/1141#discussion_r270787328 ## File path: core/src/main/java/org/apache/calcite/materialize/SqlStatisticProvider.java

[GitHub] [calcite] zabetak commented on a change in pull request #1112: [CALCITE-2930] FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws IllegalStateException (Ruben Quesada L

zabetak commented on a change in pull request #1112: [CALCITE-2930] FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws IllegalStateException (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1112#discussion_r270784670 ## File path:

[GitHub] [calcite] julianhyde commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys

julianhyde commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys URL: https://github.com/apache/calcite/pull/1141#discussion_r270749202 ## File path:

[GitHub] [calcite] julianhyde commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys

julianhyde commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys URL: https://github.com/apache/calcite/pull/1141#discussion_r270746564 ## File path: core/src/main/java/org/apache/calcite/materialize/SqlStatisticProvider.java

[GitHub] [calcite] julianhyde commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys

julianhyde commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys URL: https://github.com/apache/calcite/pull/1141#discussion_r270745852 ## File path: core/src/main/codegen/templates/Parser.jj ## @@ -5652,6 +5652,24

[GitHub] [calcite] rubenada commented on a change in pull request #1112: [CALCITE-2930] FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws IllegalStateException (Ruben Quesada

rubenada commented on a change in pull request #1112: [CALCITE-2930] FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws IllegalStateException (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1112#discussion_r270741433 ## File path:

[GitHub] [calcite] hsyuan commented on a change in pull request #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI…

hsyuan commented on a change in pull request #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI… URL: https://github.com/apache/calcite/pull/1140#discussion_r270725772 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java

[GitHub] [calcite] danny0405 commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys

danny0405 commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys URL: https://github.com/apache/calcite/pull/1141#discussion_r270725275 ## File path: core/src/main/java/org/apache/calcite/statistic/MapSqlStatisticProvider.java

[GitHub] [calcite] danny0405 commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys

danny0405 commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys URL: https://github.com/apache/calcite/pull/1141#discussion_r270725057 ## File path: core/src/main/java/org/apache/calcite/statistic/MapSqlStatisticProvider.java