yanlin-Lynn commented on a change in pull request #1305: [CALCITE-3177]Find
operator by name and operator.
URL: https://github.com/apache/calcite/pull/1305#discussion_r306609387
##
File path: core/src/test/java/org/apache/calcite/plan/RelWriterTest.java
##
@@ -472,6
yanlin-Lynn commented on a change in pull request #1301: [CALCITE-3175]
AssertionError during serializing RexLiteral with Enum type.
URL: https://github.com/apache/calcite/pull/1301#discussion_r306608656
##
File path:
XuQianJin-Stars commented on issue #1272: [CALCITE-3130]Implement JSON_UNQUOTE,
JSON_QUOTE function
URL: https://github.com/apache/calcite/pull/1272#issuecomment-514448179
hi @michaelmior So let's not support the disabling of the escape sequence
first, and when I think of a more cleaner
zabetak commented on issue #502: [CALCITE-1882] Can't obtain the user defined
aggregate function such …
URL: https://github.com/apache/calcite/pull/502#issuecomment-514413019
I have the impression that after merging
https://github.com/apache/calcite/pull/1205 this PR is obsolete. If
zabetak closed pull request #502: [CALCITE-1882] Can't obtain the user defined
aggregate function such …
URL: https://github.com/apache/calcite/pull/502
This is an automated message from the Apache Git Service.
To respond
zabetak closed pull request #496: [CALCITE-1581] UDTF like in hive
URL: https://github.com/apache/calcite/pull/496
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
zabetak commented on issue #496: [CALCITE-1581] UDTF like in hive
URL: https://github.com/apache/calcite/pull/496#issuecomment-514408711
I am closing this PR since it seems to be superseded by
https://github.com/apache/calcite/pull/1138. If there are reasons to keep it
open feel free to
michaelmior commented on issue #1272: [CALCITE-3130]Implement JSON_UNQUOTE,
JSON_QUOTE function
URL: https://github.com/apache/calcite/pull/1272#issuecomment-514354163
The semantics don't really match since backslash escape sequences are not
disabled everywhere as they are in MySQL. Does
vineetgarg02 commented on issue #1320: [CALCITE-3031] Support for correlated
ANY/SOME/ALL sub-query
URL: https://github.com/apache/calcite/pull/1320#issuecomment-514303342
> Can you rebase on master?
I have rebased and pushed. Thanks for taking a look.
XuQianJin-Stars commented on issue #1321: [CALCITE-3200] Add TEXT Data Type
URL: https://github.com/apache/calcite/pull/1321#issuecomment-514284261
@danny0405 It is true that the impact of the changes to the underlying data
types is indeed large.
XuQianJin-Stars commented on issue #1272: [CALCITE-3130]Implement JSON_UNQUOTE,
JSON_QUOTE function
URL: https://github.com/apache/calcite/pull/1272#issuecomment-514282602
hi @michaelmior Because the `JSON_UNQUOTE` function needs to use the
`NO_BACKSLASH_ESCAPES` parameter to deal with
michaelmior commented on issue #1272: [CALCITE-3130]Implement JSON_UNQUOTE,
JSON_QUOTE function
URL: https://github.com/apache/calcite/pull/1272#issuecomment-514276278
@XuQianJin-Stars Thanks! The master branch seems to be failing on the same
test and is unrelated to your changes.
michaelmior commented on a change in pull request #1272:
[CALCITE-3130]Implement JSON_UNQUOTE, JSON_QUOTE function
URL: https://github.com/apache/calcite/pull/1272#discussion_r306403692
##
File path: core/src/main/java/org/apache/calcite/DataContext.java
##
@@ -122,7
wojustme opened a new pull request #1328: [CALCITE-3207] Fix rel node fail to
convert sql statement
URL: https://github.com/apache/calcite/pull/1328
Calcite cannot convert rel node to sql statement, which case is the
condition of join is 'like' expression.
XuQianJin-Stars commented on issue #1272: [CALCITE-3130]Implement JSON_UNQUOTE,
JSON_QUOTE function
URL: https://github.com/apache/calcite/pull/1272#issuecomment-514249843
hi @michaelmior I rebase this pr now, maybe the CI is broken.
XuQianJin-Stars commented on issue #1325: [CALCITE-3204] Implement jps command
for OS adapter
URL: https://github.com/apache/calcite/pull/1325#issuecomment-514248323
The CI is broken.
This is an automated message from the
michaelmior commented on issue #1272: [CALCITE-3130]Implement JSON_UNQUOTE,
JSON_QUOTE function
URL: https://github.com/apache/calcite/pull/1272#issuecomment-514210349
@XuQianJin-Stars Could you resolve the merge conflicts here?
michaelmior commented on a change in pull request #1305: [CALCITE-3177]Find
operator by name and operator.
URL: https://github.com/apache/calcite/pull/1305#discussion_r306316900
##
File path: core/src/test/java/org/apache/calcite/plan/RelWriterTest.java
##
@@ -472,6
michaelmior commented on a change in pull request #1319: [CALCITE-3195] Handle
UDF that throws checked exceptions in enumerable code generator
URL: https://github.com/apache/calcite/pull/1319#discussion_r306310030
##
File path:
michaelmior commented on a change in pull request #1319: [CALCITE-3195] Handle
UDF that throws checked exceptions in enumerable code generator
URL: https://github.com/apache/calcite/pull/1319#discussion_r306313461
##
File path:
michaelmior commented on a change in pull request #1319: [CALCITE-3195] Handle
UDF that throws checked exceptions in enumerable code generator
URL: https://github.com/apache/calcite/pull/1319#discussion_r306312753
##
File path:
michaelmior commented on a change in pull request #1319: [CALCITE-3195] Handle
UDF that throws checked exceptions in enumerable code generator
URL: https://github.com/apache/calcite/pull/1319#discussion_r306310187
##
File path:
zinking commented on issue #1325: [CALCITE-3204] Implement jps command for OS
adapter
URL: https://github.com/apache/calcite/pull/1325#issuecomment-514185309
how about also add the jvm args column ?
This is an automated
F21 commented on a change in pull request #43: add Connector implementation
URL: https://github.com/apache/calcite-avatica-go/pull/43#discussion_r306269190
##
File path: driver.go
##
@@ -47,10 +47,18 @@ import (
// Driver is exported to allow it to be used directly.
type
F21 commented on a change in pull request #43: add Connector implementation
URL: https://github.com/apache/calcite-avatica-go/pull/43#discussion_r306269190
##
File path: driver.go
##
@@ -47,10 +47,18 @@ import (
// Driver is exported to allow it to be used directly.
type
rubenada commented on a change in pull request #1322: [CALCITE-3198]
ReduceExpressionsRule.FILTER_INSTANCE does not reduce 'NOT(x=a AND x=b)'
URL: https://github.com/apache/calcite/pull/1322#discussion_r306246662
##
File path:
trusch commented on a change in pull request #43: add Connector implementation
URL: https://github.com/apache/calcite-avatica-go/pull/43#discussion_r306263260
##
File path: driver.go
##
@@ -47,10 +47,18 @@ import (
// Driver is exported to allow it to be used directly.
jinxing64 commented on a change in pull request #1322: [CALCITE-3198]
ReduceExpressionsRule.FILTER_INSTANCE does not reduce 'NOT(x=a AND x=b)'
URL: https://github.com/apache/calcite/pull/1322#discussion_r306260839
##
File path:
F21 commented on a change in pull request #43: add Connector implementation
URL: https://github.com/apache/calcite-avatica-go/pull/43#discussion_r306256879
##
File path: driver.go
##
@@ -47,10 +47,18 @@ import (
// Driver is exported to allow it to be used directly.
type
F21 commented on issue #43: add Connector implementation
URL: https://github.com/apache/calcite-avatica-go/pull/43#issuecomment-514161816
@trusch , I've added a review and thanks for working on this!
This is an automated
F21 commented on a change in pull request #43: add Connector implementation
URL: https://github.com/apache/calcite-avatica-go/pull/43#discussion_r306252364
##
File path: driver.go
##
@@ -47,10 +47,18 @@ import (
// Driver is exported to allow it to be used directly.
type
F21 commented on a change in pull request #43: add Connector implementation
URL: https://github.com/apache/calcite-avatica-go/pull/43#discussion_r306251953
##
File path: driver.go
##
@@ -47,10 +47,18 @@ import (
// Driver is exported to allow it to be used directly.
type
F21 commented on a change in pull request #43: add Connector implementation
URL: https://github.com/apache/calcite-avatica-go/pull/43#discussion_r306253229
##
File path: driver.go
##
@@ -47,10 +47,18 @@ import (
// Driver is exported to allow it to be used directly.
type
F21 commented on a change in pull request #43: add Connector implementation
URL: https://github.com/apache/calcite-avatica-go/pull/43#discussion_r306253394
##
File path: driver.go
##
@@ -66,6 +74,7 @@ func (a *Driver) Open(dsn string) (driver.Conn, error) {
F21 commented on a change in pull request #43: add Connector implementation
URL: https://github.com/apache/calcite-avatica-go/pull/43#discussion_r306253794
##
File path: driver.go
##
@@ -47,10 +47,18 @@ import (
// Driver is exported to allow it to be used directly.
type
F21 commented on a change in pull request #43: add Connector implementation
URL: https://github.com/apache/calcite-avatica-go/pull/43#discussion_r306254027
##
File path: http_client.go
##
@@ -172,13 +174,16 @@ func (c *httpClient) post(ctx context.Context, message
trusch commented on issue #43: add Connector implementation
URL: https://github.com/apache/calcite-avatica-go/pull/43#issuecomment-514160862
@F21 Could you tell me about the changes you would like to see?
This is an automated
rubenada commented on a change in pull request #1322: [CALCITE-3198]
ReduceExpressionsRule.FILTER_INSTANCE does not reduce 'NOT(x=a AND x=b)'
URL: https://github.com/apache/calcite/pull/1322#discussion_r306246662
##
File path:
trusch commented on issue #43: add Connector implementation
URL: https://github.com/apache/calcite-avatica-go/pull/43#issuecomment-514148961
@F21 Here it is, slightly delayed, but its here :D It is just a small change
but somehow I managed to break the bad-ping test. I dont see anything
jinxing64 commented on a change in pull request #1322: [CALCITE-3198]
ReduceExpressionsRule.FILTER_INSTANCE does not reduce 'NOT(x=a AND x=b)'
URL: https://github.com/apache/calcite/pull/1322#discussion_r306235878
##
File path:
trusch opened a new pull request #43: add Connector implementation
URL: https://github.com/apache/calcite-avatica-go/pull/43
**What**
* adds an implementation for `driver.Connector` to the project.
* allows passing in arbitary infos and headers to do all kinds of auth stuff
jinxing64 commented on a change in pull request #1324: [CALCITE-3203] When
matching materializations, match Project with child of Aggregate
URL: https://github.com/apache/calcite/pull/1324#discussion_r306222697
##
File path:
danny0405 edited a comment on issue #1321: [CALCITE-3200] Add TEXT Data Type
URL: https://github.com/apache/calcite/pull/1321#issuecomment-514123501
> @danny0405 sorry, I not find through add a sql dialect data type or make
it pluggable and have a clear interface. Can you give me some
danny0405 commented on issue #1321: [CALCITE-3200] Add TEXT Data Type
URL: https://github.com/apache/calcite/pull/1321#issuecomment-514123501
> @danny0405 sorry, I not find through add a sql dialect data type or make
it pluggable and have a clear interface. Can you give me some
This is an automated email from the ASF dual-hosted git repository.
chunwei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/master by this push:
new 5754fa9 [CALCITE-2510] Implement CHR
chunweilei closed pull request #810: [CALCITE-2510] Add CHR built-in function
(Oracle only)
URL: https://github.com/apache/calcite/pull/810
This is an automated message from the Apache Git Service.
To respond to the
danny0405 commented on a change in pull request #1301: [CALCITE-3175]
AssertionError during serializing RexLiteral with Enum type.
URL: https://github.com/apache/calcite/pull/1301#discussion_r306196436
##
File path: core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java
danny0405 commented on a change in pull request #1301: [CALCITE-3175]
AssertionError during serializing RexLiteral with Enum type.
URL: https://github.com/apache/calcite/pull/1301#discussion_r306196189
##
File path: core/src/test/java/org/apache/calcite/plan/RelWriterTest.java
ambition119 commented on issue #1321: [CALCITE-3200] Add TEXT Data Type
URL: https://github.com/apache/calcite/pull/1321#issuecomment-514110791
@danny0405 sorry, I not find through add a sql dialect data type or make it
pluggable and have a clear interface. Can you give me some
hsyuan commented on issue #810: [CALCITE-2510] Add CHR built-in function
(Oracle only)
URL: https://github.com/apache/calcite/pull/810#issuecomment-514104657
+1 on @chunweilei 's commit.
This is an automated message from the
hsyuan commented on issue #1283: [CALCITE-3153] Improve testing in TpcdsTest
using assertEqual instead of printing results
URL: https://github.com/apache/calcite/pull/1283#issuecomment-514096450
@LiShuMing Can you squash the commits? I will merge this PR after that.
hsyuan commented on a change in pull request #1325: [CALCITE-3204] Implement
jps command for OS adapter
URL: https://github.com/apache/calcite/pull/1325#discussion_r306173610
##
File path:
plus/src/main/java/org/apache/calcite/adapter/os/JpsTableFunction.java
##
@@ -0,0
hsyuan commented on a change in pull request #1324: [CALCITE-3203] When
matching materializations, match Project with child of Aggregate
URL: https://github.com/apache/calcite/pull/1324#discussion_r306167270
##
File path:
hsyuan commented on issue #1270: Following [CALCITE-2804], fix incorrect
expected Druid query in test …
URL: https://github.com/apache/calcite/pull/1270#issuecomment-514089941
@zhztheplayer I think it is good to go, are you ready to merge?
hsyuan commented on issue #1320: [CALCITE-3031] Support for correlated
ANY/SOME/ALL sub-query
URL: https://github.com/apache/calcite/pull/1320#issuecomment-514089462
Can you rebase on master?
This is an automated message
55 matches
Mail list logo
