[GitHub] [calcite] yanlin-Lynn commented on a change in pull request #1725: [CALCITE-3694] Implement SINH function

2020-01-06 Thread GitBox
yanlin-Lynn commented on a change in pull request #1725: [CALCITE-3694] Implement SINH function URL: https://github.com/apache/calcite/pull/1725#discussion_r363620575 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java ## @@ -1705,6

[calcite] branch master updated (4558236 -> 54a6e3a)

2020-01-06 Thread hyuan
This is an automated email from the ASF dual-hosted git repository. hyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 4558236 [CALCITE-3684] Implement CBRT function (Qianjin Xu) add 54a6e3a [CALCITE-3510] Implement Redis

[GitHub] [calcite] hsyuan merged pull request #1591: [CALCITE-3510] Implement Redis adapter

2020-01-06 Thread GitBox
hsyuan merged pull request #1591: [CALCITE-3510] Implement Redis adapter URL: https://github.com/apache/calcite/pull/1591 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] dhirenda-gautam edited a comment on issue #1714: [Calcite 3663] Support for TRIM function in BigQuery dialect

2020-01-06 Thread GitBox
dhirenda-gautam edited a comment on issue #1714: [Calcite 3663] Support for TRIM function in BigQuery dialect URL: https://github.com/apache/calcite/pull/1714#issuecomment-571444952 @chunweilei thanks for suggestion i have updated the commit message

[GitHub] [calcite] danny0405 commented on a change in pull request #1727: [CALCITE-3640] Oracle EXISTSNODE Function Support

2020-01-06 Thread GitBox
danny0405 commented on a change in pull request #1727: [CALCITE-3640] Oracle EXISTSNODE Function Support URL: https://github.com/apache/calcite/pull/1727#discussion_r363605467 ## File path: site/_docs/reference.md ## @@ -2283,7 +2283,8 @@ semantics. | m |

[GitHub] [calcite] danny0405 commented on a change in pull request #1727: [CALCITE-3640] Oracle EXISTSNODE Function Support

2020-01-06 Thread GitBox
danny0405 commented on a change in pull request #1727: [CALCITE-3640] Oracle EXISTSNODE Function Support URL: https://github.com/apache/calcite/pull/1727#discussion_r363605077 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java ## @@

[GitHub] [calcite] helloppx commented on a change in pull request #1715: [CALCITE-3662] Generate wrong SQL when plan contains Project(Sort(Aggregate)) and aggregate field has no alias

2020-01-06 Thread GitBox
helloppx commented on a change in pull request #1715: [CALCITE-3662] Generate wrong SQL when plan contains Project(Sort(Aggregate)) and aggregate field has no alias URL: https://github.com/apache/calcite/pull/1715#discussion_r363601885 ## File path:

[GitHub] [calcite] helloppx commented on a change in pull request #1715: [CALCITE-3662] Generate wrong SQL when plan contains Project(Sort(Aggregate)) and aggregate field has no alias

2020-01-06 Thread GitBox
helloppx commented on a change in pull request #1715: [CALCITE-3662] Generate wrong SQL when plan contains Project(Sort(Aggregate)) and aggregate field has no alias URL: https://github.com/apache/calcite/pull/1715#discussion_r363601885 ## File path:

[GitHub] [calcite] helloppx commented on a change in pull request #1715: [CALCITE-3662] Generate wrong SQL when plan contains Project(Sort(Aggregate)) and aggregate field has no alias

2020-01-06 Thread GitBox
helloppx commented on a change in pull request #1715: [CALCITE-3662] Generate wrong SQL when plan contains Project(Sort(Aggregate)) and aggregate field has no alias URL: https://github.com/apache/calcite/pull/1715#discussion_r363601259 ## File path:

[GitHub] [calcite] dhirenda-gautam commented on issue #1714: [Calcite 3663] Support for TRIM function in BigQuery dialect

2020-01-06 Thread GitBox
dhirenda-gautam commented on issue #1714: [Calcite 3663] Support for TRIM function in BigQuery dialect URL: https://github.com/apache/calcite/pull/1714#issuecomment-571444952 @chunweilei thanks for suggestion i have update the commit message

[GitHub] [calcite] ritesh-kapoor opened a new pull request #1727: [CALCITE-3640] Oracle EXISTSNODE Function Support

2020-01-06 Thread GitBox
ritesh-kapoor opened a new pull request #1727: [CALCITE-3640] Oracle EXISTSNODE Function Support URL: https://github.com/apache/calcite/pull/1727 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] DonnyZone commented on a change in pull request #1724: [CALCITE-3675] SQL to Rel conversion is broken for coalesce on nullable field

2020-01-06 Thread GitBox
DonnyZone commented on a change in pull request #1724: [CALCITE-3675] SQL to Rel conversion is broken for coalesce on nullable field URL: https://github.com/apache/calcite/pull/1724#discussion_r363583754 ## File path:

[calcite] branch master updated (1c84234 -> 4558236)

2020-01-06 Thread chunwei
This is an automated email from the ASF dual-hosted git repository. chunwei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 1c84234 [CALCITE-3587] RexBuilder may lose decimal fraction for creating literal with DECIMAL type (Wang Yanlin)

[GitHub] [calcite] chunweilei closed pull request #1723: [CALCITE-3684] Implement CBRT function

2020-01-06 Thread GitBox
chunweilei closed pull request #1723: [CALCITE-3684] Implement CBRT function URL: https://github.com/apache/calcite/pull/1723 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [calcite] DonnyZone commented on a change in pull request #1724: [CALCITE-3675] SQL to Rel conversion is broken for coalesce on nullable field

2020-01-06 Thread GitBox
DonnyZone commented on a change in pull request #1724: [CALCITE-3675] SQL to Rel conversion is broken for coalesce on nullable field URL: https://github.com/apache/calcite/pull/1724#discussion_r363583754 ## File path:

[calcite] branch master updated (40f5a0f -> 1c84234)

2020-01-06 Thread chunwei
This is an automated email from the ASF dual-hosted git repository. chunwei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 40f5a0f [CALCITE-3154] RelToSqlConverter generates NULLS LAST and NULLS FIRST wrongly when using MysqlSqlDialect

[GitHub] [calcite] chunweilei merged pull request #1654: [CALCITE-3587] RexBuilder may lose decimal fraction for creating literal with DECIMAL type

2020-01-06 Thread GitBox
chunweilei merged pull request #1654: [CALCITE-3587] RexBuilder may lose decimal fraction for creating literal with DECIMAL type URL: https://github.com/apache/calcite/pull/1654 This is an automated message from the Apache

[GitHub] [calcite] helloppx commented on a change in pull request #1715: [CALCITE-3662] Generate wrong SQL when plan contains Project(Sort(Aggregate)) and aggregate field has no alias

2020-01-06 Thread GitBox
helloppx commented on a change in pull request #1715: [CALCITE-3662] Generate wrong SQL when plan contains Project(Sort(Aggregate)) and aggregate field has no alias URL: https://github.com/apache/calcite/pull/1715#discussion_r363581275 ## File path:

[GitHub] [calcite] chunweilei closed pull request #1285: [CALCITE-3154] RelToSqlConverter generated Nulls Last and Nulls First when convert RexOver to sql using MysqlSqlDialect.

2020-01-06 Thread GitBox
chunweilei closed pull request #1285: [CALCITE-3154] RelToSqlConverter generated Nulls Last and Nulls First when convert RexOver to sql using MysqlSqlDialect. URL: https://github.com/apache/calcite/pull/1285 This is an

[calcite] branch master updated (ee1a70a -> 40f5a0f)

2020-01-06 Thread chunwei
This is an automated email from the ASF dual-hosted git repository. chunwei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from ee1a70a [CALCITE-3658] TableModify of Update contains correlated variable by mistake (Jin Xing) add 40f5a0f

[calcite] branch master updated (3302a49 -> ee1a70a)

2020-01-06 Thread hyuan
This is an automated email from the ASF dual-hosted git repository. hyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 3302a49 [CALCITE-3580] Oracle EXTRACT(XML) Function Support (ritesh-kapoor) add ee1a70a [CALCITE-3658]

[GitHub] [calcite] hsyuan merged pull request #1713: [CALCITE-3658] TableModify of Update contains correlated variable by …

2020-01-06 Thread GitBox
hsyuan merged pull request #1713: [CALCITE-3658] TableModify of Update contains correlated variable by … URL: https://github.com/apache/calcite/pull/1713 This is an automated message from the Apache Git Service. To respond

[calcite] branch master updated: [CALCITE-3580] Oracle EXTRACT(XML) Function Support (ritesh-kapoor)

2020-01-06 Thread chunwei
This is an automated email from the ASF dual-hosted git repository. chunwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 3302a49 [CALCITE-3580] Oracle EXTRACT(XML)

[GitHub] [calcite] chunweilei closed pull request #1701: [CALCITE-3580] Oracle EXTRACT(XML) Function Support

2020-01-06 Thread GitBox
chunweilei closed pull request #1701: [CALCITE-3580] Oracle EXTRACT(XML) Function Support URL: https://github.com/apache/calcite/pull/1701 This is an automated message from the Apache Git Service. To respond to the message,

[calcite] branch master updated (2952476 -> 162275b)

2020-01-06 Thread chunwei
This is an automated email from the ASF dual-hosted git repository. chunwei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. omit 2952476 [CALCITE-2672] Qualifying the common column should not be allowed in Oracle dialect and SQL statndard

[GitHub] [calcite] helloppx commented on a change in pull request #1715: [CALCITE-3662] Generate wrong SQL when plan contains Project(Sort(Aggregate)) and aggregate field has no alias

2020-01-06 Thread GitBox
helloppx commented on a change in pull request #1715: [CALCITE-3662] Generate wrong SQL when plan contains Project(Sort(Aggregate)) and aggregate field has no alias URL: https://github.com/apache/calcite/pull/1715#discussion_r363573662 ## File path:

[GitHub] [calcite] chunweilei commented on issue #1714: [Calcite 3663] Support for TRIM function in BigQuery dialect

2020-01-06 Thread GitBox
chunweilei commented on issue #1714: [Calcite 3663] Support for TRIM function in BigQuery dialect URL: https://github.com/apache/calcite/pull/1714#issuecomment-571410172 @dhirenda-gautam Please modify the commit message to the right format, namely `[CALCITE-3663] Support for TRIM

[calcite] branch master updated (9db466d -> 2952476)

2020-01-06 Thread chunwei
This is an automated email from the ASF dual-hosted git repository. chunwei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 9db466d [CALCITE-3711] Correlate should override estimateRowCount add 2952476 [CALCITE-2672] Qualifying the

[GitHub] [calcite] chunweilei merged pull request #1710: [CALCITE-2672] Qualifying the common column should not be allowed in Oracle dialect

2020-01-06 Thread GitBox
chunweilei merged pull request #1710: [CALCITE-2672] Qualifying the common column should not be allowed in Oracle dialect URL: https://github.com/apache/calcite/pull/1710 This is an automated message from the Apache Git

[GitHub] [calcite] xy2953396112 commented on a change in pull request #1704: [CALCITE-3644] Add ProjectSetOpTransposeRule to normalize materialized view

2020-01-06 Thread GitBox
xy2953396112 commented on a change in pull request #1704: [CALCITE-3644] Add ProjectSetOpTransposeRule to normalize materialized view URL: https://github.com/apache/calcite/pull/1704#discussion_r363571305 ## File path:

[GitHub] [calcite] chunweilei commented on a change in pull request #1724: [CALCITE-3675] SQL to Rel conversion is broken for coalesce on nullable field

2020-01-06 Thread GitBox
chunweilei commented on a change in pull request #1724: [CALCITE-3675] SQL to Rel conversion is broken for coalesce on nullable field URL: https://github.com/apache/calcite/pull/1724#discussion_r363571034 ## File path:

[GitHub] [calcite] chunweilei commented on a change in pull request #1724: [CALCITE-3675] SQL to Rel conversion is broken for coalesce on nullable field

2020-01-06 Thread GitBox
chunweilei commented on a change in pull request #1724: [CALCITE-3675] SQL to Rel conversion is broken for coalesce on nullable field URL: https://github.com/apache/calcite/pull/1724#discussion_r363570799 ## File path:

[calcite] branch master updated (963a266 -> 9db466d)

2020-01-06 Thread vladimirsitnikov
This is an automated email from the ASF dual-hosted git repository. vladimirsitnikov pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 963a266 [CALCITE-3606] Derive target table column list by mistake when convert TableModify to Sql

[GitHub] [calcite] vlsi merged pull request #1726: [CALCITE-3711] Correlate should override estimateRowCount

2020-01-06 Thread GitBox
vlsi merged pull request #1726: [CALCITE-3711] Correlate should override estimateRowCount URL: https://github.com/apache/calcite/pull/1726 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [calcite] vlsi opened a new pull request #1726: [CALCITE-3711] Correlate should override estimateRowCount

2020-01-06 Thread GitBox
vlsi opened a new pull request #1726: [CALCITE-3711] Correlate should override estimateRowCount URL: https://github.com/apache/calcite/pull/1726 See https://issues.apache.org/jira/browse/CALCITE-3711 This is an automated

[GitHub] [calcite] XuQianJin-Stars opened a new pull request #1725: [CALCITE-3694] Implement SINH function

2020-01-06 Thread GitBox
XuQianJin-Stars opened a new pull request #1725: [CALCITE-3694] Implement SINH function URL: https://github.com/apache/calcite/pull/1725 As illustrated in [CALCITE-3694](https://issues.apache.org/jira/browse/CALCITE-3694) # SINH function returns the hyperbolic sine of a number.

[GitHub] [calcite] jinxing64 commented on a change in pull request #1715: [CALCITE-3662] Generate wrong SQL when plan contains Project(Sort(Aggregate)) and aggregate field has no alias

2020-01-06 Thread GitBox
jinxing64 commented on a change in pull request #1715: [CALCITE-3662] Generate wrong SQL when plan contains Project(Sort(Aggregate)) and aggregate field has no alias URL: https://github.com/apache/calcite/pull/1715#discussion_r363302696 ## File path:

[GitHub] [calcite] jinxing64 commented on a change in pull request #1715: [CALCITE-3662] Generate wrong SQL when plan contains Project(Sort(Aggregate)) and aggregate field has no alias

2020-01-06 Thread GitBox
jinxing64 commented on a change in pull request #1715: [CALCITE-3662] Generate wrong SQL when plan contains Project(Sort(Aggregate)) and aggregate field has no alias URL: https://github.com/apache/calcite/pull/1715#discussion_r363300215 ## File path:

[GitHub] [calcite] jinxing64 commented on a change in pull request #1715: [CALCITE-3662] Generate wrong SQL when plan contains Project(Sort(Aggregate)) and aggregate field has no alias

2020-01-06 Thread GitBox
jinxing64 commented on a change in pull request #1715: [CALCITE-3662] Generate wrong SQL when plan contains Project(Sort(Aggregate)) and aggregate field has no alias URL: https://github.com/apache/calcite/pull/1715#discussion_r363299547 ## File path:

[GitHub] [calcite] jinxing64 commented on a change in pull request #1715: [CALCITE-3662] Generate wrong SQL when plan contains Project(Sort(Aggregate)) and aggregate field has no alias

2020-01-06 Thread GitBox
jinxing64 commented on a change in pull request #1715: [CALCITE-3662] Generate wrong SQL when plan contains Project(Sort(Aggregate)) and aggregate field has no alias URL: https://github.com/apache/calcite/pull/1715#discussion_r363300931 ## File path:

[GitHub] [calcite] helloppx commented on a change in pull request #1715: [CALCITE-3662] Generate wrong SQL when plan contains Project(Sort(Aggregate)) and aggregate field has no alias

2020-01-06 Thread GitBox
helloppx commented on a change in pull request #1715: [CALCITE-3662] Generate wrong SQL when plan contains Project(Sort(Aggregate)) and aggregate field has no alias URL: https://github.com/apache/calcite/pull/1715#discussion_r363250728 ## File path:

[calcite] branch master updated (c416c31 -> 963a266)

2020-01-06 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from c416c31 [CALCITE-3526] SqlPrettyWriter should have options to fold/chop long lines, print leading commas

[GitHub] [calcite] danny0405 closed pull request #1695: [CALCITE-3606] Derive target table column list by mistake when conver…

2020-01-06 Thread GitBox
danny0405 closed pull request #1695: [CALCITE-3606] Derive target table column list by mistake when conver… URL: https://github.com/apache/calcite/pull/1695 This is an automated message from the Apache Git Service. To

[GitHub] [calcite] dhirenda-gautam commented on issue #1714: [Calcite 3663] Support for TRIM function in BigQuery dialect

2020-01-06 Thread GitBox
dhirenda-gautam commented on issue #1714: [Calcite 3663] Support for TRIM function in BigQuery dialect URL: https://github.com/apache/calcite/pull/1714#issuecomment-571099092 Rebase the branch and solved conflict This is an

[GitHub] [calcite] vlsi commented on a change in pull request #1702: Use concurrent test execution by default

2020-01-06 Thread GitBox
vlsi commented on a change in pull request #1702: Use concurrent test execution by default URL: https://github.com/apache/calcite/pull/1702#discussion_r363213605 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableHashJoin.java ## @@ -101,44

[GitHub] [calcite] jinxing64 commented on issue #1647: [CALCITE-3588] JDBC adapter should handle join conditions containing IS TRUE, SIMILAR TO etc. when generating SQL

2020-01-06 Thread GitBox
jinxing64 commented on issue #1647: [CALCITE-3588] JDBC adapter should handle join conditions containing IS TRUE, SIMILAR TO etc. when generating SQL URL: https://github.com/apache/calcite/pull/1647#issuecomment-571058303 Gentle ping @chunweilei More comments ?

[GitHub] [calcite] chunweilei commented on issue #1724: [CALCITE-3675] SQL to Rel conversion is broken for coalesce on nullable field

2020-01-06 Thread GitBox
chunweilei commented on issue #1724: [CALCITE-3675] SQL to Rel conversion is broken for coalesce on nullable field URL: https://github.com/apache/calcite/pull/1724#issuecomment-571052530 > Hi, @chunweilei, could you take a look when you have time? I fail to come up with any elegant

[GitHub] [calcite] rubenada commented on a change in pull request #1702: Use concurrent test execution by default

2020-01-06 Thread GitBox
rubenada commented on a change in pull request #1702: Use concurrent test execution by default URL: https://github.com/apache/calcite/pull/1702#discussion_r363195740 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableHashJoin.java ## @@

[GitHub] [calcite] rubenada commented on a change in pull request #1702: Use concurrent test execution by default

2020-01-06 Thread GitBox
rubenada commented on a change in pull request #1702: Use concurrent test execution by default URL: https://github.com/apache/calcite/pull/1702#discussion_r363195740 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableHashJoin.java ## @@

[GitHub] [calcite] DonnyZone commented on issue #1724: [CALCITE-3675] SQL to Rel conversion is broken for coalesce on nullable field

2020-01-06 Thread GitBox
DonnyZone commented on issue #1724: [CALCITE-3675] SQL to Rel conversion is broken for coalesce on nullable field URL: https://github.com/apache/calcite/pull/1724#issuecomment-571047213 Hi, @chunweilei, could you take a look when you have time? I fail to come up with any elegant solutions

[GitHub] [calcite] DonnyZone opened a new pull request #1724: [CALCITE-3675] SQL to Rel conversion is broken for coalesce on nullable field

2020-01-06 Thread GitBox
DonnyZone opened a new pull request #1724: [CALCITE-3675] SQL to Rel conversion is broken for coalesce on nullable field URL: https://github.com/apache/calcite/pull/1724 The issue is introduced by [CALCITE-3355](https://issues.apache.org/jira/browse/CALCITE-3355), in which type

[calcite] branch master updated (5e4d396 -> c416c31)

2020-01-06 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 5e4d396 [CALCITE-3672] Support implicit type coercion for insert and update new 8658804 In DiffRepository,

[calcite] 02/07: Add gradle task 'aggregateJavadocIncludingTests' that builds javadoc for both main and test

2020-01-06 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit 4e7f92557a240de58cd950dce6ab478c1bc11604 Author: Julian Hyde AuthorDate: Wed Nov 20 14:10:48 2019 -0800 Add gradle

[calcite] 06/07: [CALCITE-3328] Immutable beans, powered by reflection

2020-01-06 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit e88809e7288db9b7d33be8a67840e02a71327675 Author: Julian Hyde AuthorDate: Fri Sep 6 23:24:56 2019 -0700

[calcite] 04/07: Contribute class Resources to ASF, and change its header

2020-01-06 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit 61da868ea50fa9fd1584eaafd3fcb0c644e9c953 Author: Julian Hyde AuthorDate: Tue Dec 10 21:03:18 2019 -0800 Contribute

[calcite] 03/07: Bump spark-core_2.10 from 2.2.0 to 2.2.2

2020-01-06 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit 8a49c9fda80c6d81721f0cf1044c83feed57f589 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[calcite] 01/07: In DiffRepository, replace a synchronized Map with a Guava cache

2020-01-06 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit 8658804e0a1b5c2fe9c78fa8e40655db06531ac8 Author: Julian Hyde AuthorDate: Mon Dec 16 15:57:53 2019 -0800 In

[calcite] 05/07: Javadoc warning

2020-01-06 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit 68eacfc57da7492377797e39ee3e2778be1b1aa4 Author: Julian Hyde AuthorDate: Tue Nov 12 10:50:51 2019 -0800 Javadoc