[GitHub] [calcite] laurentgo commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

2020-06-12 Thread GitBox
laurentgo commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r439694355 ## File path: core/src/main/java/org/apache/calcite/plan/Digest.java ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [calcite] laurentgo commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

2020-06-12 Thread GitBox
laurentgo commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r439693715 ## File path: core/src/main/java/org/apache/calcite/plan/Digest.java ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [calcite] danny0405 commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

2020-06-12 Thread GitBox
danny0405 commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r439693708 ## File path: core/src/main/java/org/apache/calcite/plan/Digest.java ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [calcite] laurentgo commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

2020-06-12 Thread GitBox
laurentgo commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r439693614 ## File path: core/src/main/java/org/apache/calcite/plan/Digest.java ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [calcite] danny0405 commented on pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

2020-06-12 Thread GitBox
danny0405 commented on pull request #2016: URL: https://github.com/apache/calcite/pull/2016#issuecomment-643544569 > I have to say that I don't see how this pull request makes hash code more efficient (precomputation of hashcode?). For sure it looks to increase memory usage and also

[GitHub] [calcite] danny0405 commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

2020-06-12 Thread GitBox
danny0405 commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r439692622 ## File path: core/src/main/java/org/apache/calcite/plan/Digest.java ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [calcite] danny0405 commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

2020-06-12 Thread GitBox
danny0405 commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r439692488 ## File path: core/src/main/java/org/apache/calcite/plan/Digest.java ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [calcite] danny0405 commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

2020-06-12 Thread GitBox
danny0405 commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r439692310 ## File path: core/src/main/java/org/apache/calcite/plan/Digest.java ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [calcite] julianhyde opened a new pull request #2024: [CALCITE-3923] Refactor how planner rules are parameterized

2020-06-12 Thread GitBox
julianhyde opened a new pull request #2024: URL: https://github.com/apache/calcite/pull/2024 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite] amaliujia commented on pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-12 Thread GitBox
amaliujia commented on pull request #2006: URL: https://github.com/apache/calcite/pull/2006#issuecomment-643500881 Friendly ping~ This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [calcite] amaliujia commented on a change in pull request #2023: [CALCITE-4057] Implement trait propagation for EnumerableBatchNestedL…

2020-06-12 Thread GitBox
amaliujia commented on a change in pull request #2023: URL: https://github.com/apache/calcite/pull/2023#discussion_r439609801 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumTraitsUtils.java ## @@ -148,4 +149,52 @@ private static boolean

[calcite] branch master updated (3f049ee -> bb22d47)

2020-06-12 Thread vladimirsitnikov
This is an automated email from the ASF dual-hosted git repository. vladimirsitnikov pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. omit 3f049ee Update Gradle: 6.3 -> 6.5 This update removed existing revisions from the reference, leaving

[calcite] branch master updated: Update Gradle: 6.3 -> 6.5

2020-06-12 Thread vladimirsitnikov
This is an automated email from the ASF dual-hosted git repository. vladimirsitnikov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 3f049ee Update Gradle: 6.3 -> 6.5

[GitHub] [calcite] hsyuan commented on a change in pull request #2023: [CALCITE-4057] Implement trait propagation for EnumerableBatchNestedL…

2020-06-12 Thread GitBox
hsyuan commented on a change in pull request #2023: URL: https://github.com/apache/calcite/pull/2023#discussion_r439580414 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumTraitsUtils.java ## @@ -148,4 +149,52 @@ private static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2023: [CALCITE-4057] Implement trait propagation for EnumerableBatchNestedL…

2020-06-12 Thread GitBox
amaliujia commented on a change in pull request #2023: URL: https://github.com/apache/calcite/pull/2023#discussion_r439579435 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumTraitsUtils.java ## @@ -148,4 +149,52 @@ private static boolean

[GitHub] [calcite] hsyuan commented on a change in pull request #2023: [CALCITE-4057] Implement trait propagation for EnumerableBatchNestedL…

2020-06-12 Thread GitBox
hsyuan commented on a change in pull request #2023: URL: https://github.com/apache/calcite/pull/2023#discussion_r439578915 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumTraitsUtils.java ## @@ -148,4 +149,52 @@ private static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2023: [CALCITE-4057] Implement trait propagation for EnumerableBatchNestedL…

2020-06-12 Thread GitBox
amaliujia commented on a change in pull request #2023: URL: https://github.com/apache/calcite/pull/2023#discussion_r439577517 ## File path: core/src/test/java/org/apache/calcite/test/TopDownOptTest.java ## @@ -693,6 +678,37 @@

[GitHub] [calcite] amaliujia commented on a change in pull request #2023: [CALCITE-4057] Implement trait propagation for EnumerableBatchNestedL…

2020-06-12 Thread GitBox
amaliujia commented on a change in pull request #2023: URL: https://github.com/apache/calcite/pull/2023#discussion_r439577088 ## File path: core/src/test/java/org/apache/calcite/test/TopDownOptTest.java ## @@ -483,7 +476,6 @@ Query.create(sql)

[GitHub] [calcite] amaliujia commented on pull request #2023: [CALCITE-4057] Implement trait propagation for EnumerableBatchNestedL…

2020-06-12 Thread GitBox
amaliujia commented on pull request #2023: URL: https://github.com/apache/calcite/pull/2023#issuecomment-643421126 R: @chunweilei @hsyuan This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [calcite] amaliujia opened a new pull request #2023: [CALCITE-4057] Implement trait propagation for EnumerableBatchNestedL…

2020-06-12 Thread GitBox
amaliujia opened a new pull request #2023: URL: https://github.com/apache/calcite/pull/2023 …oopJoin (Rui Wang). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [calcite] laurentgo commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

2020-06-12 Thread GitBox
laurentgo commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r439507991 ## File path: core/src/main/java/org/apache/calcite/plan/Digest.java ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[calcite] branch master updated (f099919 -> bb22d47)

2020-06-12 Thread vladimirsitnikov
This is an automated email from the ASF dual-hosted git repository. vladimirsitnikov pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. omit f099919 [CALCITE-4061] Build should fail if Calcite code uses deprecated APIs new bb22d47

[calcite] 01/01: [CALCITE-4061] Build should fail if Calcite code uses deprecated APIs

2020-06-12 Thread vladimirsitnikov
This is an automated email from the ASF dual-hosted git repository. vladimirsitnikov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit bb22d4773cd2c24bb69acaaf548fb8d17ec99182 Author: Vladimir Sitnikov AuthorDate: Fri Jun 12 15:24:43 2020

[calcite] branch master updated: [CALCITE-4061] Build should fail if Calcite code uses deprecated APIs

2020-06-12 Thread vladimirsitnikov
This is an automated email from the ASF dual-hosted git repository. vladimirsitnikov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new f099919 [CALCITE-4061] Build should

[GitHub] [calcite] xy2953396112 opened a new pull request #2022: [CALCITE-4062] Support deserialize UDF array type from json string

2020-06-12 Thread GitBox
xy2953396112 opened a new pull request #2022: URL: https://github.com/apache/calcite/pull/2022 https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-4062 This is an automated message from the Apache Git Service. To

[GitHub] [calcite] jinxing64 commented on pull request #2013: [CALCITE-3935] Materialization-Failed, when querying with LeftJoinWithFilter

2020-06-12 Thread GitBox
jinxing64 commented on pull request #2013: URL: https://github.com/apache/calcite/pull/2013#issuecomment-643206255 Please refine the commit message. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] jinxing64 commented on a change in pull request #2013: [CALCITE-3935] Materialization-Failed, when querying with LeftJoinWithFilter

2020-06-12 Thread GitBox
jinxing64 commented on a change in pull request #2013: URL: https://github.com/apache/calcite/pull/2013#discussion_r439321177 ## File path: core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java ## @@ -1202,8 +1202,9 @@ private JoinOnLeftCalcToJoinUnifyRule() {

[GitHub] [calcite] danny0405 commented on pull request #2020: [CALCITE-4060] TypeCoercionImpl#inOperationCoercion consider "NOT_IN".

2020-06-12 Thread GitBox
danny0405 commented on pull request #2020: URL: https://github.com/apache/calcite/pull/2020#issuecomment-643150807 Thanks for the contribution, can we change the title to "Supports implicit type coercion for NOT IN" which is more readable.

[calcite] branch master updated: [CALCITE-4016] Support trait propagation for EnumerableCalc

2020-06-12 Thread chunwei
This is an automated email from the ASF dual-hosted git repository. chunwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 3c317b6 [CALCITE-4016] Support trait

[GitHub] [calcite] chunweilei merged pull request #2011: [CALCITE-4016] Support trait propagation for EnumerableCalc

2020-06-12 Thread GitBox
chunweilei merged pull request #2011: URL: https://github.com/apache/calcite/pull/2011 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] chunweilei commented on pull request #2011: [CALCITE-4016] Support trait propagation for EnumerableCalc

2020-06-12 Thread GitBox
chunweilei commented on pull request #2011: URL: https://github.com/apache/calcite/pull/2011#issuecomment-643146964 Thank you for your review, @amaliujia @hsyuan . This is an automated message from the Apache Git Service. To

[GitHub] [calcite] danny0405 commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

2020-06-12 Thread GitBox
danny0405 commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r439280300 ## File path: core/src/main/java/org/apache/calcite/plan/Digest.java ## @@ -0,0 +1,245 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [calcite] rubenada commented on a change in pull request #1987: [CALCITE-4020] Support Calc operator in RelFieldTrimmer

2020-06-12 Thread GitBox
rubenada commented on a change in pull request #1987: URL: https://github.com/apache/calcite/pull/1987#discussion_r439258169 ## File path: core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java ## @@ -350,6 +354,100 @@ public TrimResult trimFields(

[GitHub] [calcite] rubenada commented on a change in pull request #1987: [CALCITE-4020] Support Calc operator in RelFieldTrimmer

2020-06-12 Thread GitBox
rubenada commented on a change in pull request #1987: URL: https://github.com/apache/calcite/pull/1987#discussion_r439257255 ## File path: core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java ## @@ -350,6 +354,100 @@ public TrimResult trimFields(

[GitHub] [calcite] rubenada commented on pull request #1987: [CALCITE-4020] Support Calc operator in RelFieldTrimmer

2020-06-12 Thread GitBox
rubenada commented on pull request #1987: URL: https://github.com/apache/calcite/pull/1987#issuecomment-643116159 @xy2953396112 Please bear in mind that [CALCITE-4055 - RelFieldTrimmer loses hints](https://issues.apache.org/jira/browse/CALCITE-4055)

[calcite] branch master updated: [CALCITE-4055] RelFieldTrimmer loses hints

2020-06-12 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 7c2f677 [CALCITE-4055] RelFieldTrimmer loses

[GitHub] [calcite] rubenada merged pull request #2015: [CALCITE-4055] RelFieldTrimmer loses hints

2020-06-12 Thread GitBox
rubenada merged pull request #2015: URL: https://github.com/apache/calcite/pull/2015 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go