svn commit: r40142 - in /dev/calcite/apache-calcite-avatica-go-5.0.0-rc0: ./ apache-calcite-avatica-go-5.0.0-src.tar.gz apache-calcite-avatica-go-5.0.0-src.tar.gz.asc apache-calcite-avatica-go-5.0.0-s

2020-06-22 Thread francischuang
Author: francischuang Date: Tue Jun 23 03:27:32 2020 New Revision: 40142 Log: apache-calcite-avatica-go-5.0.0-rc0 Added: dev/calcite/apache-calcite-avatica-go-5.0.0-rc0/ dev/calcite/apache-calcite-avatica-go-5.0.0-rc0/apache-calcite-avatica-go-5.0.0-src.tar.gz (with props)

[calcite-avatica-go] tag v5.0.0-rc0 created (now 0e3f5df)

2020-06-22 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to tag v5.0.0-rc0 in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git. at 0e3f5df (commit) No new revisions were added by this update.

[calcite-avatica-go] branch master updated: [CALCITE-4078] Prepare for 5.0.0 release

2020-06-22 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git The following commit(s) were added to refs/heads/master by this push: new 0e3f5df [CALCITE-4078]

[calcite] branch master updated: [CALCITE-3786] Rework digest for RelNode and RexCall

2020-06-22 Thread hyuan
This is an automated email from the ASF dual-hosted git repository. hyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 1736242 [CALCITE-3786] Rework digest for

[GitHub] [calcite] hsyuan merged pull request #2039: Digest on RelNode and RexCall

2020-06-22 Thread GitBox
hsyuan merged pull request #2039: URL: https://github.com/apache/calcite/pull/2039 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite] xy2953396112 commented on a change in pull request #2021: [CALCITE-3929] When deserialize UDAF aggregate call from json string,…

2020-06-22 Thread GitBox
xy2953396112 commented on a change in pull request #2021: URL: https://github.com/apache/calcite/pull/2021#discussion_r443682742 ## File path: core/src/test/java/org/apache/calcite/test/MockSqlOperatorTable.java ## @@ -125,6 +125,18 @@ public RelDataType

[calcite-avatica] branch master updated: [CALCITE-4068] Update website for 1.17.0 release

2020-06-22 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git The following commit(s) were added to refs/heads/master by this push: new cc2404d [CALCITE-4068] Update

[GitHub] [calcite] hsyuan opened a new pull request #2041: [CALCITE-4083] RelTraitSet failed to canonize traits

2020-06-22 Thread GitBox
hsyuan opened a new pull request #2041: URL: https://github.com/apache/calcite/pull/2041 RelTraitSet#plus uses FlatLists and ImmutableList. They have different hash algorithms, and they are all different classes from RelTraitSet. The RelTraitSet equality requires the other object must

[GitHub] [calcite] zabetak merged pull request #2038: [CALCITE-4075] Mock table 'EMPNULLABLES' should allow nulls in all non-pk columns

2020-06-22 Thread GitBox
zabetak merged pull request #2038: URL: https://github.com/apache/calcite/pull/2038 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[calcite] branch master updated: [CALCITE-4075] Mock table 'EMPNULLABLES' should allow nulls in all non-pk columns

2020-06-22 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new c823343 [CALCITE-4075] Mock table

[GitHub] [calcite] xy2953396112 commented on a change in pull request #2021: [CALCITE-3929] When deserialize UDAF aggregate call from json string,…

2020-06-22 Thread GitBox
xy2953396112 commented on a change in pull request #2021: URL: https://github.com/apache/calcite/pull/2021#discussion_r443685867 ## File path: core/src/test/java/org/apache/calcite/plan/RelWriterTest.java ## @@ -146,8 +147,9 @@ + "{\n" + "

[GitHub] [calcite] xy2953396112 commented on a change in pull request #2021: [CALCITE-3929] When deserialize UDAF aggregate call from json string,…

2020-06-22 Thread GitBox
xy2953396112 commented on a change in pull request #2021: URL: https://github.com/apache/calcite/pull/2021#discussion_r443682742 ## File path: core/src/test/java/org/apache/calcite/test/MockSqlOperatorTable.java ## @@ -125,6 +125,18 @@ public RelDataType

[GitHub] [calcite] xy2953396112 commented on a change in pull request #2021: [CALCITE-3929] When deserialize UDAF aggregate call from json string,…

2020-06-22 Thread GitBox
xy2953396112 commented on a change in pull request #2021: URL: https://github.com/apache/calcite/pull/2021#discussion_r443681619 ## File path: core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java ## @@ -271,7 +271,9 @@ public RelDataType toType(RelDataTypeFactory

[GitHub] [calcite] yanlin-Lynn commented on a change in pull request #2021: [CALCITE-3929] When deserialize UDAF aggregate call from json string,…

2020-06-22 Thread GitBox
yanlin-Lynn commented on a change in pull request #2021: URL: https://github.com/apache/calcite/pull/2021#discussion_r443630098 ## File path: core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java ## @@ -271,7 +271,9 @@ public RelDataType toType(RelDataTypeFactory

[calcite] branch master updated (b184707 -> 4389a9c)

2020-06-22 Thread yanlin
This is an automated email from the ASF dual-hosted git repository. yanlin pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from b184707 [CALCITE-3786] Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode (part2)

[GitHub] [calcite] yanlin-Lynn merged pull request #2004: [CALCITE-4019] Visit SqlInsert with SqlShuttle cause NullPointerExcep…

2020-06-22 Thread GitBox
yanlin-Lynn merged pull request #2004: URL: https://github.com/apache/calcite/pull/2004 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [calcite] danny0405 commented on pull request #2039: Digest on RelNode and RexCall

2020-06-22 Thread GitBox
danny0405 commented on pull request #2039: URL: https://github.com/apache/calcite/pull/2039#issuecomment-647564909 > @danny0405 > What you mean by "get involve in the discussion in the [CALCITE-3786](https://issues.apache.org/jira/browse/CALCITE-3786) first"; > I checked this PR and

[GitHub] [calcite] chunweilei commented on a change in pull request #2039: Digest on RelNode and RexCall

2020-06-22 Thread GitBox
chunweilei commented on a change in pull request #2039: URL: https://github.com/apache/calcite/pull/2039#discussion_r443597562 ## File path: core/src/main/java/org/apache/calcite/rex/RexSubQuery.java ## @@ -139,11 +138,14 @@ public RexSubQuery clone(RelNode rel) {

[GitHub] [calcite] chunweilei commented on a change in pull request #2039: Digest on RelNode and RexCall

2020-06-22 Thread GitBox
chunweilei commented on a change in pull request #2039: URL: https://github.com/apache/calcite/pull/2039#discussion_r443589712 ## File path: core/src/main/java/org/apache/calcite/plan/RelDigest.java ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2029: [CALCITE-4066] SqlTypeUtil#convertTypeToSpec cover Array/Multiset/Row types.

2020-06-22 Thread GitBox
Aaron commented on a change in pull request #2029: URL: https://github.com/apache/calcite/pull/2029#discussion_r443587411 ## File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java ## @@ -1038,19 +1043,40 @@ public static SqlDataTypeSpec

[GitHub] [calcite] hsyuan commented on pull request #2039: Digest on RelNode and RexCall

2020-06-22 Thread GitBox
hsyuan commented on pull request #2039: URL: https://github.com/apache/calcite/pull/2039#issuecomment-647540418 > Just one question, if the RelDigest is regarded as internal, why not it's not an inner class in AbstractRelNode ? Planner also use it, they are not in the same package.

[GitHub] [calcite] yanlin-Lynn commented on pull request #2039: Digest on RelNode and RexCall

2020-06-22 Thread GitBox
yanlin-Lynn commented on pull request #2039: URL: https://github.com/apache/calcite/pull/2039#issuecomment-647536605 Actually, I think the implementation here do not have much difference with the master, just with moving the Digest related logic to InnerRelDigest. +1 for the concise and

[GitHub] [calcite] jinxing64 commented on pull request #2039: Digest on RelNode and RexCall

2020-06-22 Thread GitBox
jinxing64 commented on pull request #2039: URL: https://github.com/apache/calcite/pull/2039#issuecomment-647526751 @danny0405 What you mean by "get involve in the discussion in the CALCITE-3786 first"; I checked this PR and give my approve. From my point it's indeed much more

[GitHub] [calcite] danny0405 commented on pull request #2039: Digest on RelNode and RexCall

2020-06-22 Thread GitBox
danny0405 commented on pull request #2039: URL: https://github.com/apache/calcite/pull/2039#issuecomment-647505206 > +1 on this and thanks a lot @hsyuan, RelDigest is much concise. > Just one question, if the `RelDigest` is regarded as internal, why not it's not an inner class in

[GitHub] [calcite] danny0405 commented on a change in pull request #2029: [CALCITE-4066] SqlTypeUtil#convertTypeToSpec cover Array/Multiset/Row types.

2020-06-22 Thread GitBox
danny0405 commented on a change in pull request #2029: URL: https://github.com/apache/calcite/pull/2029#discussion_r443536193 ## File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java ## @@ -1038,19 +1043,40 @@ public static SqlDataTypeSpec

[GitHub] [calcite] danny0405 commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-06-22 Thread GitBox
danny0405 commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r443533534 ## File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java ## @@ -1160,6 +1160,59 @@ public static boolean equalSansNullability(

[GitHub] [calcite] xy2953396112 commented on pull request #2040: [CALCITE-4079] Remove the deprecated code from SqlDialect

2020-06-22 Thread GitBox
xy2953396112 commented on pull request #2040: URL: https://github.com/apache/calcite/pull/2040#issuecomment-647489070 Those codes will be removed before 2.0. Maybe not now. This is an automated message from the

[GitHub] [calcite] wenhuitang opened a new pull request #2040: [CALCITE-4079] Remove the deprecated code from SqlDialect

2020-06-22 Thread GitBox
wenhuitang opened a new pull request #2040: URL: https://github.com/apache/calcite/pull/2040 PR for https://issues.apache.org/jira/browse/CALCITE-4079. Remove deprecated SqlDialect#DUMMY and SqlDialect#CALCITE. This is an

[GitHub] [calcite] wenhuitang commented on a change in pull request #1990: [CALCITE-4026] CassandraFilter has generated wrong condition expression for filter with non string literal

2020-06-22 Thread GitBox
wenhuitang commented on a change in pull request #1990: URL: https://github.com/apache/calcite/pull/1990#discussion_r443493968 ## File path: core/src/main/java/org/apache/calcite/util/DateTimeStringUtils.java ## @@ -25,6 +29,15 @@ private DateTimeStringUtils() {} + /**

[GitHub] [calcite] rubenada commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-22 Thread GitBox
rubenada commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r443486637 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,112 @@ public void remove() {

[GitHub] [calcite] jinxing64 commented on a change in pull request #2039: Digest on RelNode and RexCall

2020-06-22 Thread GitBox
jinxing64 commented on a change in pull request #2039: URL: https://github.com/apache/calcite/pull/2039#discussion_r443469463 ## File path: core/src/main/java/org/apache/calcite/plan/RelOptNode.java ## @@ -45,9 +47,20 @@ * If you want a descriptive string which contains

[GitHub] [calcite] jinxing64 commented on pull request #2039: Digest on RelNode and RexCall

2020-06-22 Thread GitBox
jinxing64 commented on pull request #2039: URL: https://github.com/apache/calcite/pull/2039#issuecomment-647428693 +1 on this and thanks a lot @hsyuan, RelDigest is much concise. Just one question, if the `RelDigest` is regarded as internal, why not it's not an inner class in

[GitHub] [calcite] rubenada commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-22 Thread GitBox
rubenada commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r443451500 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,112 @@ public void remove() {

[GitHub] [calcite] rubenada commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-22 Thread GitBox
rubenada commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r443446065 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,112 @@ public void remove() {

[calcite-avatica-go] branch master updated: Clean up documentation and remove references to dep

2020-06-22 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git The following commit(s) were added to refs/heads/master by this push: new a7b6c34 Clean up

[GitHub] [calcite] rubenada commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-22 Thread GitBox
rubenada commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r443406186 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableSortedAggregate.java ## @@ -90,6 +101,133 @@ public

[GitHub] [calcite] rubenada commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-22 Thread GitBox
rubenada commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r443406186 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableSortedAggregate.java ## @@ -90,6 +101,133 @@ public

[GitHub] [calcite] danny0405 merged pull request #2036: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

2020-06-22 Thread GitBox
danny0405 merged pull request #2036: URL: https://github.com/apache/calcite/pull/2036 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[calcite] branch master updated: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode (part2)

2020-06-22 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new b184707 [CALCITE-3786] Add Digest

[calcite-avatica-go] branch master updated: [CALCITE-3359] Update dependencies

2020-06-22 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git The following commit(s) were added to refs/heads/master by this push: new 14a71e0 [CALCITE-3359]