danny0405 merged pull request #2078:
URL: https://github.com/apache/calcite/pull/2078
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
liyafan82 commented on a change in pull request #2077:
URL: https://github.com/apache/calcite/pull/2077#discussion_r457822016
##
File path: core/src/test/java/org/apache/calcite/rel/RelCollationTest.java
##
@@ -98,6 +101,12 @@
Aaron commented on a change in pull request #2076:
URL: https://github.com/apache/calcite/pull/2076#discussion_r457812900
##
File path:
core/src/main/java/org/apache/calcite/plan/volcano/IterativeRuleQueue.java
##
@@ -101,51 +63,31 @@
*/
@Override public boolean
Aaron commented on a change in pull request #2076:
URL: https://github.com/apache/calcite/pull/2076#discussion_r457812998
##
File path:
core/src/main/java/org/apache/calcite/plan/volcano/IterativeRuleQueue.java
##
@@ -101,51 +63,31 @@
*/
@Override public boolean
Aaron commented on a change in pull request #2076:
URL: https://github.com/apache/calcite/pull/2076#discussion_r457812834
##
File path:
core/src/main/java/org/apache/calcite/plan/volcano/IterativeRuleDriver.java
##
@@ -22,11 +22,11 @@
import org.slf4j.Logger;
/***
- *
Aaron commented on a change in pull request #2076:
URL: https://github.com/apache/calcite/pull/2076#discussion_r457812692
##
File path:
core/src/main/java/org/apache/calcite/plan/volcano/IterativeRuleDriver.java
##
@@ -22,11 +22,11 @@
import org.slf4j.Logger;
/***
- *
hsyuan commented on a change in pull request #2076:
URL: https://github.com/apache/calcite/pull/2076#discussion_r457807922
##
File path:
core/src/main/java/org/apache/calcite/plan/volcano/IterativeRuleDriver.java
##
@@ -22,11 +22,11 @@
import org.slf4j.Logger;
/***
- *
Aaron commented on a change in pull request #1495:
URL: https://github.com/apache/calcite/pull/1495#discussion_r457800490
##
File path: core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java
##
@@ -697,14 +699,22 @@ public TrimResult trimFields(
/**
*
Aaron commented on a change in pull request #1495:
URL: https://github.com/apache/calcite/pull/1495#discussion_r457800490
##
File path: core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java
##
@@ -697,14 +699,22 @@ public TrimResult trimFields(
/**
*
hsyuan commented on a change in pull request #2074:
URL: https://github.com/apache/calcite/pull/2074#discussion_r457800157
##
File path: core/src/main/java/org/apache/calcite/rel/RelNode.java
##
@@ -335,6 +335,26 @@ default String getDigest() {
@API(since = "1.24", status =
xy2953396112 commented on pull request #2014:
URL: https://github.com/apache/calcite/pull/2014#issuecomment-661558313
> +1
Thanks.
This is an automated message from the Apache Git Service.
To respond to the message,
julianhyde commented on pull request #1057:
URL: https://github.com/apache/calcite/pull/1057#issuecomment-661405583
@yuqi1129 Please see comments in
https://issues.apache.org/jira/browse/CALCITE-2854.
This is an automated
julianhyde commented on a change in pull request #1057:
URL: https://github.com/apache/calcite/pull/1057#discussion_r457733806
##
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
##
@@ -2194,7 +2193,14 @@ private Expression
julianhyde commented on pull request #1057:
URL: https://github.com/apache/calcite/pull/1057#issuecomment-661400067
bq. BigDecimal c = a.nagate();//right
@yuqi1129 No, not quite right. `nagate` should be `negate`.
bq. Yes, we can implement in RexImpTable directly.
Half
zabetak commented on a change in pull request #2077:
URL: https://github.com/apache/calcite/pull/2077#discussion_r457175453
##
File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdUtil.java
##
@@ -293,7 +293,7 @@ public static void setLeftRightBitmaps(
*
This is an automated email from the ASF dual-hosted git repository.
chunwei pushed a change to branch branch-1.24
in repository https://gitbox.apache.org/repos/asf/calcite.git.
at 4b5b910 [CALCITE-4117] Release Calcite 1.24.0
No new revisions were added by this update.
This is an automated email from the ASF dual-hosted git repository.
chunwei pushed a change to annotated tag calcite-1.24.0-rc0
in repository https://gitbox.apache.org/repos/asf/calcite.git.
*** WARNING: tag calcite-1.24.0-rc0 was modified! ***
from 4b5b910 (commit)
to 6ea9d28
Author: chunwei
Date: Mon Jul 20 13:04:04 2020
New Revision: 40574
Log:
Uploading release candidate Apache Calcite calcite-1.24.0-rc0 to dev area
Modified:
dev/calcite/apache-calcite-1.24.0-rc0/apache-calcite-1.24.0-src.tar.gz
Author: chunwei
Date: Mon Jul 20 12:55:43 2020
New Revision: 40573
Log:
Uploading release candidate Apache Calcite calcite-1.24.0-rc0 to dev area
Modified:
dev/calcite/apache-calcite-1.24.0-rc0/apache-calcite-1.24.0-src.tar.gz
Author: chunwei
Date: Mon Jul 20 12:47:16 2020
New Revision: 40572
Log:
Uploading release candidate Apache Calcite calcite-1.24.0-rc0 to dev area
Added:
dev/calcite/apache-calcite-1.24.0-rc0/
dev/calcite/apache-calcite-1.24.0-rc0/apache-calcite-1.24.0-src.tar.gz
yuqi1129 edited a comment on pull request #1057:
URL: https://github.com/apache/calcite/pull/1057#issuecomment-660831795
@julianhyde
The cause of the problem is that, minus operator '-' is not right for type
BigDecimal when implementing unary minus function
For example
```
yuqi1129 commented on pull request #1057:
URL: https://github.com/apache/calcite/pull/1057#issuecomment-660831795
@julianhyde
The cause of the problem is that, minus operator '-' is not right for type
BigDecimal when implementing unary minus function
For example
```
int a
yuqi1129 commented on a change in pull request #1057:
URL: https://github.com/apache/calcite/pull/1057#discussion_r457094730
##
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
##
@@ -2194,7 +2193,14 @@ private Expression
23 matches
Mail list logo
