[GitHub] [calcite] julianhyde commented on pull request #2163: [CALCITE-4273] Support get expression lineage for Calc

2020-10-07 Thread GitBox
julianhyde commented on pull request #2163: URL: https://github.com/apache/calcite/pull/2163#issuecomment-705179885 Could you use `RexProgram.split`? It is very similar to your code. This is an automated message from the

[GitHub] [calcite] vlsi commented on a change in pull request #2199: [CALCITE-4301] Unit test 'testCollectionsInnerValues()' for Cassandra…

2020-10-07 Thread GitBox
vlsi commented on a change in pull request #2199: URL: https://github.com/apache/calcite/pull/2199#discussion_r501272103 ## File path: cassandra/src/test/java/org/apache/calcite/test/CassandraAdapterDataTypesTest.java ## @@ -16,18 +16,19 @@ */ package

[GitHub] [calcite] asolimando opened a new pull request #2199: [CALCITE-4301] Unit test 'testCollectionsInnerValues()' for Cassandra…

2020-10-07 Thread GitBox
asolimando opened a new pull request #2199: URL: https://github.com/apache/calcite/pull/2199 … adapter is wrong (Alessandro Solimando) This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [calcite] vlsi commented on a change in pull request #2194: [CALCITE-4315] NPE in RelMdUtil#checkInputForCollationAndLimit

2020-10-07 Thread GitBox
vlsi commented on a change in pull request #2194: URL: https://github.com/apache/calcite/pull/2194#discussion_r501204382 ## File path: core/src/test/java/org/apache/calcite/test/RelMetadataTest.java ## @@ -3132,6 +3133,35 @@ private void checkNodeTypeCount(String sql, Map,

[GitHub] [calcite] vlsi opened a new pull request #2198: Refactor ResultSetEnumerable to avoid nested lambdas

2020-10-07 Thread GitBox
vlsi opened a new pull request #2198: URL: https://github.com/apache/calcite/pull/2198 This reduces the likelihood of javac issues. See https://github.com/policeman-tools/forbidden-apis/issues/173 This is an automated

[GitHub] [calcite] vlsi merged pull request #2195: Use jackson-bom to specify Jackson versions

2020-10-07 Thread GitBox
vlsi merged pull request #2195: URL: https://github.com/apache/calcite/pull/2195 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[calcite] branch master updated: Use jackson-bom to specify Jackson versions

2020-10-07 Thread vladimirsitnikov
This is an automated email from the ASF dual-hosted git repository. vladimirsitnikov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 532f903 Use jackson-bom to specify

[GitHub] [calcite] vlsi opened a new pull request #2197: [CALCITE-4316] Avoid NPE when nulls are used in divide call

2020-10-07 Thread GitBox
vlsi opened a new pull request #2197: URL: https://github.com/apache/calcite/pull/2197 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] vlsi opened a new pull request #2196: [CALCITE-4304] Make org.apache.calcite.jdbc.JavaTypeFactoryImpl#getJavaClass non-nullable

2020-10-07 Thread GitBox
vlsi opened a new pull request #2196: URL: https://github.com/apache/calcite/pull/2196 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] vlsi opened a new pull request #2195: Use jackson-bom to specify Jackson versions

2020-10-07 Thread GitBox
vlsi opened a new pull request #2195: URL: https://github.com/apache/calcite/pull/2195 It enables to configure version constraints for all Jackson modules at once. This is an automated message from the Apache Git Service. To

[GitHub] [calcite] vlsi commented on a change in pull request #2194: [CALCITE-4315] NPE in RelMdUtil#checkInputForCollationAndLimit

2020-10-07 Thread GitBox
vlsi commented on a change in pull request #2194: URL: https://github.com/apache/calcite/pull/2194#discussion_r501148203 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdUtil.java ## @@ -872,23 +872,36 @@ public static boolean

[GitHub] [calcite] rubenada commented on a change in pull request #2194: [CALCITE-4315] NPE in RelMdUtil#checkInputForCollationAndLimit

2020-10-07 Thread GitBox
rubenada commented on a change in pull request #2194: URL: https://github.com/apache/calcite/pull/2194#discussion_r501140447 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdUtil.java ## @@ -872,23 +872,36 @@ public static boolean

[GitHub] [calcite] rubenada commented on pull request #2194: [CALCITE-4315] NPE in RelMdUtil#checkInputForCollationAndLimit

2020-10-07 Thread GitBox
rubenada commented on pull request #2194: URL: https://github.com/apache/calcite/pull/2194#issuecomment-705043377 @vlsi the root cause seems to be this change https://github.com/apache/calcite/commit/2f1d764297233a60fed85dd10f2954240da6663a Now the "default" `mq.collations` is `null`

[GitHub] [calcite] rubenada opened a new pull request #2194: [CALCITE-4315] NPE in RelMdUtil#checkInputForCollationAndLimit

2020-10-07 Thread GitBox
rubenada opened a new pull request #2194: URL: https://github.com/apache/calcite/pull/2194 CALCITE-4315: RelMdUtil#checkInputForCollationAndLimit does not check for null after calling mq.collations(input), which results in NPE. Also add several simplifications and early returns.

[GitHub] [calcite] yanlin-Lynn commented on a change in pull request #2163: [CALCITE-4273] Support get expression lineage for Calc

2020-10-07 Thread GitBox
yanlin-Lynn commented on a change in pull request #2163: URL: https://github.com/apache/calcite/pull/2163#discussion_r500926077 ## File path: core/src/test/java/org/apache/calcite/test/RelMetadataTest.java ## @@ -2506,6 +2506,30 @@ private void checkPredicates(RelOptCluster

[GitHub] [calcite] yanlin-Lynn commented on a change in pull request #2163: [CALCITE-4273] Support get expression lineage for Calc

2020-10-07 Thread GitBox
yanlin-Lynn commented on a change in pull request #2163: URL: https://github.com/apache/calcite/pull/2163#discussion_r500925267 ## File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java ## @@ -3607,6 +3607,25 @@ public int size() { return

[calcite] branch site updated: Site: change 1.25.0 release date to 2020-08-22

2020-10-07 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch site in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/site by this push: new 7238571 Site: change 1.25.0 release date to

[calcite] branch site updated (69e812f -> 2391c20)

2020-10-07 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a change to branch site in repository https://gitbox.apache.org/repos/asf/calcite.git. omit 69e812f Site: change 1.25.0 release date to 2020-08-22 omit 1552765 [CALCITE-4314] Suppress the current

[calcite] branch site updated (b659447 -> 69e812f)

2020-10-07 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a change to branch site in repository https://gitbox.apache.org/repos/asf/calcite.git. discard b659447 Site: Add Rui Wang as committer, Ruben Quesada Lopez as PMC discard 8cf0701 Site: change release date to

[calcite] branch master updated: Site: change 1.25.0 release date to 2020-08-22

2020-10-07 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 69e812f Site: change 1.25.0 release date to