[calcite] branch master updated: [CALCITE-4414] RelMdSelectivity#getSelectivity for Calc can propagate a predicate with wrong references

2020-11-26 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new b4e399c [CALCITE-4414]

[GitHub] [calcite] rubenada merged pull request #2275: [CALCITE-4414] RelMdSelectivity#getSelectivity for Calc can propagate a predicate with wrong references

2020-11-26 Thread GitBox
rubenada merged pull request #2275: URL: https://github.com/apache/calcite/pull/2275 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] liyafan82 opened a new pull request #2282: [CALCITE-4420] Some simple arithmetic operations can be simplified

2020-11-26 Thread GitBox
liyafan82 opened a new pull request #2282: URL: https://github.com/apache/calcite/pull/2282 Some simple arithmetic operations can be simplified, for example: ``` a + 0 = a a - 0 = a a * 1 = a a / 1 = a ``` In our product, we found such scenarios are fairly

[GitHub] [calcite] rubenada commented on pull request #2272: [CALCITE-4409] Improve exception when RelBuilder tries to create a field on a non-struct expression

2020-11-26 Thread GitBox
rubenada commented on pull request #2272: URL: https://github.com/apache/calcite/pull/2272#issuecomment-734242901 Merged. Thanks everyone for the feedback. This is an automated message from the Apache Git Service. To

[calcite] branch master updated: [CALCITE-4409] Improve exception when RelBuilder tries to create a field on a non-struct expression

2020-11-26 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new fc912eb [CALCITE-4409] Improve exception

[GitHub] [calcite] rubenada merged pull request #2272: [CALCITE-4409] Improve exception when RelBuilder tries to create a field on a non-struct expression

2020-11-26 Thread GitBox
rubenada merged pull request #2272: URL: https://github.com/apache/calcite/pull/2272 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] rubenada commented on a change in pull request #2272: [CALCITE-4409] Improve exception when RelBuilder tries to create a field on a non-struct expression

2020-11-26 Thread GitBox
rubenada commented on a change in pull request #2272: URL: https://github.com/apache/calcite/pull/2272#discussion_r530854802 ## File path: core/src/test/java/org/apache/calcite/test/RelBuilderTest.java ## @@ -2577,6 +2577,22 @@ private RelNode buildRelWithDuplicateAggregates(

[GitHub] [calcite] danny0405 commented on a change in pull request #2272: [CALCITE-4409] Improve exception when RelBuilder tries to create a field on a non-struct expression

2020-11-26 Thread GitBox
danny0405 commented on a change in pull request #2272: URL: https://github.com/apache/calcite/pull/2272#discussion_r528690456 ## File path: core/src/main/java/org/apache/calcite/rel/type/RelDataTypeImpl.java ## @@ -79,6 +79,10 @@ protected RelDataTypeImpl() { @Override

[GitHub] [calcite] vlsi commented on a change in pull request #2272: [CALCITE-4409] Improve exception when RelBuilder tries to create a field on a non-struct expression

2020-11-26 Thread GitBox
vlsi commented on a change in pull request #2272: URL: https://github.com/apache/calcite/pull/2272#discussion_r530843569 ## File path: core/src/test/java/org/apache/calcite/test/RelBuilderTest.java ## @@ -2577,6 +2577,22 @@ private RelNode buildRelWithDuplicateAggregates(

[GitHub] [calcite] rubenada commented on a change in pull request #2272: [CALCITE-4409] Improve exception when RelBuilder tries to create a field on a non-struct expression

2020-11-26 Thread GitBox
rubenada commented on a change in pull request #2272: URL: https://github.com/apache/calcite/pull/2272#discussion_r530843016 ## File path: core/src/test/java/org/apache/calcite/test/RelBuilderTest.java ## @@ -2577,6 +2577,22 @@ private RelNode buildRelWithDuplicateAggregates(

[GitHub] [calcite] vlsi commented on a change in pull request #2272: [CALCITE-4409] Improve exception when RelBuilder tries to create a field on a non-struct expression

2020-11-26 Thread GitBox
vlsi commented on a change in pull request #2272: URL: https://github.com/apache/calcite/pull/2272#discussion_r530840840 ## File path: core/src/test/java/org/apache/calcite/test/RelBuilderTest.java ## @@ -2577,6 +2577,22 @@ private RelNode buildRelWithDuplicateAggregates(

[GitHub] [calcite] rubenada commented on a change in pull request #2272: [CALCITE-4409] Improve exception when RelBuilder tries to create a field on a non-struct expression

2020-11-26 Thread GitBox
rubenada commented on a change in pull request #2272: URL: https://github.com/apache/calcite/pull/2272#discussion_r530836466 ## File path: core/src/test/java/org/apache/calcite/test/RelBuilderTest.java ## @@ -2577,6 +2577,22 @@ private RelNode buildRelWithDuplicateAggregates(