[GitHub] [calcite] asfgit closed pull request #2271: CALCITE-4408 Adding an operand type checker for the Oracle substring …

asfgit closed pull request #2271: URL: https://github.com/apache/calcite/pull/2271 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[calcite] branch master updated: [CALCITE-4408] Implement Oracle SUBSTR function (James Starr)

This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 0327135 [CALCITE-4408] Implement Oracle SUBSTR

[GitHub] [calcite] Aaaaaaron commented on pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

Aaron commented on pull request #2253: URL: https://github.com/apache/calcite/pull/2253#issuecomment-738540676 @vlsi Thanks for your nice review, I update my PR, here a separate commit for your to review again, thanks again!

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

Aaron commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r535793489 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1698,6 +1699,113 @@ RexNode simplifyAnd2ForUnknownAsFalse(List terms,

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

Aaron commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r535793341 ## File path: core/src/main/java/org/apache/calcite/rel/rules/ReduceExpressionsRule.java ## @@ -366,14 +368,18 @@ public

[GitHub] [calcite] julianhyde commented on pull request #2287: [CALCITE-4421] Throw IllegalArgumentException rather than AssertionError if the size of two lists to be combined is not equal

julianhyde commented on pull request #2287: URL: https://github.com/apache/calcite/pull/2287#issuecomment-738514981 -1 on this change. As I explained in the JIRA case, it is an internal method, it doesn't need detailed messages. The real fix is to createCastRel.

[GitHub] [calcite] jamesstarr commented on a change in pull request #2271: CALCITE-4408 Adding an operand type checker for the Oracle substring …

jamesstarr commented on a change in pull request #2271: URL: https://github.com/apache/calcite/pull/2271#discussion_r535574727 ## File path: core/src/main/java/org/apache/calcite/sql2rel/StandardConvertletTable.java ## @@ -1506,6 +1508,83 @@ private SqlNode

[GitHub] [calcite] julianhyde commented on a change in pull request #2271: CALCITE-4408 Adding an operand type checker for the Oracle substring …

julianhyde commented on a change in pull request #2271: URL: https://github.com/apache/calcite/pull/2271#discussion_r535566439 ## File path: core/src/main/java/org/apache/calcite/sql2rel/StandardConvertletTable.java ## @@ -1506,6 +1508,83 @@ private SqlNode

[GitHub] [calcite] vlsi commented on a change in pull request #2271: CALCITE-4408 Adding an operand type checker for the Oracle substring …

vlsi commented on a change in pull request #2271: URL: https://github.com/apache/calcite/pull/2271#discussion_r535559413 ## File path: core/src/main/java/org/apache/calcite/sql2rel/StandardConvertletTable.java ## @@ -1506,6 +1508,83 @@ private SqlNode getCastedSqlNode(SqlNode

[GitHub] [calcite] jamesstarr commented on pull request #2271: CALCITE-4408 Adding an operand type checker for the Oracle substring …

jamesstarr commented on pull request #2271: URL: https://github.com/apache/calcite/pull/2271#issuecomment-738236166 If this looks good, can I get this merged? This is an automated message from the Apache Git Service. To

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

Aaron commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r535309649 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1698,6 +1699,113 @@ RexNode simplifyAnd2ForUnknownAsFalse(List terms,

[GitHub] [calcite] adibasak closed pull request #2289: SINGLE_VALUE support in snowflake dialect

adibasak closed pull request #2289: URL: https://github.com/apache/calcite/pull/2289 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

Aaron commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r535300256 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1698,6 +1699,113 @@ RexNode simplifyAnd2ForUnknownAsFalse(List terms,

[GitHub] [calcite] adibasak opened a new pull request #2289: SINGLE_VALUE support in snowflake dialect

adibasak opened a new pull request #2289: URL: https://github.com/apache/calcite/pull/2289 RAV-4060 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

Aaron commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r535278012 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1698,6 +1699,113 @@ RexNode simplifyAnd2ForUnknownAsFalse(List terms,

[GitHub] [calcite] vlsi commented on a change in pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

vlsi commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r535284335 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1698,6 +1699,113 @@ RexNode simplifyAnd2ForUnknownAsFalse(List terms,

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

Aaron commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r535283140 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1698,6 +1699,113 @@ RexNode simplifyAnd2ForUnknownAsFalse(List terms,

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

Aaron commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r535282207 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1698,6 +1699,113 @@ RexNode simplifyAnd2ForUnknownAsFalse(List terms,

[GitHub] [calcite] vlsi commented on a change in pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

vlsi commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r535278601 ## File path: core/src/main/java/org/apache/calcite/rel/rules/ReduceExpressionsRule.java ## @@ -366,14 +368,18 @@ public JoinReduceExpressionsRule(Class

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

Aaron commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r535278012 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1698,6 +1699,113 @@ RexNode simplifyAnd2ForUnknownAsFalse(List terms,

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

Aaron commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r535269911 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1698,6 +1699,113 @@ RexNode simplifyAnd2ForUnknownAsFalse(List terms,

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

Aaron commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r535269911 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1698,6 +1699,113 @@ RexNode simplifyAnd2ForUnknownAsFalse(List terms,

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

Aaron commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r535266761 ## File path: core/src/main/java/org/apache/calcite/rel/rules/ReduceExpressionsRule.java ## @@ -366,14 +368,18 @@ public

[GitHub] [calcite] vlsi commented on a change in pull request #2287: [CALCITE-4421] Throw IllegalArgumentException rather than AssertionError if the size of two lists to be combined is not equal

vlsi commented on a change in pull request #2287: URL: https://github.com/apache/calcite/pull/2287#discussion_r535208815 ## File path: core/src/main/java/org/apache/calcite/util/Pair.java ## @@ -185,7 +185,8 @@ public Pair(T1 left, T2 right) { final int size; if

[GitHub] [calcite] vlsi commented on a change in pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

vlsi commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r535193856 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1698,6 +1699,113 @@ RexNode simplifyAnd2ForUnknownAsFalse(List terms,

[GitHub] [calcite] vlsi commented on a change in pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

vlsi commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r535192101 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1698,6 +1699,113 @@ RexNode simplifyAnd2ForUnknownAsFalse(List terms,

[GitHub] [calcite] liyafan82 commented on a change in pull request #2287: [CALCITE-4421] Throw IllegalArgumentException rather than AssertionError if the size of two lists to be combined is not equal

liyafan82 commented on a change in pull request #2287: URL: https://github.com/apache/calcite/pull/2287#discussion_r535192111 ## File path: core/src/test/java/org/apache/calcite/util/UtilTest.java ## @@ -967,6 +968,17 @@ private String toString(byte[] bytes) {

[GitHub] [calcite] liyafan82 commented on a change in pull request #2287: [CALCITE-4421] Throw IllegalArgumentException rather than AssertionError if the size of two lists to be combined is not equal

liyafan82 commented on a change in pull request #2287: URL: https://github.com/apache/calcite/pull/2287#discussion_r535191253 ## File path: core/src/main/java/org/apache/calcite/util/Pair.java ## @@ -185,7 +185,8 @@ public Pair(T1 left, T2 right) { final int size; if

[GitHub] [calcite] vlsi commented on a change in pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

vlsi commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r535190457 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1698,6 +1699,113 @@ RexNode simplifyAnd2ForUnknownAsFalse(List terms,

[GitHub] [calcite] liyafan82 opened a new pull request #2288: [CALCITE-4425] Class DefaultEdge lacks a proper toString implementation (Liya Fan)

liyafan82 opened a new pull request #2288: URL: https://github.com/apache/calcite/pull/2288 It is convenient to build a graph as an object of `DefaultDirectedGraph`. The class has a good `toString` implementation, which greatly helps examining the structure of the graph. However, the

[GitHub] [calcite] vlsi commented on a change in pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

vlsi commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r535189391 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1698,6 +1699,113 @@ RexNode simplifyAnd2ForUnknownAsFalse(List terms,

[GitHub] [calcite] vlsi commented on a change in pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

vlsi commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r535187606 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1698,6 +1699,113 @@ RexNode simplifyAnd2ForUnknownAsFalse(List terms,

[GitHub] [calcite] vlsi commented on a change in pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

vlsi commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r535186389 ## File path: core/src/main/java/org/apache/calcite/rel/rules/ReduceExpressionsRule.java ## @@ -366,14 +368,18 @@ public JoinReduceExpressionsRule(Class

[GitHub] [calcite] rubenada edited a comment on pull request #2253: [CALCITE-4385] Simplifies AND/OR condition that has common expressions, extract and eliminate/merge them as much as possible (Jiatao

rubenada edited a comment on pull request #2253: URL: https://github.com/apache/calcite/pull/2253#issuecomment-737881822 You're welcome @Aaron , thanks for your work. @vlsi you reviewed this PR some time ago, I think now it is in a pretty good shape, do you want to take a final

[GitHub] [calcite] rubenada commented on pull request #2253: [CALCITE-4385] Simplifies AND/OR condition that has common expressions, extract and eliminate/merge them as much as possible (Jiatao Tao)

rubenada commented on pull request #2253: URL: https://github.com/apache/calcite/pull/2253#issuecomment-737881822 You're welcome @Aaron , thanks for your work. @vlsi you reviewed this PR some time ago, I think now it is in a pretty good shape, do you want to take a look?

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2253: [CALCITE-4385] Simplifies AND/OR condition that has common expressions, extract and eliminate/merge them as much as possible (

Aaron commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r535081748 ## File path: core/src/test/java/org/apache/calcite/rex/RexProgramTest.java ## @@ -3159,4 +3160,44 @@ private SqlSpecialOperatorWithPolicy(String name,

[calcite] branch master updated: [CALCITE-4419] Posix regex operators cannot be used within RelBuilder

This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new d9b55b4 [CALCITE-4419] Posix regex operators

[GitHub] [calcite] rubenada merged pull request #2280: [CALCITE-4419] Posix regex operators cannot be used within RelBuilder

rubenada merged pull request #2280: URL: https://github.com/apache/calcite/pull/2280 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go