[GitHub] [calcite] asfgit closed pull request #2317: [CALCITE-4443] Add support for ILIKE to core

2021-01-07 Thread GitBox
asfgit closed pull request #2317: URL: https://github.com/apache/calcite/pull/2317 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[calcite] branch master updated: [CALCITE-4443] Add ILIKE operator (as LIKE, but case-insensitive and PostgreSQL-specific) (Ondřej Štumpf)

2021-01-07 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 174a707 [CALCITE-4443] Add ILIKE operator (as

[GitHub] [calcite] julianhyde commented on a change in pull request #2312: [CALCITE-4265] Improve error message when CAST to unknown type (Louis…

2021-01-07 Thread GitBox
julianhyde commented on a change in pull request #2312: URL: https://github.com/apache/calcite/pull/2312#discussion_r553507779 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlCastFunction.java ## @@ -93,6 +95,29 @@ public SqlCastFunction() { //~ Methods

[GitHub] [calcite] vlsi opened a new pull request #2318: Clone burrunan/gradle-cache-action to workaround ASF Actions limitation

2021-01-07 Thread GitBox
vlsi opened a new pull request #2318: URL: https://github.com/apache/calcite/pull/2318 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] ostumpf opened a new pull request #2317: [CALCITE-4443] Add support for ILIKE to core

2021-01-07 Thread GitBox
ostumpf opened a new pull request #2317: URL: https://github.com/apache/calcite/pull/2317 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [calcite-avatica] kent-nguyen commented on pull request #126: [CALCITE-4181] Fix exception when selecting List

2021-01-07 Thread GitBox
kent-nguyen commented on pull request #126: URL: https://github.com/apache/calcite-avatica/pull/126#issuecomment-756016104 Thank you @rubenada I have updated the commit message on that detail. I am looking forward to the merge. Cheers.

[GitHub] [calcite-avatica] rubenada commented on pull request #126: [CALCITE-4181] Fix exception when selecting List

2021-01-07 Thread GitBox
rubenada commented on pull request #126: URL: https://github.com/apache/calcite-avatica/pull/126#issuecomment-756005762 I am not too familiar with avatica module, but the change LGTM; and it provides the required unit tests. I will merge it in the next 24/48 h if nobody presents any

[GitHub] [calcite-avatica] kent-nguyen edited a comment on pull request #126: [CALCITE-4181] Fix exception when selecting List

2021-01-07 Thread GitBox
kent-nguyen edited a comment on pull request #126: URL: https://github.com/apache/calcite-avatica/pull/126#issuecomment-755985895 Thank you @rubenada for your guideline. I have squashed the commits, and updated the message as instructed. Please let me know if there is anything else I

[GitHub] [calcite-avatica] kent-nguyen commented on pull request #126: [CALCITE-4181] Fix exception when selecting List

2021-01-07 Thread GitBox
kent-nguyen commented on pull request #126: URL: https://github.com/apache/calcite-avatica/pull/126#issuecomment-755985895 Thank you @rubenada for your guideline. I have squashed the commits, and updated the message in instructed. Please let me know if there is anything else I should

[GitHub] [calcite-avatica] rubenada edited a comment on pull request #126: [CALCITE-4181] Fix exception when selecting List

2021-01-07 Thread GitBox
rubenada edited a comment on pull request #126: URL: https://github.com/apache/calcite-avatica/pull/126#issuecomment-755979245 Thanks for the contribution @kent-nguyen Please bear in mind that, as per our [contribution guidelines](https://calcite.apache.org/develop/#contributing): -

[GitHub] [calcite-avatica] rubenada edited a comment on pull request #126: [CALCITE-4181] Fix exception when selecting List

2021-01-07 Thread GitBox
rubenada edited a comment on pull request #126: URL: https://github.com/apache/calcite-avatica/pull/126#issuecomment-755979245 Thanks for the contribution @kent-nguyen Please bear in mind that, as per our [contribution guidelines](https://calcite.apache.org/develop/#contributing): -

[GitHub] [calcite-avatica] rubenada commented on pull request #126: [CALCITE-4181] Fix exception when selecting List

2021-01-07 Thread GitBox
rubenada commented on pull request #126: URL: https://github.com/apache/calcite-avatica/pull/126#issuecomment-755979245 Thanks for the contribution @kent-nguyen Please bear in mind that, as per our [contribution guidelines](https://calcite.apache.org/develop/#contributing): -

[GitHub] [calcite] rubenada commented on a change in pull request #2181: CALCITE-4264 Take CPU cost into account in VolcanoCost

2021-01-07 Thread GitBox
rubenada commented on a change in pull request #2181: URL: https://github.com/apache/calcite/pull/2181#discussion_r553187071 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoCost.java ## @@ -97,24 +97,25 @@ return io; } + int

[calcite] branch master updated: [CALCITE-4453] RexExecutorImpl#compile should use RexBuilder's type factory if possible

2021-01-07 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 1f39ffa [CALCITE-4453]

[GitHub] [calcite] rubenada merged pull request #2313: [CALCITE-4453] RexExecutorImpl#compile should use RexBuilder's type factory if possible

2021-01-07 Thread GitBox
rubenada merged pull request #2313: URL: https://github.com/apache/calcite/pull/2313 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go