[calcite] branch master updated: Site: Add info and upcoming talks for Calcite Meetup January 2021

2021-01-11 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new d2e7fec Site: Add info and upcoming talks

[calcite] branch site updated: Site: Add info and upcoming talks for Calcite Meetup January 2021

2021-01-11 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch site in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/site by this push: new a25cb1a Site: Add info and upcoming talks for

[calcite-site] branch master updated: Site: Add info and upcoming talks for Calcite Meetup January 2021

2021-01-11 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-site.git The following commit(s) were added to refs/heads/master by this push: new fa7264d Site: Add info and upcoming

[GitHub] [calcite] devozerov commented on pull request #2323: [CALCITE-4461] Do not use `Logical` nodes inside Enumerable rules

2021-01-11 Thread GitBox
devozerov commented on pull request #2323: URL: https://github.com/apache/calcite/pull/2323#issuecomment-757944915 @vlsi regarding testing, I agree that it would be great to have tests here. However, possible options, like manual testing on a per-rule basis, or an additional library, look

[GitHub] [calcite] devozerov commented on a change in pull request #2323: [CALCITE-4461] Do not use `Logical` nodes inside Enumerable rules

2021-01-11 Thread GitBox
devozerov commented on a change in pull request #2323: URL: https://github.com/apache/calcite/pull/2323#discussion_r555036185 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableAggregateRule.java ## @@ -44,7 +45,7 @@ protected

[GitHub] [calcite] vlsi commented on pull request #2319: Bump Gradle 6.7 -> 6.8

2021-01-11 Thread GitBox
vlsi commented on pull request #2319: URL: https://github.com/apache/calcite/pull/2319#issuecomment-757926021 Just in case, I would wait for a bugfix: https://github.com/gradle/gradle/issues/15731 This is an automated

[GitHub] [calcite] rubenada commented on a change in pull request #2323: [CALCITE-4461] Do not use `Logical` nodes inside Enumerable rules

2021-01-11 Thread GitBox
rubenada commented on a change in pull request #2323: URL: https://github.com/apache/calcite/pull/2323#discussion_r554997402 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableAggregateRule.java ## @@ -44,7 +45,7 @@ protected

[GitHub] [calcite] Aaaaaaron commented on pull request #2323: [CALCITE-4461] Do not use `Logical` nodes inside Enumerable rules

2021-01-11 Thread GitBox
Aaron commented on pull request #2323: URL: https://github.com/apache/calcite/pull/2323#issuecomment-757903130 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] vlsi commented on pull request #2323: [CALCITE-4461] Do not use `Logical` nodes inside Enumerable rules

2021-01-11 Thread GitBox
vlsi commented on pull request #2323: URL: https://github.com/apache/calcite/pull/2323#issuecomment-757852989 Another possibility for a test case is ArchUnit with a check like "`enumerable/*` rules must not have casts to `Logical*` types"

[GitHub] [calcite] vlsi commented on pull request #2323: [CALCITE-4461] Do not use `Logical` nodes inside Enumerable rules

2021-01-11 Thread GitBox
vlsi commented on pull request #2323: URL: https://github.com/apache/calcite/pull/2323#issuecomment-757852039 Looks good, however, I wonder if it is possible to create a test for such cases. Apparently, trying to instantiate every possible rule with a custom "non-logical" rel is a

[GitHub] [calcite] devozerov opened a new pull request #2323: [CALCITE-4461] Do not use `Logical` nodes inside Enumerable rules

2021-01-11 Thread GitBox
devozerov opened a new pull request #2323: URL: https://github.com/apache/calcite/pull/2323 This PR removes casts to `Logical` operators in `Enumerable` rules. This is an automated message from the Apache Git Service. To

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2320: [CALCITE-4458] The "rowTypeCoercion" for "SET" operations should be "OR" relationship (Jiatao Tao)

2021-01-11 Thread GitBox
Aaron commented on a change in pull request #2320: URL: https://github.com/apache/calcite/pull/2320#discussion_r554895322 ## File path: core/src/main/java/org/apache/calcite/sql/validate/implicit/TypeCoercionImpl.java ## @@ -122,7 +122,7 @@ public

[GitHub] [calcite-avatica] rubenada merged pull request #126: [CALCITE-4181] Fix exception when selecting List

2021-01-11 Thread GitBox
rubenada merged pull request #126: URL: https://github.com/apache/calcite-avatica/pull/126 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[calcite-avatica] branch master updated: [CALCITE-4181] Avatica throws exception when select field is a List (Kent Nguyen)

2021-01-11 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git The following commit(s) were added to refs/heads/master by this push: new ed44494 [CALCITE-4181] Avatica