[GitHub] [calcite] vlsi commented on a change in pull request #2357: [CALCITE-4446] Implement three-valued logic for SEARCH operator

vlsi commented on a change in pull request #2357: URL: https://github.com/apache/calcite/pull/2357#discussion_r585302433 ## File path: core/src/test/java/org/apache/calcite/rex/RexProgramTest.java ## @@ -1750,13 +1766,13 @@ private void checkExponentialCnf(int n) { @Test

[GitHub] [calcite] vlsi commented on a change in pull request #2357: [CALCITE-4446] Implement three-valued logic for SEARCH operator

vlsi commented on a change in pull request #2357: URL: https://github.com/apache/calcite/pull/2357#discussion_r585298599 ## File path: core/src/test/java/org/apache/calcite/rex/RexProgramTest.java ## @@ -931,15 +931,17 @@ private void checkExponentialCnf(int n) {

[GitHub] [calcite] julianhyde commented on pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

julianhyde commented on pull request #2253: URL: https://github.com/apache/calcite/pull/2253#issuecomment-788584354 @Aaron, We are showing respect. But we are volunteers, and reviewing changes takes time away from other work we could be doing. This conversation has 84 entries. Every

[GitHub] [calcite] Aaaaaaron edited a comment on pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

Aaron edited a comment on pull request #2253: URL: https://github.com/apache/calcite/pull/2253#issuecomment-788558782 > Can we please set a hard limit on the maximum number of back-and-forth, and close/reject PRs that exceed it? > > I see the PR does not meet code/performance

[GitHub] [calcite] Aaaaaaron edited a comment on pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

Aaron edited a comment on pull request #2253: URL: https://github.com/apache/calcite/pull/2253#issuecomment-788558782 > Can we please set a hard limit on the maximum number of back-and-forth, and close/reject PRs that exceed it? > > I see the PR does not meet code/performance

[GitHub] [calcite] Aaaaaaron commented on pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

Aaron commented on pull request #2253: URL: https://github.com/apache/calcite/pull/2253#issuecomment-788558782 > Can we please set a hard limit on the maximum number of back-and-forth, and close/reject PRs that exceed it? > > I see the PR does not meet code/performance quality,

[GitHub] [calcite] vlsi commented on a change in pull request #2357: [CALCITE-4446] Implement three-valued logic for SEARCH operator

vlsi commented on a change in pull request #2357: URL: https://github.com/apache/calcite/pull/2357#discussion_r584913833 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -2850,12 +2838,46 @@ static RexNode fix(RexBuilder rexBuilder, RexNode term)

[GitHub] [calcite] vlsi commented on a change in pull request #1766: [CALCITE-3745] UnitCompiler can not find required class information.

vlsi commented on a change in pull request #1766: URL: https://github.com/apache/calcite/pull/1766#discussion_r584623885 ## File path: core/src/main/java/org/apache/calcite/util/javac/CalciteCompilerArgs.java ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software

[GitHub] [calcite] liyafan82 commented on a change in pull request #2356: [CALCITE-4510] RexLiteral can produce wrong digest for some user defined types

liyafan82 commented on a change in pull request #2356: URL: https://github.com/apache/calcite/pull/2356#discussion_r584580953 ## File path: core/src/main/java/org/apache/calcite/rel/type/RelDataTypeImpl.java ## @@ -50,6 +50,12 @@ */ public abstract class RelDataTypeImpl

[GitHub] [calcite] danny0405 commented on a change in pull request #2356: [CALCITE-4510] RexLiteral can produce wrong digest for some user defined types

danny0405 commented on a change in pull request #2356: URL: https://github.com/apache/calcite/pull/2356#discussion_r584559989 ## File path: core/src/main/java/org/apache/calcite/rel/type/RelDataTypeImpl.java ## @@ -50,6 +50,12 @@ */ public abstract class RelDataTypeImpl

[GitHub] [calcite] liyafan82 commented on pull request #2356: [CALCITE-4510] RexLiteral can produce wrong digest for some user defined types

liyafan82 commented on pull request #2356: URL: https://github.com/apache/calcite/pull/2356#issuecomment-787782702 > > Sure. I have added one to emulate the user defined type that has revealed the problem. > > @liyafan82 have you pushed your latest changes? I cannot see the test

[GitHub] [calcite] rubenada merged pull request #2353: [CALCITE-2000] UNNEST a collection that has a field with nested data generates an Exception

rubenada merged pull request #2353: URL: https://github.com/apache/calcite/pull/2353 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[calcite] branch master updated: [CALCITE-2000] UNNEST a collection that has a field with nested data generates an Exception

This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 3cfeba8 [CALCITE-2000] UNNEST a collection

[GitHub] [calcite] rubenada commented on pull request #2353: [CALCITE-2000] UNNEST a collection that has a field with nested data generates an Exception

rubenada commented on pull request #2353: URL: https://github.com/apache/calcite/pull/2353#issuecomment-787772605 Thanks for your help @vlsi ! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] vlsi commented on pull request #2353: [CALCITE-2000] UNNEST a collection that has a field with nested data generates an Exception

vlsi commented on pull request #2353: URL: https://github.com/apache/calcite/pull/2353#issuecomment-787764254 I think it is good to go This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [calcite] rubenada commented on pull request #2353: [CALCITE-2000] UNNEST a collection that has a field with nested data generates an Exception

rubenada commented on pull request #2353: URL: https://github.com/apache/calcite/pull/2353#issuecomment-787759707 @vlsi do you have any other comment about this PR? Do you think it is in a good shape for merge? This is an

[GitHub] [calcite] rubenada commented on pull request #2356: [CALCITE-4510] RexLiteral can produce wrong digest for some user defined types

rubenada commented on pull request #2356: URL: https://github.com/apache/calcite/pull/2356#issuecomment-787756639 > Sure. I have added one to emulate the user defined type that has revealed the problem. @liyafan82 have you pushed your latest changes? I cannot see the test