[GitHub] [calcite] rubenada commented on a change in pull request #2418: [CALCITE-4621] SemiJoinRule throws AssertionError on ANTI join

2021-05-26 Thread GitBox
rubenada commented on a change in pull request #2418: URL: https://github.com/apache/calcite/pull/2418#discussion_r639810446 ## File path: core/src/main/java/org/apache/calcite/rel/rules/SemiJoinRule.java ## @@ -45,8 +46,9 @@ public abstract class SemiJoinRule extends

[GitHub] [calcite] rubenada commented on a change in pull request #2418: [CALCITE-4621] SemiJoinRule throws AssertionError on ANTI join

2021-05-26 Thread GitBox
rubenada commented on a change in pull request #2418: URL: https://github.com/apache/calcite/pull/2418#discussion_r639810446 ## File path: core/src/main/java/org/apache/calcite/rel/rules/SemiJoinRule.java ## @@ -45,8 +46,9 @@ public abstract class SemiJoinRule extends

[GitHub] [calcite] zabetak commented on a change in pull request #2418: [CALCITE-4621] SemiJoinRule throws AssertionError on ANTI join

2021-05-26 Thread GitBox
zabetak commented on a change in pull request #2418: URL: https://github.com/apache/calcite/pull/2418#discussion_r639788794 ## File path: core/src/main/java/org/apache/calcite/rel/rules/SemiJoinRule.java ## @@ -45,8 +46,9 @@ public abstract class SemiJoinRule extends

[GitHub] [calcite] rubenada commented on a change in pull request #2418: [CALCITE-4621] SemiJoinRule throws AssertionError on ANTI join

2021-05-26 Thread GitBox
rubenada commented on a change in pull request #2418: URL: https://github.com/apache/calcite/pull/2418#discussion_r639764325 ## File path: core/src/main/java/org/apache/calcite/rel/rules/SemiJoinRule.java ## @@ -45,8 +46,9 @@ public abstract class SemiJoinRule extends

[GitHub] [calcite] zabetak commented on a change in pull request #2418: [CALCITE-4621] SemiJoinRule throws AssertionError on ANTI join

2021-05-26 Thread GitBox
zabetak commented on a change in pull request #2418: URL: https://github.com/apache/calcite/pull/2418#discussion_r639730115 ## File path: core/src/main/java/org/apache/calcite/rel/rules/SemiJoinRule.java ## @@ -45,8 +46,9 @@ public abstract class SemiJoinRule extends

[GitHub] [calcite] rubenada commented on pull request #2349: [CALCITE-4499] FilterJoinRule misses opportunity to push filter to se…

2021-05-26 Thread GitBox
rubenada commented on pull request #2349: URL: https://github.com/apache/calcite/pull/2349#issuecomment-848650443 @jcamachor do you think you could make a final check on the PR (rebase, resolve conflits, check @zabetak last minor comments, ...) so that we can squeeze this in the next

[GitHub] [calcite] zabetak commented on a change in pull request #2370: [CALCITE-3366] RelDecorrelator supports Union (Xu Zhaohui & Jin Xing)

2021-05-26 Thread GitBox
zabetak commented on a change in pull request #2370: URL: https://github.com/apache/calcite/pull/2370#discussion_r639516358 ## File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml ## @@ -11699,6 +11699,249 @@ LogicalProject(JOB=[$1]) ]]>

[GitHub] [calcite] rubenada commented on pull request #2411: Add generic info to Map & Array annotation

2021-05-26 Thread GitBox
rubenada commented on pull request #2411: URL: https://github.com/apache/calcite/pull/2411#issuecomment-848536331 Thanks @tisonkun for the patch and for the detailed explanation! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[calcite] branch master updated: Add generic info to Map & Array annotation

2021-05-26 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 2741cc5 Add generic info to Map & Array

[GitHub] [calcite] rubenada merged pull request #2411: Add generic info to Map & Array annotation

2021-05-26 Thread GitBox
rubenada merged pull request #2411: URL: https://github.com/apache/calcite/pull/2411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,