[GitHub] [calcite] zinking commented on pull request #2448: [CALCITE-4673] Correlate variables deduplication is not triggered when custom table function presented.

2021-07-07 Thread GitBox
zinking commented on pull request #2448: URL: https://github.com/apache/calcite/pull/2448#issuecomment-876125804 looks good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [calcite] zinking commented on a change in pull request #2448: [CALCITE-4673] Correlate variables deduplication is not triggered when custom table function presented.

2021-07-07 Thread GitBox
zinking commented on a change in pull request #2448: URL: https://github.com/apache/calcite/pull/2448#discussion_r665868748 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -1255,11 +1255,11 @@ private void substituteSubQuery(Blackboard

[GitHub] [calcite] DonnyZone closed pull request #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter

2021-07-07 Thread GitBox
DonnyZone closed pull request #1792: URL: https://github.com/apache/calcite/pull/1792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[calcite] branch master updated: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter (Alon Eldar)

2021-07-07 Thread fengzhu
This is an automated email from the ASF dual-hosted git repository. fengzhu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 138c2bc [CALCITE-3775] Implicit lookup

[GitHub] [calcite] DonnyZone merged pull request #2453: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter (Alon Eldar)

2021-07-07 Thread GitBox
DonnyZone merged pull request #2453: URL: https://github.com/apache/calcite/pull/2453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] jamesstarr commented on pull request #2385: [CALCITE-4686] SubQueryRemoveRule.matchJoin should correctly rewrite all sub-queries

2021-07-07 Thread GitBox
jamesstarr commented on pull request #2385: URL: https://github.com/apache/calcite/pull/2385#issuecomment-876013310 @zabetak I pulled in master, create separate ticket and cleaned up the code, and rewrote the pull request comment. Let me know if any further changes are needed. --

[calcite] branch master updated: [CALCITE-4640] Propagate table scan hints to JDBC

2021-07-07 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 09a8a2f [CALCITE-4640] Propagate table

[GitHub] [calcite] danny0405 closed pull request #2426: [CALCITE-4640] Propagate table scan hints to JDBC

2021-07-07 Thread GitBox
danny0405 closed pull request #2426: URL: https://github.com/apache/calcite/pull/2426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[calcite] branch master updated: RelOptRulesTest improvements: - Provide relFn pattern mechanism to test a RelNode function instead of a sql string - Refactor several tests to use relFn - Refactor sim

2021-07-07 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new d46137a RelOptRulesTest improvements: -

[GitHub] [calcite] rubenada merged pull request #2440: RelOptRulesTest improvements

2021-07-07 Thread GitBox
rubenada merged pull request #2440: URL: https://github.com/apache/calcite/pull/2440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] hannerwang opened a new pull request #2454: [CALCITE-4683] In-list to join with new project generated cause replaced root leaves property to be missing

2021-07-07 Thread GitBox
hannerwang opened a new pull request #2454: URL: https://github.com/apache/calcite/pull/2454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] zabetak closed pull request #2446: [CALCITE-4668] RelBuilder.join should convert Correlate to Join if correlation variable is unused

2021-07-07 Thread GitBox
zabetak closed pull request #2446: URL: https://github.com/apache/calcite/pull/2446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[calcite] branch master updated: [CALCITE-4668] RelBuilder.join should convert Correlate to Join if correlation variable is unused (James Starr)

2021-07-07 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new a59693e [CALCITE-4668] RelBuilder.join

[GitHub] [calcite] DonnyZone edited a comment on pull request #2453: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter (Alon Eldar)

2021-07-07 Thread GitBox
DonnyZone edited a comment on pull request #2453: URL: https://github.com/apache/calcite/pull/2453#issuecomment-875381853 The style check failed. `Execution failed for task ':core:autostyleJavaCheck'. >The following files have format violations:

[GitHub] [calcite] DonnyZone edited a comment on pull request #2453: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter (Alon Eldar)

2021-07-07 Thread GitBox
DonnyZone edited a comment on pull request #2453: URL: https://github.com/apache/calcite/pull/2453#issuecomment-875381853 The style check failed. `Execution failed for task ':core:autostyleJavaCheck'. The following files have format violations:

[GitHub] [calcite] DonnyZone edited a comment on pull request #2453: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter (Alon Eldar)

2021-07-07 Thread GitBox
DonnyZone edited a comment on pull request #2453: URL: https://github.com/apache/calcite/pull/2453#issuecomment-875381853 The style check failed. `Execution failed for task ':core:autostyleJavaCheck'. > The following files have format violations:

[GitHub] [calcite] DonnyZone commented on pull request #2453: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter (Alon Eldar)

2021-07-07 Thread GitBox
DonnyZone commented on pull request #2453: URL: https://github.com/apache/calcite/pull/2453#issuecomment-875381853 The style check failed. `* What went wrong: Execution failed for task ':core:autostyleJavaCheck'. > The following files have format violations:

[GitHub] [calcite] AlonEldar89 commented on pull request #2453: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter (Alon Eldar)

2021-07-07 Thread GitBox
AlonEldar89 commented on pull request #2453: URL: https://github.com/apache/calcite/pull/2453#issuecomment-875343950 > Hi, @AlonEldar89, when you remove the extra line, could you squash the commits together? The "squash and merge" is not enabled in Calcite. So that I can merge it quickly