[GitHub] [calcite] NobiGo commented on pull request #2555: [CALCITE-4777]Casting from DECIMAL to BOOLEAN throws an exception

2021-10-06 Thread GitBox
NobiGo commented on pull request #2555: URL: https://github.com/apache/calcite/pull/2555#issuecomment-937346994 > LGTM @xuyangzhong the PR looks in a good shape, could you please squash commits into a single one so that we can merge it shortly? @rubenada As discussed in

[GitHub] [calcite] jacques-n opened a new pull request #2568: [CALCITE-4830] Remove remaining uses of ImmutableBeans

2021-10-06 Thread GitBox
jacques-n opened a new pull request #2568: URL: https://github.com/apache/calcite/pull/2568 - Supersede and deprecate two-level nested Config classes to ensure all immutables are hidden - Remove the use of @Value.Style in non-test code to ensure consistent styling - Move core to use

[GitHub] [calcite] jacques-n commented on pull request #2564: [CALCITE-4830] Move Remaining non-test modules to Immutables

2021-10-06 Thread GitBox
jacques-n commented on pull request #2564: URL: https://github.com/apache/calcite/pull/2564#issuecomment-937120563 Will replace with another PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite] jacques-n closed pull request #2564: [CALCITE-4830] Move Remaining non-test modules to Immutables

2021-10-06 Thread GitBox
jacques-n closed pull request #2564: URL: https://github.com/apache/calcite/pull/2564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] jacques-n closed pull request #2563: [CALCITE-4827] Move annotation processor configuration to base module

2021-10-06 Thread GitBox
jacques-n closed pull request #2563: URL: https://github.com/apache/calcite/pull/2563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] jacques-n commented on pull request #2563: [CALCITE-4827] Move annotation processor configuration to base module

2021-10-06 Thread GitBox
jacques-n commented on pull request #2563: URL: https://github.com/apache/calcite/pull/2563#issuecomment-937120193 Abandoning for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[calcite] branch master updated: [CALCITE-4834] JaninoRelMetadataProvider uses hardcoded class name

2021-10-06 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 50dbd12 [CALCITE-4834]

[GitHub] [calcite] rubenada merged pull request #2567: [CALCITE-4834] JaninoRelMetadataProvider uses hardcoded class name

2021-10-06 Thread GitBox
rubenada merged pull request #2567: URL: https://github.com/apache/calcite/pull/2567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] jacques-n commented on pull request #2565: Hang on build when using kapt

2021-10-06 Thread GitBox
jacques-n commented on pull request #2565: URL: https://github.com/apache/calcite/pull/2565#issuecomment-936565095 Got it, thanks for the help. I'll use the workaround for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [calcite] jacques-n closed pull request #2565: Hang on build when using kapt

2021-10-06 Thread GitBox
jacques-n closed pull request #2565: URL: https://github.com/apache/calcite/pull/2565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] rubenada opened a new pull request #2567: [CALCITE-4834] JaninoRelMetadataProvider uses hardcoded class name

2021-10-06 Thread GitBox
rubenada opened a new pull request #2567: URL: https://github.com/apache/calcite/pull/2567 See [CALCITE-4834](https://issues.apache.org/jira/browse/CALCITE-4834) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[calcite] branch master updated: Bump JDK from 15 to 17 in seed build cache CI jobs

2021-10-06 Thread vladimirsitnikov
This is an automated email from the ASF dual-hosted git repository. vladimirsitnikov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new dff775d Bump JDK from 15 to 17 in

[calcite] branch master updated: [CALCITE-4798] Gradle build fails due to deprecated metadata APIs

2021-10-06 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 3fffc31 [CALCITE-4798] Gradle build fails

[GitHub] [calcite] zabetak closed pull request #2540: [CALCITE-4798] Fixing Build

2021-10-06 Thread GitBox
zabetak closed pull request #2540: URL: https://github.com/apache/calcite/pull/2540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] vlsi opened a new pull request #2566: [CALCITE-4832] Refactor Gradle to build-logic convention plugins

2021-10-06 Thread GitBox
vlsi opened a new pull request #2566: URL: https://github.com/apache/calcite/pull/2566 This is WIP at the moment, however, the idea is that all the build logic moves to `build-logic/*` -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [calcite] rubenada commented on pull request #2555: [CALCITE-4777]Casting from DECIMAL to BOOLEAN throws an exception

2021-10-06 Thread GitBox
rubenada commented on pull request #2555: URL: https://github.com/apache/calcite/pull/2555#issuecomment-935644628 LGTM @xuyangzhong the PR looks in a good shape, could you please squash commits into a single one so that we can merge it shortly? -- This is an automated message from