[GitHub] [calcite-avatica] NobiGo commented on pull request #163: [CALCITE-4900] fixed bug when parameterValues is null in ExecuteReque…

NobiGo commented on pull request #163: URL: https://github.com/apache/calcite-avatica/pull/163#issuecomment-995406197 @Logioniz Please add unit test for this? Looks like a bug which can reproduce. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [calcite] ILuffZhe commented on pull request #2622: [CALCITE-4898] Upgrading Elasticsearch version from 7.0.1 to 7.15.2

ILuffZhe commented on pull request #2622: URL: https://github.com/apache/calcite/pull/2622#issuecomment-995340319 @jacques-n Sorry for that, I've corrected it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] jacques-n commented on pull request #2622: [CALCITE-4898] Upgrading Elasticsearch version from 7.0.1 to 7.15.2

jacques-n commented on pull request #2622: URL: https://github.com/apache/calcite/pull/2622#issuecomment-995334557 @ILuffZhe , I just realized that your commit message isn't the standard message format for Calcite commits. It should be `[CALCITE-] Short description.` -- This is an

[GitHub] [calcite] ILuffZhe commented on pull request #2622: [CALCITE-4898] Upgrading Elasticsearch version from 7.0.1 to 7.15.2

ILuffZhe commented on pull request #2622: URL: https://github.com/apache/calcite/pull/2622#issuecomment-995331024 Done. Thanks for your review. @jacques-n -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] ILuffZhe commented on a change in pull request #2622: [CALCITE-4898] Upgrading Elasticsearch version from 7.0.1 to 7.15.2

ILuffZhe commented on a change in pull request #2622: URL: https://github.com/apache/calcite/pull/2622#discussion_r770140300 ## File path: elasticsearch/build.gradle.kts ## @@ -40,7 +46,7 @@ dependencies { // https://github.com/elastic/elasticsearch/issues/49218 Review

[GitHub] [calcite] ILuffZhe commented on a change in pull request #2622: [CALCITE-4898] Upgrading Elasticsearch version from 7.0.1 to 7.15.2

ILuffZhe commented on a change in pull request #2622: URL: https://github.com/apache/calcite/pull/2622#discussion_r770138506 ## File path: elasticsearch/build.gradle.kts ## @@ -20,6 +20,12 @@ plugins { id("com.github.vlsi.gradle-extensions") } +repositories { +

[GitHub] [calcite] jacques-n commented on a change in pull request #2622: [CALCITE-4898] Upgrading Elasticsearch version from 7.0.1 to 7.15.2

jacques-n commented on a change in pull request #2622: URL: https://github.com/apache/calcite/pull/2622#discussion_r770123359 ## File path: elasticsearch/build.gradle.kts ## @@ -20,6 +20,12 @@ plugins { id("com.github.vlsi.gradle-extensions") } +repositories { +

[GitHub] [calcite] julianhyde commented on a change in pull request #2552: [CALCITE-4737] Add Volcano Visualizer for Debugging

julianhyde commented on a change in pull request #2552: URL: https://github.com/apache/calcite/pull/2552#discussion_r770065577 ## File path: core/src/main/java/org/apache/calcite/plan/visualizer/package-info.java ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software

[GitHub] [calcite] thomasrebele commented on a change in pull request #2552: [CALCITE-4737] Add Volcano Visualizer for Debugging

thomasrebele commented on a change in pull request #2552: URL: https://github.com/apache/calcite/pull/2552#discussion_r769852466 ## File path: core/src/main/resources/volcano-viz/volcano-viz-data.js ## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [calcite] thomasrebele commented on a change in pull request #2552: [CALCITE-4737] Add Volcano Visualizer for Debugging

thomasrebele commented on a change in pull request #2552: URL: https://github.com/apache/calcite/pull/2552#discussion_r769851701 ## File path: core/src/main/resources/volcano-viz/volcano-viz-data.js ## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [calcite] mgramin commented on a change in pull request #2646: [CALCITE-4936] Generalize FilterCalcMergeRule and ProjectCalcMergeRule

mgramin commented on a change in pull request #2646: URL: https://github.com/apache/calcite/pull/2646#discussion_r769602846 ## File path: core/src/main/java/org/apache/calcite/rel/rules/ProjectCalcMergeRule.java ## @@ -82,8 +82,6 @@ public

[GitHub] [calcite] thomasrebele commented on a change in pull request #2552: [CALCITE-4737] Add Volcano Visualizer for Debugging

thomasrebele commented on a change in pull request #2552: URL: https://github.com/apache/calcite/pull/2552#discussion_r769509875 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoRuleMatchVisualizer.java ## @@ -0,0 +1,312 @@ +/* + * Licensed to the

[GitHub] [calcite] thomasrebele commented on a change in pull request #2552: [CALCITE-4737] Add Volcano Visualizer for Debugging

thomasrebele commented on a change in pull request #2552: URL: https://github.com/apache/calcite/pull/2552#discussion_r769509875 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoRuleMatchVisualizer.java ## @@ -0,0 +1,312 @@ +/* + * Licensed to the

[GitHub] [calcite] thomasrebele commented on a change in pull request #2552: [CALCITE-4737] Add Volcano Visualizer for Debugging

thomasrebele commented on a change in pull request #2552: URL: https://github.com/apache/calcite/pull/2552#discussion_r769453608 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoRuleMatchVisualizer.java ## @@ -0,0 +1,312 @@ +/* + * Licensed to the

[GitHub] [calcite] thomasrebele commented on a change in pull request #2552: [CALCITE-4737] Add Volcano Visualizer for Debugging

thomasrebele commented on a change in pull request #2552: URL: https://github.com/apache/calcite/pull/2552#discussion_r769452584 ## File path: .gitignore ## @@ -52,6 +52,8 @@ settings.xml nb-configuration.xml */nb-configuration.xml +core/volcano-viz/* + Review comment:

[GitHub] [calcite] thomasrebele commented on a change in pull request #2552: [CALCITE-4737] Add Volcano Visualizer for Debugging

thomasrebele commented on a change in pull request #2552: URL: https://github.com/apache/calcite/pull/2552#discussion_r769449636 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoRuleMatchVisualizer.java ## @@ -0,0 +1,312 @@ +/* + * Licensed to the

[GitHub] [calcite] thomasrebele commented on a change in pull request #2552: [CALCITE-4737] Add Volcano Visualizer for Debugging

thomasrebele commented on a change in pull request #2552: URL: https://github.com/apache/calcite/pull/2552#discussion_r769437475 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoRuleMatchVisualizer.java ## @@ -0,0 +1,312 @@ +/* + * Licensed to the

[calcite] branch master updated (7d342b3 -> a6293a3)

This is an automated email from the ASF dual-hosted git repository. chunwei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 7d342b3 [CALCITE-4941] SemiJoinRule loses hints add a6293a3 [CALCITE-4895] MAP type in UDF cannot be

[GitHub] [calcite] chunweilei closed pull request #2614: [CALCITE-4895] MAP type in UDF cannot be externalized from json correctly

chunweilei closed pull request #2614: URL: https://github.com/apache/calcite/pull/2614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] beyond1920 edited a comment on pull request #2606: [CALCITE-4865] Extends Table function to support Polymorphic Table Function (PTF)

beyond1920 edited a comment on pull request #2606: URL: https://github.com/apache/calcite/pull/2606#issuecomment-994263802 @tmostak Thanks a lot for sharing. Would you please also share your demand in [JIRA](https://issues.apache.org/jira/browse/CALCITE-4865)? The more demand

[calcite] branch master updated: [CALCITE-4941] SemiJoinRule loses hints

This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 7d342b3 [CALCITE-4941] SemiJoinRule loses

[GitHub] [calcite] rubenada merged pull request #2647: [CALCITE-4941] SemiJoinRule loses hints

rubenada merged pull request #2647: URL: https://github.com/apache/calcite/pull/2647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: