[GitHub] [calcite] NobiGo commented on a change in pull request #2724: [CACLITE-5013] Retain parentheses if a setop has an LIMIT clause

2022-03-03 Thread GitBox
NobiGo commented on a change in pull request #2724: URL: https://github.com/apache/calcite/pull/2724#discussion_r819230289 ## File path: core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java ## @@ -3301,6 +3301,71 @@ private void

[GitHub] [calcite] jamesstarr commented on pull request #2603: [CALCITE-4882] Introduce new Lambda-based Metadata framework

2022-03-03 Thread GitBox
jamesstarr commented on pull request #2603: URL: https://github.com/apache/calcite/pull/2603#issuecomment-1058604078 > > I'm curious, what is the reason why this PR is blocked? > > I was waiting for [CALCITE-4942](https://issues.apache.org/jira/browse/CALCITE-4942) to be resolved

[GitHub] [calcite] jacques-n commented on pull request #2603: [CALCITE-4882] Introduce new Lambda-based Metadata framework

2022-03-03 Thread GitBox
jacques-n commented on pull request #2603: URL: https://github.com/apache/calcite/pull/2603#issuecomment-1058521354 > I'm curious, what is the reason why this PR is blocked? I was waiting for CALCITE-4942 to be resolved since it could potentially substantially reduce the amount of

[calcite] branch master updated: [CALCITE-5019] Avoid multiple scans when table is ProjectableFilterableTable and projections and filters act on different columns

2022-03-03 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new dcbc493 [CALCITE-5019] Avoid multiple scans

[GitHub] [calcite] rubenada merged pull request #2729: [CALCITE-5019] Avoid multiple scans when table is ProjectableFilterableTable

2022-03-03 Thread GitBox
rubenada merged pull request #2729: URL: https://github.com/apache/calcite/pull/2729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] IceMimosa commented on pull request #2729: [CALCITE-5019] Avoid multiple scans when table is ProjectableFilterableTable

2022-03-03 Thread GitBox
IceMimosa commented on pull request #2729: URL: https://github.com/apache/calcite/pull/2729#issuecomment-1058156109 @rubenada Done, thanks for reviewing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite] rubenada commented on pull request #2729: [CALCITE-5019] Avoid multiple scans when table is ProjectableFilterableTable

2022-03-03 Thread GitBox
rubenada commented on pull request #2729: URL: https://github.com/apache/calcite/pull/2729#issuecomment-1058080865 @IceMimosa the change LGTM, could you please squash commits into a single one? May I suggest as commit message something along the lines "[CALCITE-5019] Avoid multiple

[GitHub] [calcite] NobiGo commented on pull request #2736: Following [CALCITE-1794], update DruidDateTimeUtils and plans in Druid adapter

2022-03-03 Thread GitBox
NobiGo commented on pull request #2736: URL: https://github.com/apache/calcite/pull/2736#issuecomment-1057960718 Thanks for the review @zabetak. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[calcite] branch master updated: Following [CALCITE-1794], update DruidDateTimeUtils and plans in Druid adapter

2022-03-03 Thread xiong
This is an automated email from the ASF dual-hosted git repository. xiong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 6a3eea2 Following [CALCITE-1794], update

[GitHub] [calcite] NobiGo merged pull request #2736: Following [CALCITE-1794], update DruidDateTimeUtils and plans in Druid adapter

2022-03-03 Thread GitBox
NobiGo merged pull request #2736: URL: https://github.com/apache/calcite/pull/2736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[calcite] branch master updated (0e2dada -> 6febf78)

2022-03-03 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 0e2dada Site: Reorganise website update process in README & howto add 6febf78 [CALCITE-5030] Upgrade

[GitHub] [calcite] zabetak merged pull request #2738: [CALCITE-5030] Upgrade jsonpath version from 2.4.0 to 2.7.0

2022-03-03 Thread GitBox
zabetak merged pull request #2738: URL: https://github.com/apache/calcite/pull/2738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] zabetak commented on pull request #2708: Site: Reorganise website update process in README & howto

2022-03-03 Thread GitBox
zabetak commented on pull request #2708: URL: https://github.com/apache/calcite/pull/2708#issuecomment-1057958876 Thank for the reviews @ILuffZhe @rubenada @michaelmior . I addressed all the review comments in final commit to master. -- This is an automated message from the Apache Git

[GitHub] [calcite] zabetak commented on a change in pull request #2708: Site: Reorganise website update process in README & howto

2022-03-03 Thread GitBox
zabetak commented on a change in pull request #2708: URL: https://github.com/apache/calcite/pull/2708#discussion_r818572941 ## File path: site/README.md ## @@ -19,10 +19,21 @@ limitations under the License. # Apache Calcite docs site -This directory contains the code for

[GitHub] [calcite] zabetak closed pull request #2708: Site: Reorganise website update process in README & howto

2022-03-03 Thread GitBox
zabetak closed pull request #2708: URL: https://github.com/apache/calcite/pull/2708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[calcite] branch master updated: Site: Reorganise website update process in README & howto

2022-03-03 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 0e2dada Site: Reorganise website update

[GitHub] [calcite] wojustme commented on pull request #2737: [CALCITE-5029] Babel parser support identifier starting with number

2022-03-03 Thread GitBox
wojustme commented on pull request #2737: URL: https://github.com/apache/calcite/pull/2737#issuecomment-1057856818 JIRA: https://issues.apache.org/jira/browse/CALCITE-5029 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [calcite] wojustme opened a new pull request #2737: [CALCITE-5029] Babel parser support identifier starting with number

2022-03-03 Thread GitBox
wojustme opened a new pull request #2737: URL: https://github.com/apache/calcite/pull/2737 Define a plugin in parser.jj for custom identifier token, and rewrite it in babel's parser. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to