[GitHub] [calcite] asereda-gs commented on pull request #2698: [CALCITE-4992] Close the ElasticSearch RestClient in ElasticsearchTransport

asereda-gs commented on PR #2698: URL: https://github.com/apache/calcite/pull/2698#issuecomment-1092465865 The problem is that `ElasticsearchSchemaFactory` (or other `SchemaFactory` implementations for that matter) creates new resource but it doesn't know exactly when to close it, only

[GitHub] [calcite] jnturton commented on pull request #2698: [CALCITE-4992] Close the ElasticSearch RestClient in ElasticsearchTransport

jnturton commented on PR #2698: URL: https://github.com/apache/calcite/pull/2698#issuecomment-1092407150 > I understand that you want to properly manage resource lifecycle. Is there a reason you can't share existing `ElasticsearchSchema` ? > > Is there a way in your environment to

[GitHub] [calcite] asereda-gs commented on pull request #2698: [CALCITE-4992] Close the ElasticSearch RestClient in ElasticsearchTransport

asereda-gs commented on PR #2698: URL: https://github.com/apache/calcite/pull/2698#issuecomment-1092199838 Hi @jnturton , Thanks for this PR. I'm not sure that having cache inside `ElasticsearchSchemaFactory.java` is the best approach. I understand that you want to properly

[GitHub] [calcite] asereda-gs commented on pull request #2698: [CALCITE-4992] Close the ElasticSearch RestClient in ElasticsearchTransport

asereda-gs commented on PR #2698: URL: https://github.com/apache/calcite/pull/2698#issuecomment-1092199837 Hi @jnturton , Thanks for this PR. I'm not sure that having cache inside `ElasticsearchSchemaFactory.java` is the best approach. I understand that you want to properly

[GitHub] [calcite] libenchao commented on pull request #2761: [CALCITE-5073] JoinConditionPushRule cannot infer 'LHS.C1 = LHS.C2' f…

libenchao commented on PR #2761: URL: https://github.com/apache/calcite/pull/2761#issuecomment-1091643557 @NobiGo Sure, we can continue the discussion in JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] hannerwang opened a new pull request, #2768: [CALCITE-5086] Calcite supports OFFSET start LIMIT count expression

hannerwang opened a new pull request, #2768: URL: https://github.com/apache/calcite/pull/2768 support trino style query like: SELECT * FROM users OFFSET 10 LIMIT 10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [calcite] NobiGo commented on pull request #2767: [CALCITE-5027] Incorrect format for timestamp literals

NobiGo commented on PR #2767: URL: https://github.com/apache/calcite/pull/2767#issuecomment-1091596792 @asolimando This method is only used in SqlBuilder for the purposes of creating SQL queries and expressions with String. So I don't add a SQL test. -- This is an automated message

[GitHub] [calcite] jnturton commented on pull request #2698: [CALCITE-4992] Close the ElasticSearch RestClient in ElasticsearchTransport

jnturton commented on PR #2698: URL: https://github.com/apache/calcite/pull/2698#issuecomment-1091493446 Hi @ILuffZhe, is there anything more I should do here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] NobiGo commented on pull request #2761: [CALCITE-5073] JoinConditionPushRule cannot infer 'LHS.C1 = LHS.C2' f…

NobiGo commented on PR #2761: URL: https://github.com/apache/calcite/pull/2761#issuecomment-1091388684 @libenchao ``` select * from T1, T2 where T1.c1 = T2.c and T1.c2 = T2.c ``` we can push T1.c1 = T1.c2 into the left operand of the Join, which is more efficient? Yes, I

[calcite] branch master updated: [CALCITE-5079] Update code demo of tutorial

This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 32babcb90 [CALCITE-5079] Update code demo of

[GitHub] [calcite] rubenada merged pull request #2760: [CALCITE-5079] Update code demo of tutorial.

rubenada merged PR #2760: URL: https://github.com/apache/calcite/pull/2760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] asolimando commented on pull request #2767: [CALCITE-5027] Incorrect format for timestamp literals

asolimando commented on PR #2767: URL: https://github.com/apache/calcite/pull/2767#issuecomment-1091214632 @NobiGo, did you try implementing a test via SQL and extract function as Julian suggested in the Jira ticket? Such a test would be more self-describing and easier to

[GitHub] [calcite] rubenada commented on a diff in pull request #2763: [CALCITE-5048] Optimizer support dynamic parameter in LIMIT/OFFSET

rubenada commented on code in PR #2763: URL: https://github.com/apache/calcite/pull/2763#discussion_r844815785 ## core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java: ## @@ -476,14 +477,29 @@ protected RexNode removeCorrelationExpr( RelCollation

[GitHub] [calcite] rubenada commented on a diff in pull request #2763: [CALCITE-5048] Optimizer support dynamic parameter in LIMIT/OFFSET

rubenada commented on code in PR #2763: URL: https://github.com/apache/calcite/pull/2763#discussion_r844815347 ## core/src/main/java/org/apache/calcite/tools/RelBuilder.java: ## @@ -3196,12 +3197,23 @@ public RelBuilder sort(RelCollation collation) { */ public RelBuilder

[GitHub] [calcite] NobiGo opened a new pull request, #2767: [CALCITE-5027] Incorrect format for timestamp literals

NobiGo opened a new pull request, #2767: URL: https://github.com/apache/calcite/pull/2767 `Date and Time Patterns` can find in SimpleDateFormat Java Doc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above