[calcite] branch main updated: [CALCITE-5263] Improve XmlFunctions by using an XML DocumentBuilder

2022-09-07 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new ba80b9156a [CALCITE-5263] Improve XmlFunctions by

[GitHub] [calcite] rubenada merged pull request #2892: [CALCITE-5263] Improve XmlFunctions by using an XML DocumentBuilder

2022-09-07 Thread GitBox
rubenada merged PR #2892: URL: https://github.com/apache/calcite/pull/2892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] rubenada commented on a diff in pull request #2892: [CALCITE-5263] Improve XmlFunctions by using an XML DocumentBuilder

2022-09-07 Thread GitBox
rubenada commented on code in PR #2892: URL: https://github.com/apache/calcite/pull/2892#discussion_r965255752 ## core/src/main/java/org/apache/calcite/runtime/XmlFunctions.java: ## @@ -60,13 +67,41 @@ public class XmlFunctions { private static final ThreadLocal<@Nullable

[GitHub] [calcite] pjfanning commented on a diff in pull request #2892: [CALCITE-5263] Improve XmlFunctions by using an XML DocumentBuilder

2022-09-07 Thread GitBox
pjfanning commented on code in PR #2892: URL: https://github.com/apache/calcite/pull/2892#discussion_r965221384 ## core/src/main/java/org/apache/calcite/runtime/XmlFunctions.java: ## @@ -60,13 +67,41 @@ public class XmlFunctions { private static final

[calcite] branch main updated: Add tests for correlated CTEs

2022-09-07 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new df8ee289b1 Add tests for correlated CTEs df8ee289b1

[GitHub] [calcite] tjbanghart commented on pull request #2896: [CALCITE-5270] Make Firebolt dialect return false for supportsAggregateFunctionFilter

2022-09-07 Thread GitBox
tjbanghart commented on PR #2896: URL: https://github.com/apache/calcite/pull/2896#issuecomment-1239596312 Thanks for taking a look. I added a simple unit test in `RelToSqlConverterTest`. I think that should be sufficient but please let me know if it needs more. -- This is an automated

[GitHub] [calcite] bchapuis commented on pull request #2893: [CALCITE-5262] Add WKB, EWKB, GeoJSON, and GML support

2022-09-07 Thread GitBox
bchapuis commented on PR #2893: URL: https://github.com/apache/calcite/pull/2893#issuecomment-1239445331 In addition to the support for WKB, EWKB, GeoJSON, and GML, this PR adds support for a lot of the simplest ST_ functions. Most of the test cases have been adapted from examples found in

[GitHub] [calcite-avatica] Privitar closed pull request #180: Dpp 6545 performance

2022-09-07 Thread GitBox
Privitar closed pull request #180: Dpp 6545 performance URL: https://github.com/apache/calcite-avatica/pull/180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [calcite] zabetak commented on pull request #2896: [CALCITE-5270] Make Firebolt dialect return false for supportsAggregateFunctionFilter

2022-09-07 Thread GitBox
zabetak commented on PR #2896: URL: https://github.com/apache/calcite/pull/2896#issuecomment-1239232332 @tjbanghart The best place to add tests about the change is `RelToSqlConverterTest`. Please verify that generated queries actually run in `Firebolt`. -- This is an automated message

[GitHub] [calcite] rubenada commented on a diff in pull request #2892: [CALCITE-5263] Improve XmlFunctions by using an XML DocumentBuilder

2022-09-07 Thread GitBox
rubenada commented on code in PR #2892: URL: https://github.com/apache/calcite/pull/2892#discussion_r964484381 ## core/src/test/java/org/apache/calcite/test/SqlXmlFunctionsTest.java: ## @@ -36,6 +39,23 @@ */ class SqlXmlFunctionsTest { + private static final String XML =

[GitHub] [calcite] rubenada commented on a diff in pull request #2892: [CALCITE-5263] Improve XmlFunctions by using an XML DocumentBuilder

2022-09-07 Thread GitBox
rubenada commented on code in PR #2892: URL: https://github.com/apache/calcite/pull/2892#discussion_r964468020 ## core/src/main/java/org/apache/calcite/runtime/XmlFunctions.java: ## @@ -60,13 +67,41 @@ public class XmlFunctions { private static final ThreadLocal<@Nullable