[GitHub] [calcite] henneberger commented on pull request #2909: Update SqlSelect to add hints to setOperand

2022-10-21 Thread GitBox
henneberger commented on PR #2909: URL: https://github.com/apache/calcite/pull/2909#issuecomment-1287596760 Closing as invalid. This change would cause other issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [calcite] henneberger closed pull request #2909: Update SqlSelect to add hints to setOperand

2022-10-21 Thread GitBox
henneberger closed pull request #2909: Update SqlSelect to add hints to setOperand URL: https://github.com/apache/calcite/pull/2909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [calcite] HanumathRao commented on pull request #2935: [CALCITE-5314] Prune empty parts of a query by exploiting stats/metadata

2022-10-21 Thread GitBox
HanumathRao commented on PR #2935: URL: https://github.com/apache/calcite/pull/2935#issuecomment-1287499498 > > I am using the call context to get the RelMetadataQuery, I think this is not fully formed during the matching of the rule > > @HanumathRao can you elaborate a bit what you

[GitHub] [calcite] HanumathRao commented on a diff in pull request #2935: [CALCITE-5314] Prune empty parts of a query by exploiting stats/metadata

2022-10-21 Thread GitBox
HanumathRao commented on code in PR #2935: URL: https://github.com/apache/calcite/pull/2935#discussion_r1002223506 ## testkit/src/main/java/org/apache/calcite/test/catalog/MockCatalogReaderSimple.java: ## @@ -261,6 +261,14 @@ protected MockCatalogReaderSimple(RelDataTypeFactory

[GitHub] [calcite] HanumathRao commented on a diff in pull request #2935: [CALCITE-5314] Prune empty parts of a query by exploiting stats/metadata

2022-10-21 Thread GitBox
HanumathRao commented on code in PR #2935: URL: https://github.com/apache/calcite/pull/2935#discussion_r1002223406 ## core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml: ## @@ -3058,6 +3058,50 @@ LogicalSort(sort0=[$7], dir0=[ASC], fetch=[0]) +

[GitHub] [calcite] asolimando merged pull request #2901: [CALCITE-5264] Apply hint exclusion check for all rels in the RelOptCall

2022-10-21 Thread GitBox
asolimando merged PR #2901: URL: https://github.com/apache/calcite/pull/2901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[calcite] branch main updated (21110741ff -> 2feb16aee9)

2022-10-21 Thread asolimando
This is an automated email from the ASF dual-hosted git repository. asolimando pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git from 21110741ff [CALCITE-5339] Use Method#getParameterCount rather than Method#getParameterTypes to get length

[GitHub] [calcite-avatica] joshelser commented on a diff in pull request #184: CALCITE-5327 Make SSL key-store type configurable

2022-10-21 Thread GitBox
joshelser commented on code in PR #184: URL: https://github.com/apache/calcite-avatica/pull/184#discussion_r1001885363 ## server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java: ## @@ -767,6 +771,27 @@ public Builder withTLS(File keystore, String

[GitHub] [calcite] Aitozi commented on pull request #2901: [CALCITE-5264] Apply hint exclusion check for all rels in the RelOptCall

2022-10-21 Thread GitBox
Aitozi commented on PR #2901: URL: https://github.com/apache/calcite/pull/2901#issuecomment-1287071569 > @Aitozi, can you squash the commits into a single one having as commit message `[CALCITE-5264] HintStrategy rule exclusion does not match innermost rels`? As soon as this is done I am

[calcite-avatica] branch main updated: [CALCITE-5257] NVARCHAR is treated as 'UNKNOWN TYPE' when searching Oracle

2022-10-21 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git The following commit(s) were added to refs/heads/main by this push: new af0e9e44c [CALCITE-5257] NVARCHAR is

[GitHub] [calcite-avatica] rubenada merged pull request #182: [CALCITE-5257] NVARCHAR is treated as "UNKNOWN TYPE" when searching Oracle

2022-10-21 Thread GitBox
rubenada merged PR #182: URL: https://github.com/apache/calcite-avatica/pull/182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] asolimando commented on pull request #2901: [CALCITE-5264] Apply hint exclusion check for all rels in the RelOptCall

2022-10-21 Thread GitBox
asolimando commented on PR #2901: URL: https://github.com/apache/calcite/pull/2901#issuecomment-1286888938 @Aitozi, can you squash the commits into a single one having as commit message `[CALCITE-5264] HintStrategy rule exclusion does not match innermost rels`? As soon as this is done I am

[calcite-avatica] branch main updated: [CALCITE-4900] NullPointerException when send ExectuteRequest via protobuf with no parameters

2022-10-21 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git The following commit(s) were added to refs/heads/main by this push: new 74a736472 [CALCITE-4900]

[GitHub] [calcite-avatica] rubenada merged pull request #163: [CALCITE-4900] NullPointerException when send ExectuteRequest via protobuf with no parameters

2022-10-21 Thread GitBox
rubenada merged PR #163: URL: https://github.com/apache/calcite-avatica/pull/163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2819: [CALCITE-5159] Postgres dialect should support implicit cast from string literal to array literal

2022-10-21 Thread GitBox
dssysolyatin commented on code in PR #2819: URL: https://github.com/apache/calcite/pull/2819#discussion_r1001563447 ## core/src/main/java/org/apache/calcite/sql/validate/implicit/AbstractTypeCoercion.java: ## @@ -721,4 +738,31 @@ boolean canImplicitTypeCast(List types, List

[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2819: [CALCITE-5159] Postgres dialect should support implicit cast from string literal to array literal

2022-10-21 Thread GitBox
dssysolyatin commented on code in PR #2819: URL: https://github.com/apache/calcite/pull/2819#discussion_r1001561672 ## core/src/main/codegen/templates/Parser.jj: ## @@ -243,6 +243,17 @@ public class ${parser.class} extends SqlAbstractParserImpl return SqlStmtList();

[GitHub] [calcite-avatica] richardantal commented on pull request #184: CALCITE-5327 Make SSL key-store type configurable

2022-10-21 Thread GitBox
richardantal commented on PR #184: URL: https://github.com/apache/calcite-avatica/pull/184#issuecomment-1286639811 I am not able to add reviewers for this PR, but could you please take a look at it? @joshelser @julianhyde @stoty -- This is an automated message from the Apache Git