[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3169: [CALCITE-5665] Reducing ineffective matches for MaterializedViewRules and double calculation for RelOptMaterialization's M

JiajunBernoulli commented on code in PR #3169: URL: https://github.com/apache/calcite/pull/3169#discussion_r1174261967 ## core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java: ## @@ -92,6 +95,16 @@ public abstract class MaterializedViewRule

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3169: [CALCITE-5665] Reducing ineffective matches for MaterializedViewRules and double calculation for RelOptMaterialization's M

JiajunBernoulli commented on code in PR #3169: URL: https://github.com/apache/calcite/pull/3169#discussion_r1174261079 ## core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java: ## @@ -231,21 +260,11 @@ protected void perform(RelOptRuleCall call,

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3161: [CALCITE-5657] Add ARRAY_DISTINCT function (enabled in Spark library).

JiajunBernoulli commented on code in PR #3161: URL: https://github.com/apache/calcite/pull/3161#discussion_r1174258550 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -5167,6 +5167,18 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3161: [CALCITE-5657] Add ARRAY_DISTINCT function (enabled in Spark library).

JiajunBernoulli commented on code in PR #3161: URL: https://github.com/apache/calcite/pull/3161#discussion_r1174256987 ## site/_docs/reference.md: ## @@ -2647,6 +2647,7 @@ BigQuery's type system uses confusingly different names for types and functions: | m | expr1 <=> expr2

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3132: [CALCITE-5543] Implement BigQuery functions for parsing DATE, TIME, TIMESTAMP, DATETIME

sonarcloud[bot] commented on PR #3132: URL: https://github.com/apache/calcite/pull/3132#issuecomment-1518293426 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3132: [CALCITE-5543] Implement BigQuery functions for parsing DATE, TIME, TIMESTAMP, DATETIME

tjbanghart commented on code in PR #3132: URL: https://github.com/apache/calcite/pull/3132#discussion_r1174118399 ## core/src/main/java/org/apache/calcite/util/format/FormatElementEnum.java: ## @@ -39,188 +39,207 @@ * @see FormatModels#DEFAULT */ public enum

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3132: [CALCITE-5543] Implement BigQuery functions for parsing DATE, TIME, TIMESTAMP, DATETIME

tjbanghart commented on code in PR #3132: URL: https://github.com/apache/calcite/pull/3132#discussion_r1174116807 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -2650,6 +2651,63 @@ public static String formatTime(DataContext ctx, String fmtString,

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3167: [CALCITE-5660] Add array subscript operators OFFSET, ORDINAL, SAFE_OFFSET, SAFE_ORDINAL (enabled for BigQuery)

sonarcloud[bot] commented on PR #3167: URL: https://github.com/apache/calcite/pull/3167#issuecomment-1518202279 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3140: [CALCITE-5614] Serialize / deserialize Sarg

sonarcloud[bot] commented on PR #3140: URL: https://github.com/apache/calcite/pull/3140#issuecomment-1518201180 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3167: [CALCITE-5660] Add array subscript operators OFFSET, ORDINAL, SAFE_OFFSET, SAFE_ORDINAL (enabled for BigQuery)

sonarcloud[bot] commented on PR #3167: URL: https://github.com/apache/calcite/pull/3167#issuecomment-1518189193 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3167: [CALCITE-5660] Add array subscript operators OFFSET, ORDINAL, SAFE_OFFSET, SAFE_ORDINAL (enabled for BigQuery)

sonarcloud[bot] commented on PR #3167: URL: https://github.com/apache/calcite/pull/3167#issuecomment-1518157556 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3167: [CALCITE-5660] Add array subscript operators OFFSET, ORDINAL, SAFE_OFFSET, SAFE_ORDINAL (enabled for BigQuery)

sonarcloud[bot] commented on PR #3167: URL: https://github.com/apache/calcite/pull/3167#issuecomment-1518145701 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3167: [CALCITE-5660] Add array subscript operators OFFSET, ORDINAL, SAFE_OFFSET, SAFE_ORDINAL (enabled for BigQuery)

sonarcloud[bot] commented on PR #3167: URL: https://github.com/apache/calcite/pull/3167#issuecomment-1518135782 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] tanclary commented on pull request #3167: [CALCITE-5660] Add array subscript operators OFFSET, ORDINAL, SAFE_OFFSET, SAFE_ORDINAL (enabled for BigQuery)

tanclary commented on PR #3167: URL: https://github.com/apache/calcite/pull/3167#issuecomment-1518133174 > Change the commit message to 'Add array subscript operators OFFSET, ORDINAL (enabled for BigQuery)', just to conform to the usual format. > > Are people allowed to call these

[GitHub] [calcite] julianhyde commented on a diff in pull request #3132: [CALCITE-5543] Implement BigQuery functions for parsing DATE, TIME, TIMESTAMP, DATETIME

julianhyde commented on code in PR #3132: URL: https://github.com/apache/calcite/pull/3132#discussion_r1173991294 ## site/_docs/reference.md: ## @@ -2716,6 +2716,10 @@ BigQuery's type system uses confusingly different names for types and functions: | b m p | MD5(string)

[GitHub] [calcite] jkeung commented on pull request #1733: [CALCITE-3679] Allow lambda expressions in SQL queries

jkeung commented on PR #1733: URL: https://github.com/apache/calcite/pull/1733#issuecomment-1518017212 @ritesh-kapoor @danny0405 Hello, was this PR ever approved, or what was blocking it? I am looking into lambda functions in SQL queries in Calcite. -- This is an automated message from

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3170: [CALCITE-5669] Add rule to transform correlate to join when correlation variable is unused

sonarcloud[bot] commented on PR #3170: URL: https://github.com/apache/calcite/pull/3170#issuecomment-1518004335 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] zabetak opened a new pull request, #3170: [CALCITE-5669] Add rule to transform correlate to join when correlation variable is unused

zabetak opened a new pull request, #3170: URL: https://github.com/apache/calcite/pull/3170 … -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[calcite] branch main updated (2822518713 -> f500e2f157)

This is an automated email from the ASF dual-hosted git repository. rubenql pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git from 2822518713 Disable JIRA worklog notifications for GitHub PRs add f500e2f157 [CALCITE-5563] Reduce loops to

[GitHub] [calcite] rubenada merged pull request #3098: [CALCITE-5563] Reduce loops to optimize RelSubset#getParents and RelSubset#getParentSubsets

rubenada merged PR #3098: URL: https://github.com/apache/calcite/pull/3098 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] asolimando closed pull request #3047: [CALCITE-5501]: Fix flaky test by using XmlUnit

asolimando closed pull request #3047: [CALCITE-5501]: Fix flaky test by using XmlUnit URL: https://github.com/apache/calcite/pull/3047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [calcite] asolimando commented on pull request #3047: [CALCITE-5501]: Fix flaky test by using XmlUnit

asolimando commented on PR #3047: URL: https://github.com/apache/calcite/pull/3047#issuecomment-1517561455 > @clesaec @asolimando is this PR still relevant? Shall we close it? It seems its Jira ticket was already resolved in the last release. Thanks @rubenada for the reminder, I am

[GitHub] [calcite] rubenada commented on pull request #3047: [CALCITE-5501]: Fix flaky test by using XmlUnit

rubenada commented on PR #3047: URL: https://github.com/apache/calcite/pull/3047#issuecomment-1517555873 @clesaec @asolimando is this PR still relevant? Shall we close it? It seems its Jira ticket was already resolved in the last release. -- This is an automated message from the Apache

[GitHub] [calcite] zabetak closed pull request #3166: Disable JIRA worklog notifications for GitHub PRs

zabetak closed pull request #3166: Disable JIRA worklog notifications for GitHub PRs URL: https://github.com/apache/calcite/pull/3166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[calcite] branch main updated (1fe1ce8845 -> 2822518713)

This is an automated email from the ASF dual-hosted git repository. zabetak pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git from 1fe1ce8845 [CALCITE-5651] Inferred scale for decimal should not exceed maximum allowed scale add 2822518713

[calcite] branch main updated: [CALCITE-5651] Inferred scale for decimal should not exceed maximum allowed scale

This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 1fe1ce8845 [CALCITE-5651] Inferred scale for

[GitHub] [calcite] rubenada merged pull request #3156: [CALCITE-5651] Inferred scale for decimal should not exceed maximum allowed scale

rubenada merged PR #3156: URL: https://github.com/apache/calcite/pull/3156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: