olivrlee commented on PR #3168:
URL: https://github.com/apache/calcite/pull/3168#issuecomment-1522613693
@julianhyde, commit `5d36106677b705a522dbde324c854e08e284300c` is pretty
nasty, let me know if you have other suggestions.
The goal was so that we have access to `conformance` in
cgivre commented on PR #3174:
URL: https://github.com/apache/calcite/pull/3174#issuecomment-1522565801
@libenchao Thanks for the review. This is my first contribution to Calcite,
so is there anything left for me to do to get this merged?
--
This is an automated message from the Apache
cgivre commented on code in PR #3174:
URL: https://github.com/apache/calcite/pull/3174#discussion_r1177173873
##
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchSchemaFactory.java:
##
@@ -173,6 +189,16 @@ private static RestClient connect(List
cgivre commented on code in PR #3174:
URL: https://github.com/apache/calcite/pull/3174#discussion_r1177173654
##
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/UnsafeX509ExtendedTrustManager.java:
##
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software
cgivre commented on code in PR #3174:
URL: https://github.com/apache/calcite/pull/3174#discussion_r1177173476
##
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchSchemaFactory.java:
##
@@ -151,18 +188,20 @@ public ElasticsearchSchemaFactory() {
cgivre commented on code in PR #3174:
URL: https://github.com/apache/calcite/pull/3174#discussion_r1177173369
##
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchSchemaFactory.java:
##
@@ -93,6 +98,27 @@ public class ElasticsearchSchemaFactory
olivrlee commented on code in PR #3162:
URL: https://github.com/apache/calcite/pull/3162#discussion_r1176990788
##
testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java:
##
@@ -5223,6 +5223,8 @@ private static Matcher isCharLiteral(String s) {
sonarcloud[bot] commented on PR #3175:
URL: https://github.com/apache/calcite/pull/3175#issuecomment-1522186551
Kudos, SonarCloud Quality Gate passed! [ were added to refs/heads/main by this push:
new 0305067459 [CALCITE-5639] RexSimplify should
asolimando merged PR #3143:
URL: https://github.com/apache/calcite/pull/3143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #3143:
URL: https://github.com/apache/calcite/pull/3143#issuecomment-1521812880
Kudos, SonarCloud Quality Gate passed! [ were added to refs/heads/main by this push:
new cc3c5fed07 [CALCITE-5670] Assertion error in
rubenada merged PR #3172:
URL: https://github.com/apache/calcite/pull/3172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
asolimando commented on code in PR #3143:
URL: https://github.com/apache/calcite/pull/3143#discussion_r1176360488
##
core/src/main/java/org/apache/calcite/rex/RexSimplify.java:
##
@@ -1793,16 +1761,53 @@ private > RexNode
simplifyAnd2ForUnknownAsFalse(
return
libenchao commented on PR #3161:
URL: https://github.com/apache/calcite/pull/3161#issuecomment-1521594850
@liuyongvs Since @JiajunBernoulli has started to review the PR, and he has
the commit authority, I would like to defer this to him unless he is not
available.
--
This is an
LeonidChistov commented on code in PR #3143:
URL: https://github.com/apache/calcite/pull/3143#discussion_r1176334622
##
core/src/main/java/org/apache/calcite/rex/RexSimplify.java:
##
@@ -1793,16 +1761,53 @@ private > RexNode
simplifyAnd2ForUnknownAsFalse(
return
libenchao commented on PR #3174:
URL: https://github.com/apache/calcite/pull/3174#issuecomment-1521568037
> I'm using this in Drill, so once this is merged, and
https://github.com/apache/drill/pull/2795 is merged, there will be end-to-end
tests for this capability.
This sounds
sonarcloud[bot] commented on PR #3172:
URL: https://github.com/apache/calcite/pull/3172#issuecomment-1521346574
Kudos, SonarCloud Quality Gate passed! [ were added to refs/heads/main by this push:
new febd06b2cc [CALCITE-5642] Add SHA256, SHA512
rubenada merged PR #3148:
URL: https://github.com/apache/calcite/pull/3148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #3169:
URL: https://github.com/apache/calcite/pull/3169#issuecomment-1521309486
Kudos, SonarCloud Quality Gate passed! [