[GitHub] [calcite] sonarcloud[bot] commented on pull request #3182: [CALCITE-5680] Wrong plan for multiple IN sub-queries with only literal operands

sonarcloud[bot] commented on PR #3182: URL: https://github.com/apache/calcite/pull/3182#issuecomment-1528932136 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] herunkang2018 commented on a diff in pull request #3182: [CALCITE-5680] Wrong plan for multiple IN sub-queries with only literal operands

herunkang2018 commented on code in PR #3182: URL: https://github.com/apache/calcite/pull/3182#discussion_r1181158460 ## core/src/test/resources/sql/sub-query.iq: ## @@ -3544,4 +3544,33 @@ FROM UNNEST(ARRAY['a', 'b']) AS a(attidentity); !ok +# Test case for [CALCITE-5680]

[GitHub] [calcite] herunkang2018 commented on pull request #3182: [CALCITE-5680] Wrong plan for multiple IN sub-queries with only literal operands

herunkang2018 commented on PR #3182: URL: https://github.com/apache/calcite/pull/3182#issuecomment-1528927680 @JiajunBernoulli the `sub-query.iq` doesn't cover this case, and I reproduce this bug in

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3182: [CALCITE-5680] Wrong plan for multiple IN sub-queries with only literal operands

sonarcloud[bot] commented on PR #3182: URL: https://github.com/apache/calcite/pull/3182#issuecomment-1528926863 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] herunkang2018 commented on a diff in pull request #3182: [CALCITE-5680] Wrong plan for multiple IN sub-queries with only literal operands

herunkang2018 commented on code in PR #3182: URL: https://github.com/apache/calcite/pull/3182#discussion_r1181155313 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -6448,6 +6448,42 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule rule) {

[GitHub] [calcite] herunkang2018 commented on a diff in pull request #3182: [CALCITE-5680] Wrong plan for multiple IN sub-queries with only literal operands

herunkang2018 commented on code in PR #3182: URL: https://github.com/apache/calcite/pull/3182#discussion_r1181152549 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -6448,6 +6448,42 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule rule) {

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3182: [CALCITE-5680] Wrong plan for multiple IN sub-queries with only literal operands

JiajunBernoulli commented on code in PR #3182: URL: https://github.com/apache/calcite/pull/3182#discussion_r1181151377 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -6448,6 +6448,42 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule rule) {

[GitHub] [calcite] herunkang2018 commented on a diff in pull request #3182: [CALCITE-5680] Wrong plan for multiple IN sub-queries with only literal operands

herunkang2018 commented on code in PR #3182: URL: https://github.com/apache/calcite/pull/3182#discussion_r1181145198 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -6448,6 +6448,42 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule rule) {

[GitHub] [calcite] herunkang2018 commented on pull request #3182: [CALCITE-5680] Wrong plan for multiple IN sub-queries with only literal operands

herunkang2018 commented on PR #3182: URL: https://github.com/apache/calcite/pull/3182#issuecomment-1528904992 @JiajunBernoulli Thanks for reviewing, I will check `sub-query.iq`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[calcite] branch main updated: [CALCITE-5679] HepPlanner#buildFinalPlan: do not clear metadata cache if RelNode has not changed

This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new a833bd626c [CALCITE-5679]

[GitHub] [calcite] rubenada merged pull request #3181: [CALCITE-5679] HepPlanner#buildFinalPlan: do not clear metadata cache if RelNode has not changed

rubenada merged PR #3181: URL: https://github.com/apache/calcite/pull/3181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] herunkang2018 commented on a diff in pull request #3182: [CALCITE-5680] Wrong plan for multiple IN sub-queries with only literal operands

herunkang2018 commented on code in PR #3182: URL: https://github.com/apache/calcite/pull/3182#discussion_r1181094518 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -6448,6 +6448,42 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule rule) {

[GitHub] [calcite] herunkang2018 commented on a diff in pull request #3182: [CALCITE-5680] Wrong plan for multiple IN sub-queries with only literal operands

herunkang2018 commented on code in PR #3182: URL: https://github.com/apache/calcite/pull/3182#discussion_r1181094257 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -6448,6 +6448,42 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule rule) {

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3182: [CALCITE-5680] Wrong plan for multiple IN sub-queries with only literal operands

sonarcloud[bot] commented on PR #3182: URL: https://github.com/apache/calcite/pull/3182#issuecomment-1528814568 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] libenchao commented on pull request #3085: [CALCITE-5530] RelToSqlConverter[ORDER BY] generates an incorrect fie…

libenchao commented on PR #3085: URL: https://github.com/apache/calcite/pull/3085#issuecomment-1528777081 I'll do a final review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [calcite] libenchao commented on pull request #3181: [CALCITE-5679] HepPlanner#buildFinalPlan: do not clear metadata cache if RelNode has not changed

libenchao commented on PR #3181: URL: https://github.com/apache/calcite/pull/3181#issuecomment-1528776916 +1, there is no meaning to recalculate metadata for unchanged nodes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [calcite] JiajunBernoulli commented on pull request #3161: [CALCITE-5657] Add ARRAY_DISTINCT function (enabled in Spark library).

JiajunBernoulli commented on PR #3161: URL: https://github.com/apache/calcite/pull/3161#issuecomment-1528717808 @liuyongvs Do you know why the unit test cannot check result? ``` f.checkScalar("array_distinct(array[1, 2, 2, 1])", "[1]", "INTEGER NOT NULL ARRAY NOT NULL"); ```

[GitHub] [calcite] JiajunBernoulli commented on pull request #3085: [CALCITE-5530] RelToSqlConverter[ORDER BY] generates an incorrect fie…

JiajunBernoulli commented on PR #3085: URL: https://github.com/apache/calcite/pull/3085#issuecomment-1528707028 The PR also solve [CALCITE-5656](https://issues.apache.org/jira/browse/CALCITE-5656) Would you please review it again? @libenchao -- This is an automated message from

[GitHub] [calcite] JiajunBernoulli commented on pull request #2737: [CALCITE-5029] Babel parser support identifier starting with number

JiajunBernoulli commented on PR #2737: URL: https://github.com/apache/calcite/pull/2737#issuecomment-1528697315 Would you please `rebase main` and rerun CI? @wojustme -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use