[GitHub] [calcite] sonarcloud[bot] commented on pull request #3221: [CALCITE-5709] Add TO_BASE32 and FROM_BASE32 functions (enabled in BigQuery library)

2023-06-13 Thread via GitHub
sonarcloud[bot] commented on PR #3221: URL: https://github.com/apache/calcite/pull/3221#issuecomment-1590375125 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] zoudan commented on a diff in pull request #3221: [CALCITE-5709] Add TO_BASE32 and FROM_BASE32 functions (enabled in BigQuery library)

2023-06-13 Thread via GitHub
zoudan commented on code in PR #3221: URL: https://github.com/apache/calcite/pull/3221#discussion_r1228907624 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -924,6 +924,21 @@ private static RelDataType arrayReturnType(SqlOperatorBinding

[GitHub] [calcite] julianhyde commented on a diff in pull request #3247: [CALCITE-5733] Simplify "a = ARRAY[1,2] AND a = ARRAY[2,3]" to "false"

2023-06-13 Thread via GitHub
julianhyde commented on code in PR #3247: URL: https://github.com/apache/calcite/pull/3247#discussion_r1228811712 ## core/src/main/java/org/apache/calcite/rex/RexSimplify.java: ## @@ -2622,21 +2644,34 @@ private static class VariableCollector extends RexVisitorImpl { /**

[GitHub] [calcite] julianhyde commented on a diff in pull request #3253: [CALCITE-5761] Handle DECADE, CENTURY, and MILLENNIUM for DATE_TRUNC

2023-06-13 Thread via GitHub
julianhyde commented on code in PR #3253: URL: https://github.com/apache/calcite/pull/3253#discussion_r1224903801 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ## @@ -2385,16 +2385,24 @@ private static class FloorImplementor extends

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3249: [CALCITE-5477] Build with Guava 19.0.

2023-06-13 Thread via GitHub
sonarcloud[bot] commented on PR #3249: URL: https://github.com/apache/calcite/pull/3249#issuecomment-1589661559 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti…

2023-06-13 Thread via GitHub
sonarcloud[bot] commented on PR #3193: URL: https://github.com/apache/calcite/pull/3193#issuecomment-1589348950 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3257: [CALCITE-5759] 'SEARCH(1, Sarg[IS NOT NULL])' should be simplified to 'TRUE'

2023-06-13 Thread via GitHub
sonarcloud[bot] commented on PR #3257: URL: https://github.com/apache/calcite/pull/3257#issuecomment-1589201281 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] herunkang2018 commented on pull request #3257: [CALCITE-5759] 'SEARCH(1, Sarg[IS NOT NULL])' should be simplified to 'TRUE'

2023-06-13 Thread via GitHub
herunkang2018 commented on PR #3257: URL: https://github.com/apache/calcite/pull/3257#issuecomment-1589178093 @libenchao @NobiGo Thanks a lot for reviewing. I have changed the commit message / Jira title to `SEARCH(1, Sarg[IS NOT NULL]) should be simplified to TRUE` to make it more

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …

2023-06-13 Thread via GitHub
sonarcloud[bot] commented on PR #3262: URL: https://github.com/apache/calcite/pull/3262#issuecomment-1589093164 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] liuyongvs commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …

2023-06-13 Thread via GitHub
liuyongvs commented on PR #3262: URL: https://github.com/apache/calcite/pull/3262#issuecomment-1589074850 hi @rubenada do you have time to review it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …

2023-06-13 Thread via GitHub
sonarcloud[bot] commented on PR #3262: URL: https://github.com/apache/calcite/pull/3262#issuecomment-1589012371 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[calcite] branch main updated: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

2023-06-13 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 18ba66da96 [CALCITE-5728] Add ARRAY_TO_STRING

[GitHub] [calcite] rubenada merged pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

2023-06-13 Thread via GitHub
rubenada merged PR #3237: URL: https://github.com/apache/calcite/pull/3237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …

2023-06-13 Thread via GitHub
sonarcloud[bot] commented on PR #3262: URL: https://github.com/apache/calcite/pull/3262#issuecomment-1588877049 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] herunkang2018 commented on a diff in pull request #3257: [CALCITE-5759] SEARCH operator with special sarg is not fully simplified

2023-06-13 Thread via GitHub
herunkang2018 commented on code in PR #3257: URL: https://github.com/apache/calcite/pull/3257#discussion_r1227796571 ## core/src/test/java/org/apache/calcite/rex/RexProgramTest.java: ## @@ -1768,6 +1768,68 @@ private void checkExponentialCnf(int n) { checkSimplify(expr,

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …

2023-06-13 Thread via GitHub
sonarcloud[bot] commented on PR #3262: URL: https://github.com/apache/calcite/pull/3262#issuecomment-1588822290 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …

2023-06-13 Thread via GitHub
sonarcloud[bot] commented on PR #3262: URL: https://github.com/apache/calcite/pull/3262#issuecomment-1588769987 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] rubenada commented on pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

2023-06-13 Thread via GitHub
rubenada commented on PR #3237: URL: https://github.com/apache/calcite/pull/3237#issuecomment-1588763531 Thanks @zoudan , I will merge as soon as the CI checks are finished. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [calcite] zoudan commented on a diff in pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

2023-06-13 Thread via GitHub
zoudan commented on code in PR #3237: URL: https://github.com/apache/calcite/pull/3237#discussion_r122766 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4102,6 +4102,45 @@ public static List reverse(List list) { return list; } + /**

[GitHub] [calcite] rubenada commented on a diff in pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

2023-06-13 Thread via GitHub
rubenada commented on code in PR #3237: URL: https://github.com/apache/calcite/pull/3237#discussion_r1227642472 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4102,6 +4102,45 @@ public static List reverse(List list) { return list; } + /**

[GitHub] [calcite] liuyongvs commented on a diff in pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …

2023-06-13 Thread via GitHub
liuyongvs commented on code in PR #3262: URL: https://github.com/apache/calcite/pull/3262#discussion_r1227567195 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -1005,6 +1012,23 @@ private static RelDataType arrayReturnType(SqlOperatorBinding