[GitHub] [calcite] NobiGo commented on a diff in pull request #3279: [CALCITE-5798] '(1 < x) IS NOT TRUE' when x is not nullable should be simplified to '1 >= x'

NobiGo commented on code in PR #3279: URL: https://github.com/apache/calcite/pull/3279#discussion_r1243074743 ## core/src/test/java/org/apache/calcite/rex/RexProgramTest.java: ## @@ -2010,6 +2010,20 @@ private void checkExponentialCnf(int n) { ">(?0.int0, 0)"); }

[GitHub] [calcite] wnob commented on a diff in pull request #3206: [CALCITE-5724] Generated SQL uses literal values in ORDER BY clauses

wnob commented on code in PR #3206: URL: https://github.com/apache/calcite/pull/3206#discussion_r1243066698 ## core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java: ## @@ -1122,6 +1122,11 @@ public List fieldList() { } void addOrderItem(List

[GitHub] [calcite] herunkang2018 commented on pull request #3247: [CALCITE-5733] Simplify "a = ARRAY[1,2] AND a = ARRAY[2,3]" to "false"

herunkang2018 commented on PR #3247: URL: https://github.com/apache/calcite/pull/3247#issuecomment-1608538325 @YasuoStudyJava we should consider the case that the `RexCall` in projection, which the default RexUnknownAs is UNKNOWN, not the same as predicate in where clause. -- This is an

[GitHub] [calcite] herunkang2018 commented on a diff in pull request #3247: [CALCITE-5733] Simplify "a = ARRAY[1,2] AND a = ARRAY[2,3]" to "false"

herunkang2018 commented on code in PR #3247: URL: https://github.com/apache/calcite/pull/3247#discussion_r1242994446 ## core/src/main/java/org/apache/calcite/rex/RexSimplify.java: ## @@ -672,9 +675,28 @@ private void simplifyAndTerms(List terms, RexUnknownAs unknownAs) {

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3147: [CALCITE-5644] Implement BigQuery CONTAINS_SUBSTR

sonarcloud[bot] commented on PR #3147: URL: https://github.com/apache/calcite/pull/3147#issuecomment-1608464335 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3147: [CALCITE-5644] Implement BigQuery CONTAINS_SUBSTR

sonarcloud[bot] commented on PR #3147: URL: https://github.com/apache/calcite/pull/3147#issuecomment-1607946984 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] rubenada commented on pull request #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti…

rubenada commented on PR #3193: URL: https://github.com/apache/calcite/pull/3193#issuecomment-1607805829 Closing this in favor of https://github.com/apache/calcite/pull/3277 , which integrates the changes from the current PR too. -- This is an automated message from the Apache Git

[GitHub] [calcite] rubenada closed pull request #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti…

rubenada closed pull request #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti… URL: https://github.com/apache/calcite/pull/3193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[calcite] branch main updated: [CALCITE-5789] Query with two nested subqueries where the inner-most references the outer-most table returns wrong result [CALCITE-5683] Two level nested correlated subq

This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 7dd3ecd5a6 [CALCITE-5789] Query with two nested

[GitHub] [calcite] rubenada merged pull request #3277: [CALCITE-5789] Query with two nested subqueries where the inner-most references the outer-most table returns wrong result

rubenada merged PR #3277: URL: https://github.com/apache/calcite/pull/3277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3277: [CALCITE-5789] Query with two nested subqueries where the inner-most references the outer-most table returns wrong result

sonarcloud[bot] commented on PR #3277: URL: https://github.com/apache/calcite/pull/3277#issuecomment-1607771822 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] asolimando commented on pull request #3264: [CALCITE-5756] Expand ProjectJoinRemoveRule to support inner join remove by the foreign-unique constraint in the catalog

asolimando commented on PR #3264: URL: https://github.com/apache/calcite/pull/3264#issuecomment-1607733084 Adding "request review" from another committer given the comments in the associated Jira ticket. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3277: [CALCITE-5789] Query with two nested subqueries where the inner-most references the outer-most table returns wrong result

sonarcloud[bot] commented on PR #3277: URL: https://github.com/apache/calcite/pull/3277#issuecomment-1607731671 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] libenchao commented on a diff in pull request #3277: [CALCITE-5789] Query with two nested subqueries where the inner-most references the outer-most table returns wrong result

libenchao commented on code in PR #3277: URL: https://github.com/apache/calcite/pull/3277#discussion_r1242366055 ## core/src/main/java/org/apache/calcite/rel/rules/SubQueryRemoveRule.java: ## @@ -865,6 +866,9 @@ private static void matchFilter(SubQueryRemoveRule rule,

[GitHub] [calcite] rubenada commented on a diff in pull request #3277: [CALCITE-5789] Query with two nested subqueries where the inner-most references the outer-most table returns wrong result

rubenada commented on code in PR #3277: URL: https://github.com/apache/calcite/pull/3277#discussion_r1242360002 ## core/src/main/java/org/apache/calcite/rel/rules/SubQueryRemoveRule.java: ## @@ -865,6 +866,9 @@ private static void matchFilter(SubQueryRemoveRule rule,

[calcite] branch main updated (9ebeea96e3 -> 00db00161c)

This is an automated email from the ASF dual-hosted git repository. tanner pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git discard 9ebeea96e3 adjust operand type checker discard 0c77afd6af add ReturnTypes.VARCHAR_NULLABLE discard a60d403486 fix

[calcite] 01/01: [CALCITE-5709] Add TO_BASE32 and FROM_BASE32 functions (enabled in BigQuery library)

This is an automated email from the ASF dual-hosted git repository. tanner pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git commit 00db00161cd9a2408c7532916cdc2e826840cf53 Author: zoudan AuthorDate: Tue May 23 22:49:59 2023 +0800 [CALCITE-5709]

[calcite] 03/04: add ReturnTypes.VARCHAR_NULLABLE

This is an automated email from the ASF dual-hosted git repository. tanner pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git commit 0c77afd6af698c4c2170a9a19dd7a143a52de4fb Author: zoudan AuthorDate: Wed Jun 14 10:28:34 2023 +0800 add

[GitHub] [calcite] tanclary merged pull request #3221: [CALCITE-5709] Add TO_BASE32 and FROM_BASE32 functions (enabled in BigQuery library)

tanclary merged PR #3221: URL: https://github.com/apache/calcite/pull/3221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[calcite] 02/04: fix typo

This is an automated email from the ASF dual-hosted git repository. tanner pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git commit a60d403486d6ad599ebc353b23ff4745b5c776ff Author: zoudan AuthorDate: Wed Jun 7 10:18:02 2023 +0800 fix typo ---

[calcite] branch main updated (e969f87aea -> 9ebeea96e3)

This is an automated email from the ASF dual-hosted git repository. tanner pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git from e969f87aea [CALCITE-5778] Add ARRAY_JOIN, ARRAYS_OVERLAP, ARRAYS_ZIP function (enabled in Spark library) new

[calcite] 04/04: adjust operand type checker

This is an automated email from the ASF dual-hosted git repository. tanner pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git commit 9ebeea96e3eb0c5f76c3fe06934e8cc544559c0a Author: zoudan AuthorDate: Wed Jun 14 10:45:35 2023 +0800 adjust operand

[calcite] 01/04: [CALCITE-5709] Add TO_BASE32 and FROM_BASE32 functions (enabled in BigQuery library)

This is an automated email from the ASF dual-hosted git repository. tanner pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git commit b40ce21874c0e632343ea21b9766e5193f15047f Author: zoudan AuthorDate: Tue May 23 22:49:59 2023 +0800 [CALCITE-5709]

[GitHub] [calcite] libenchao commented on a diff in pull request #3277: [CALCITE-5789] Query with two nested subqueries where the inner-most references the outer-most table returns wrong result

libenchao commented on code in PR #3277: URL: https://github.com/apache/calcite/pull/3277#discussion_r1242064409 ## core/src/main/java/org/apache/calcite/rel/rules/SubQueryRemoveRule.java: ## @@ -865,6 +866,9 @@ private static void matchFilter(SubQueryRemoveRule rule,

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3280: [CALCITE-5786] QuidemTest and DiffRepository are not compatible with Gradle incremental builds since they write to build/resources

sonarcloud[bot] commented on PR #3280: URL: https://github.com/apache/calcite/pull/3280#issuecomment-1607020195 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] akshayabd closed pull request #3273: [CALCITE-5786] Update QuidemTest and DiffRepository to write intermediate test files to directories other than build/resources/test. This addres

akshayabd closed pull request #3273: [CALCITE-5786] Update QuidemTest and DiffRepository to write intermediate test files to directories other than build/resources/test. This addresses an incremental builds issue with the tests URL: https://github.com/apache/calcite/pull/3273 -- This is an

[GitHub] [calcite] kgyrtkirk commented on a diff in pull request #3279: [CALCITE-5798] '(1 < x) IS NOT TRUE' when x is not nullable should be simplified to '1 >= x'

kgyrtkirk commented on code in PR #3279: URL: https://github.com/apache/calcite/pull/3279#discussion_r1241723952 ## core/src/main/java/org/apache/calcite/plan/RelOptPredicateList.java: ## @@ -236,14 +236,18 @@ public boolean isEffectivelyNotNull(RexNode e) { } }

[GitHub] [calcite] liuyongvs commented on a diff in pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …

liuyongvs commented on code in PR #3262: URL: https://github.com/apache/calcite/pull/3262#discussion_r1241682226 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -3984,6 +3985,13 @@ public static List sortArray(List list, boolean ascending) {

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …

sonarcloud[bot] commented on PR #3262: URL: https://github.com/apache/calcite/pull/3262#issuecomment-1606765903 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] liuyongvs commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …

liuyongvs commented on PR #3262: URL: https://github.com/apache/calcite/pull/3262#issuecomment-1606719734 rebase to fix conflicts with main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the