njriasan commented on PR #3329:
URL: https://github.com/apache/calcite/pull/3329#issuecomment-1663288681
@jsternberg Wanted to comment an issue with this approach I found in case
you still care about this. Inside `RexLiteral` the `intervalString` method uses
the typeName information
sonarcloud[bot] commented on PR #3337:
URL: https://github.com/apache/calcite/pull/3337#issuecomment-166329
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #3307:
URL: https://github.com/apache/calcite/pull/3307#issuecomment-1663165617
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
chucheng92 commented on PR #3307:
URL: https://github.com/apache/calcite/pull/3307#issuecomment-1663157116
> > > I think this looks good and is just about ready. Would you mind
writing a RelToSqlConverter test and ensure that it gets unparsed as
SOUNDEX(..) and not SOUNDEX_SPARK(..)? Sorry
This is an automated email from the ASF dual-hosted git repository.
xiong pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 5b66bd3cfa [CALCITE-5875] Remove unnecessary NULL
NobiGo merged PR #3339:
URL: https://github.com/apache/calcite/pull/3339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #3346:
URL: https://github.com/apache/calcite/pull/3346#issuecomment-1663102314
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #3346:
URL: https://github.com/apache/calcite/pull/3346#issuecomment-1662990210
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #3346:
URL: https://github.com/apache/calcite/pull/3346#issuecomment-1662969288
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #3346:
URL: https://github.com/apache/calcite/pull/3346#issuecomment-1662928729
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
mihaibudiu commented on PR #3346:
URL: https://github.com/apache/calcite/pull/3346#issuecomment-1662918253
@zoudan I think you have implemented this function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
tanner pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 1b8dc60b76 [CALCITE-5735] Add SAFE_MULTIPLY
This is an automated email from the ASF dual-hosted git repository.
tanner pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 68d8d70e86 [CALCITE-5820] Add PARSE_URL function
tanclary commented on code in PR #3234:
URL: https://github.com/apache/calcite/pull/3234#discussion_r1282152026
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -1592,6 +1592,87 @@ public static int multiply(int b0, int b1) {
throw
tanclary commented on code in PR #3234:
URL: https://github.com/apache/calcite/pull/3234#discussion_r1282151606
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -6843,6 +6843,79 @@ private static void checkIf(SqlOperatorFixture f) {
This is an automated email from the ASF dual-hosted git repository.
asolimando pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 70986773b8 [CALCITE-5859] Compile-time
This is an automated email from the ASF dual-hosted git repository.
asolimando pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 11546ce518 [CALCITE-5837] RexUtil#pullFactors
This is an automated email from the ASF dual-hosted git repository.
libenchao pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new df73ebd3d3 Minor: the parameter names of
herunkang2018 commented on PR #3319:
URL: https://github.com/apache/calcite/pull/3319#issuecomment-1662172527
@tanclary would you like to help review if you have time? Thanks very much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
herunkang2018 commented on PR #3318:
URL: https://github.com/apache/calcite/pull/3318#issuecomment-1662171393
@NobiGo would you like to help review if you have time? Thanks very much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
NobiGo merged PR #3330:
URL: https://github.com/apache/calcite/pull/3330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
xiong pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 132cc3df5c [CALCITE-5851] Add LEVENSHTEIN function
rubenada commented on PR #3344:
URL: https://github.com/apache/calcite/pull/3344#issuecomment-1661827706
Just to confirm, @tanclary do you agree with the patch? Do you have any
other remark or I just can move on with the merge?
--
This is an automated message from the Apache Git Service.
This is an automated email from the ASF dual-hosted git repository.
rubenql pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 5b9e768d72 [CALCITE-5877] AssertionError during
rubenada merged PR #3341:
URL: https://github.com/apache/calcite/pull/3341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
herunkang2018 commented on PR #3302:
URL: https://github.com/apache/calcite/pull/3302#issuecomment-1661554408
@tjbanghart would you like to review this PR if you have time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
26 matches
Mail list logo