[GitHub] [calcite-avatica] stoty commented on pull request #224: [CALCITE-5890] Handle non-JKS truststores in Avatica client

2023-08-03 Thread via GitHub
stoty commented on PR #224: URL: https://github.com/apache/calcite-avatica/pull/224#issuecomment-1665031626 Added docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [calcite-avatica] stoty commented on pull request #224: [CALCITE-5890] Handle non-JKS truststores in Avatica client

2023-08-03 Thread via GitHub
stoty commented on PR #224: URL: https://github.com/apache/calcite-avatica/pull/224#issuecomment-1664929887 Note to self: The local branch neme is wrong. (This does not affect the contents of the PR.) -- This is an automated message from the Apache Git Service. To respond to the

[calcite] branch main updated: [CALCITE-5831] Add SOUNDEX function (enabled in Spark library)

2023-08-03 Thread tanner
This is an automated email from the ASF dual-hosted git repository. tanner pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 76ba489c13 [CALCITE-5831] Add SOUNDEX function

[GitHub] [calcite] tanclary merged pull request #3307: [CALCITE-5831] Add SOUNDEX function (enabled in Spark library)

2023-08-03 Thread via GitHub
tanclary merged PR #3307: URL: https://github.com/apache/calcite/pull/3307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] tanclary commented on pull request #3303: [CALCITE-5827] Add IS_INF and IS_NAN functions (enabled in BigQuery l…

2023-08-03 Thread via GitHub
tanclary commented on PR #3303: URL: https://github.com/apache/calcite/pull/3303#issuecomment-1664828263 @herunkang2018 @julianhyde I responded to your comments, let me know if you have any other suggestions. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] tanclary commented on a diff in pull request #3303: [CALCITE-5827] Add IS_INF and IS_NAN functions (enabled in BigQuery l…

2023-08-03 Thread via GitHub
tanclary commented on code in PR #3303: URL: https://github.com/apache/calcite/pull/3303#discussion_r1283866205 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -2106,6 +2106,11 @@ public static boolean isInf(double b0) { return

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3346: [CALCITE-5884] Type Inference rule for ARRAY_TO_STRING is incorrect

2023-08-03 Thread via GitHub
sonarcloud[bot] commented on PR #3346: URL: https://github.com/apache/calcite/pull/3346#issuecomment-1664761624 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3343: [CALCITE-5882] Compile-time evaluation of SPLIT function returns incorrect result

2023-08-03 Thread via GitHub
sonarcloud[bot] commented on PR #3343: URL: https://github.com/apache/calcite/pull/3343#issuecomment-1664704530 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] tanclary commented on pull request #3343: [CALCITE-5882] Compile-time evaluation of SPLIT function returns incorrect result

2023-08-03 Thread via GitHub
tanclary commented on PR #3343: URL: https://github.com/apache/calcite/pull/3343#issuecomment-1664422975 > @mihaibudiu could you please resolve the conflicts? (probably caused by my recent merge of [CALCITE-5879](https://issues.apache.org/jira/browse/CALCITE-5879)) > > @tanclary do

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-03 Thread via GitHub
chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283285678 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-03 Thread via GitHub
chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283227158 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-03 Thread via GitHub
chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283285678 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] herunkang2018 commented on pull request #3302: [CALCITE-5821] Add FORMAT_NUMBER function (enabled in Hive and Spark library)

2023-08-03 Thread via GitHub
herunkang2018 commented on PR #3302: URL: https://github.com/apache/calcite/pull/3302#issuecomment-1664175061 @tanclary Since he has not responded for 48h, I think we can continue. Please let me know if you have other consideration. -- This is an automated message from the Apache Git

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-03 Thread via GitHub
chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283285678 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-03 Thread via GitHub
chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283285678 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite-avatica] stoty opened a new pull request, #224: [CALCITE-5890] Handle non-JKS truststores in Avatica client

2023-08-03 Thread via GitHub
stoty opened a new pull request, #224: URL: https://github.com/apache/calcite-avatica/pull/224 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-03 Thread via GitHub
sonarcloud[bot] commented on PR #3320: URL: https://github.com/apache/calcite/pull/3320#issuecomment-1664053418 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-03 Thread via GitHub
chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283227158 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-03 Thread via GitHub
chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283236667 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-03 Thread via GitHub
chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283201032 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-03 Thread via GitHub
chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283227158 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-03 Thread via GitHub
chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283227158 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-03 Thread via GitHub
chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283201032 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-03 Thread via GitHub
chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283190892 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-03 Thread via GitHub
chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283185632 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-03 Thread via GitHub
chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283139677 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] NobiGo commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-03 Thread via GitHub
NobiGo commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1282887653 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return new

[calcite-avatica] branch main updated: [CALCITE-5748] Support Guava 32.1.1-jre

2023-08-03 Thread snuyanzin
This is an automated email from the ASF dual-hosted git repository. snuyanzin pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git The following commit(s) were added to refs/heads/main by this push: new 2736c2795 [CALCITE-5748] Support Guava

[GitHub] [calcite-avatica] snuyanzin merged pull request #220: [CALCITE-5748] Guava 32.1.1-jre

2023-08-03 Thread via GitHub
snuyanzin merged PR #220: URL: https://github.com/apache/calcite-avatica/pull/220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite-avatica] snuyanzin commented on pull request #220: [CALCITE-5748] Guava 32.1.1-jre

2023-08-03 Thread via GitHub
snuyanzin commented on PR #220: URL: https://github.com/apache/calcite-avatica/pull/220#issuecomment-1663672578 rebased and squashed commits -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [calcite-avatica] snuyanzin commented on pull request #220: [CALCITE-5748] Guava 32.1.1-jre

2023-08-03 Thread via GitHub
snuyanzin commented on PR #220: URL: https://github.com/apache/calcite-avatica/pull/220#issuecomment-1663666750 Thanks for having a look and sorry for the delay -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] rubenada commented on pull request #3343: [CALCITE-5882] Compile-time evaluation of SPLIT function returns incorrect result

2023-08-03 Thread via GitHub
rubenada commented on PR #3343: URL: https://github.com/apache/calcite/pull/3343#issuecomment-1663441909 @mihaibudiu could you please resolve the conflicts? (probable caused by my recent merge of CALCITE-5879) @tanclary do you have any other remark here? Or shall I move on with the

[calcite] branch main updated: [CALCITE-5879] AssertionError during constant reduction of SPLIT expression that returns NULL

2023-08-03 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new ffd58e3b6d [CALCITE-5879] AssertionError during

[GitHub] [calcite] rubenada merged pull request #3344: [CALCITE-5879] AssertionError during constant reduction of SPLIT expression that returns NULL

2023-08-03 Thread via GitHub
rubenada merged PR #3344: URL: https://github.com/apache/calcite/pull/3344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: